This forum has been archived. All content is frozen. Please use KDE Discuss instead.

amarok-1.4b1 gstreamer prb/patch

Tags: None
(comma "," separated)
Sammy Umar
Karma
0

amarok-1.4b1 gstreamer prb/patch

Mon Feb 13, 2006 10:33 pm
There are mulitple problems with building Amarok-1.4beta1 with
gstreamer-0.10.x, at least on some systems. Some of the problems
arise when ONLY gstreamer-0.10 is installed (no gstreamer08 or
whatever name). I am not an expert programmer but the attached
patch works for me. Some of the config patches may be moved into
one but it should give an idea asto what things are going wrong.
I am trying to build on Fedora Core 5 development tree. I have another
problem with libgpod which I will file.
Sammy Umar
Registered Member
Posts
13
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Mon Feb 13, 2006 10:38 pm
Patch
Sammy Umar
Registered Member
Posts
13
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Mon Feb 13, 2006 10:39 pm
The patch again
Sammy Umar
Registered Member
Posts
13
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Mon Feb 13, 2006 10:39 pm
OK..this time
Sammy Umar
Registered Member
Posts
13
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Mon Feb 13, 2006 10:40 pm
--- amarok-1.4/amarok/src/engine/gst10/Makefile.am.old 2006-02-11 09:01:22.000000000 -0600
+++ amarok-1.4/amarok/src/engine/gst10/Makefile.am 2006-02-12 16:58:30.000000000 -0600
@@ -6,7 +6,7 @@

INCLUDES = \\
-I$(top_srcdir)/amarok/src/engine \\
- -I$(top_srcdir)/amarok/src/engine/gst/config \\
+ -I$(top_srcdir)/amarok/src/engine/gst10/config \\
-I$(top_srcdir)/amarok/src/plugin \\
-I$(top_srcdir)/amarok/src \\
$(CFLAGS_GST10) \\
@@ -14,7 +14,7 @@

libamarok_gst10engine_plugin_la_LIBADD = \\
$(top_builddir)/amarok/src/engine/libengine.la \\
- $(top_builddir)/amarok/src/engine/gst/config/libgstconfig.la \\
+ $(top_builddir)/amarok/src/engine/gst10/config/libgstconfig.la \\
$(top_builddir)/amarok/src/plugin/libplugin.la \\
$(LIB_KFILE) \\
$(LIB_KDECORE)
--- amarok-1.4/amarok/src/engine/gst10/Makefile.in.old 2006-02-12 16:41:40.000000000 -0600
+++ amarok-1.4/amarok/src/engine/gst10/Makefile.in 2006-02-12 17:03:55.000000000 -0600
@@ -62,7 +62,7 @@
am__DEPENDENCIES_1 =
libamarok_gst10engine_plugin_la_DEPENDENCIES = \\
$(top_builddir)/amarok/src/engine/libengine.la \\
- $(top_builddir)/amarok/src/engine/gst/config/libgstconfig.la \\
+ $(top_builddir)/amarok/src/engine/gst10/config/libgstconfig.la \\
$(top_builddir)/amarok/src/plugin/libplugin.la \\
$(am__DEPENDENCIES_1) $(am__DEPENDENCIES_1)
am_libamarok_gst10engine_plugin_la_OBJECTS = gstconfigdialog.lo \\
@@ -488,7 +488,7 @@

amarok-1.4-configure-gst10.patch (byte 195 = $20) 4, 1
$ mv amarok-1.4-configure-gst10.patch amarok-1.4-configure-gst10.patch.txt
$ cat amarok-1.4-configure-gst10.patch
cat: amarok-1.4-configure-gst10.patch: No such file or directory
$ cat amarok-1.4-configure-gst10.patch.txt
--- amarok-1.4/amarok/src/engine/gst10/Makefile.am.old 2006-02-11 09:01:22.000000000 -0600
+++ amarok-1.4/amarok/src/engine/gst10/Makefile.am 2006-02-12 16:58:30.000000000 -0600
@@ -6,7 +6,7 @@

INCLUDES = \\
-I$(top_srcdir)/amarok/src/engine \\
- -I$(top_srcdir)/amarok/src/engine/gst/config \\
+ -I$(top_srcdir)/amarok/src/engine/gst10/config \\
-I$(top_srcdir)/amarok/src/plugin \\
-I$(top_srcdir)/amarok/src \\
$(CFLAGS_GST10) \\
@@ -14,7 +14,7 @@

libamarok_gst10engine_plugin_la_LIBADD = \\
$(top_builddir)/amarok/src/engine/libengine.la \\
- $(top_builddir)/amarok/src/engine/gst/config/libgstconfig.la \\
+ $(top_builddir)/amarok/src/engine/gst10/config/libgstconfig.la \\
$(top_builddir)/amarok/src/plugin/libplugin.la \\
$(LIB_KFILE) \\
$(LIB_KDECORE)
--- amarok-1.4/amarok/src/engine/gst10/Makefile.in.old 2006-02-12 16:41:40.000000000 -0600
+++ amarok-1.4/amarok/src/engine/gst10/Makefile.in 2006-02-12 17:03:55.000000000 -0600
@@ -62,7 +62,7 @@
am__DEPENDENCIES_1 =
libamarok_gst10engine_plugin_la_DEPENDENCIES = \\
$(top_builddir)/amarok/src/engine/libengine.la \\
- $(top_builddir)/amarok/src/engine/gst/config/libgstconfig.la \\
+ $(top_builddir)/amarok/src/engine/gst10/config/libgstconfig.la \\
$(top_builddir)/amarok/src/plugin/libplugin.la \\
$(am__DEPENDENCIES_1) $(am__DEPENDENCIES_1)
am_libamarok_gst10engine_plugin_la_OBJECTS = gstconfigdialog.lo \\
@@ -488,7 +488,7 @@

libamarok_gst10engine_plugin_la_LIBADD = \\
$(top_builddir)/amarok/src/engine/libengine.la \\
- $(top_builddir)/amarok/src/engine/gst/config/libgstconfig.la \\
+ $(top_builddir)/amarok/src/engine/gst10/config/libgstconfig.la \\
$(top_builddir)/amarok/src/plugin/libplugin.la \\
$(LIB_KFILE) \\
$(LIB_KDECORE)
--- amarok-1.4/configure.in.old 2006-02-09 14:29:22.000000000 -0600
+++ amarok-1.4/configure.in 2006-02-09 15:33:21.000000000 -0600
@@ -205,16 +205,16 @@
fi
fi
fi
-
### The gstreamer engine subdirectory equalizer/ uses
### gst/audio/audio.h, which is in gstreamer-plugins (at least for me)
-amarok_save_cppflags=\"$CPPFLAGS\"
-CPPFLAGS=\"$CPPFLAGS $CFLAGS_GST\"
-AC_CHECK_HEADER(gst/audio/audio.h,[],[have_gst=\"no\"])
-CPPFLAGS=\"$amarok_save_cppflags\"
+if test \"x$have_gst\" = \"xyes\"; then
+ amarok_save_cppflags=\"$CPPFLAGS\"
+ CPPFLAGS=\"$CPPFLAGS $CFLAGS_GST\"
+ AC_CHECK_HEADER(gst/audio/audio.h,[],[have_gst=\"no\"])
+ CPPFLAGS=\"$amarok_save_cppflags\"
+fi

AM_CONDITIONAL(with_gst, [test x$have_gst = xyes])
-
###############################################################################
# END GSTREAMER CHECK
###############################################################################
@@ -243,7 +243,7 @@
PKG_CHECK_MODULES(GST10, gstreamer-$GST10_MAJORMINOR >= $GST10_REQ,
have_gst10=yes,have_gst10=no)

- PKG_CHECK_MODULES(GST10_PLUGINS, gstreamer-plugins-$GST10_MAJORMINOR >= $GST10_REQ, \\
+ PKG_CHECK_MODULES(GST10_PLUGINS, gstreamer-plugins-base-$GST10_MAJORMINOR >= $GST10_REQ, \\
have_gst10_plugins=yes,have_gst10_plugins=no)

dnl Give error if we don\'t have gstreamer
@@ -263,10 +263,13 @@

### The gstreamer engine subdirectory equalizer/ uses
### gst/audio/audio.h, which is in gstreamer-plugins (at least for me)
+if test \"x$have_gst\" = \"xyes\"; then
amarok_save_cppflags=\"$CPPFLAGS\"
CPPFLAGS=\"$CPPFLAGS $CFLAGS_GST10\"
+echo \"$CPPFLAGS\"
AC_CHECK_HEADER(gst/audio/audio.h,[],[have_gst10=\"no\"])
CPPFLAGS=\"$amarok_save_cppflags\"
+fi

AM_CONDITIONAL(with_gst10, [test x$have_gst10 = xyes])

@@ -1105,7 +1108,7 @@
# BEGIN DO_NOT_COMPILE CHECK
###############################################################################

-if test x$have_kdemm != xyes -a x$have_gst != xyes -a x$build_nmm != xyes -a x$build_xine != xyes -a x$have_akode != xyes; then
+if test x$have_kdemm != xyes -a x$have_gst != xyes -a x$have_gst10 -a x$build_nmm != xyes -a x$build_xine != xyes -a x$have_akode != xyes; then

DO_NOT_COMPILE=\"$DO_NOT_COMPILE amarok\"
no_engine=yes
@@ -1314,7 +1317,7 @@

fi

-if test x$have_gst = xno; then
+if test x$have_gst = xno -a x$have_gst10 = xno; then
echo \" ==========================\"
echo \" === amaroK - WARNING ========================================================\"
echo \" ==========================\"
@@ -1341,6 +1344,19 @@
echo \" =\"
fi

+if test x$have_gst10_plugins = xno -a x$have_gst10 = xyes; then
+ echo \" ==========================\"
+ echo \" === amaroK - WARNING ========================================================\"
+ echo \" ==========================\"
+ echo \" =\"
+ echo \" = No GStreamer plugins were detected!\"
+ echo \" = Without plugins you will not be able to play any media using the\"
+ echo \" = GStreamer-engine! You need at least the MP3 plugin and a sink plugin, (eg.\"
+ echo \" = ALSAsink). Please refer to http://gstreamer.freedesktop.org/\"
+ echo \" = NOTE: you will still be able to play media with another engine plugin.\"
+ echo \" =\"
+fi
+
if test x$included_sqlite = xno; then
if test x$have_sqlite = xyes; then
echo \" ==========================\"
@@ -1431,10 +1447,14 @@
echo \" = - aKode-engine\"
fi

- if test x$have_gst != xyes; then
+ if test x$have_gst_plugins = xno -a x$have_gst = xyes; then
echo \" = - GStreamer-engine\"
fi

+ if test x$have_gst10_plugins = xno -a x$have_gst10 = xyes; then
+ echo \" = - GStreamer10-engine\"
+ fi
+
if test x$build_xine != xyes; then
echo \" = - xine-engine\"
fi
@@ -1503,7 +1523,11 @@
if test x$build_akode = xyes; then
echo \" = + aKode-engine\"
fi
-
+
+ if test x$have_gst10 = xyes; then
+ echo \" = + GStreamer10-engine\"
+ fi
+
if test x$have_gst = xyes; then
echo \" = + GStreamer-engine\"
fi
Sammy Umar
Registered Member
Posts
13
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Mon Feb 13, 2006 10:43 pm
It would not let me attach a patch so I just pasted it in!
Sammy Umar
Registered Member
Posts
13
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Tue Feb 14, 2006 11:50 pm
attaching zipped patch [file name=3b52d0d51f2409dc18003e35f97232b6. size=1621]http://amarok.kde.org/components/com_simpleboard/uploaded/files/3b52d0d51f2409dc18003e35f97232b6.[/file]
krassyo
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Wed Feb 15, 2006 5:03 am
I patched just like you suggested and not working yet :( It still does not find audio.h and the same old warning:

==========================
=== amaroK - WARNING ========================================================
==========================
=
= The optional GStreamer-engine will not be built. If you want to use the
= powerful GStreamer multimedia framework with amaroK, please download
= version 0.8.6 or higher from http://gstreamer.freedesktop.org/
= If you are sure GStreamer is already installed then there is most likely a
= problem with your pkg-config setup, see amarok/README
=

Any idea?
krassyo
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Wed Feb 15, 2006 5:46 am
Oh yeah! Excuse me, mate! It is working now.
Thanks a lot for the patch!
guest
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Wed Feb 15, 2006 2:20 pm
How to apply this patch ?
guest
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Sat Feb 18, 2006 10:36 pm
Please.. Can someone tell me how to apply this patch ?
sambo57u
Karma
0

Re:amarok-1.4b1 gstreamer prb/patch

Sun Feb 19, 2006 12:52 am
HI,

If the get the latest SVN they have fixed most of this except
the small part you can fix by hand. Just edit the file

amarok-1.4/amarok/src/engine/gst10/Makefile.am

by hand and change

(top_srcdir)/amarok/src/engine/gst/config
to
(top_srcdir)/amarok/src/engine/gst10/config

in two places.

If you don\'t know how to get the SVN you can apply the patch
by copying it into the main source directory and issuing the
command \"patch -p1 < NameofPatchFile\" then do an autoconf
and configure again. I really recommend getting the SVN source
though.


Bookmarks



Who is online

Registered users: Baidu [Spider], Bing [Bot], Google [Bot], Yahoo [Bot]