This forum has been archived. All content is frozen. Please use KDE Discuss instead.

folder.jpg not being detected in collection scan

Tags: None
(comma "," separated)
newblacknoise
Registered Member
Posts
2
Karma
0
i am having a problem, which has been neatly summarised in the subject of this post. however, allow me to elaborate:

having finished a nice fresh install of ubuntu 6.06, i downloaded amarok 1.4.2beta1 and compiled/installed it successfully first time (which was a first for me in itself!). i've got my music collection organised in the common // structure, with almost every album directory containing a 'folder.jpg' file for its cover art, which allows for convenient browsing when using windows xp. however, when scanning my mp3 collection upon starting amarok for the first time, none of the folder.jpg files seem to have been detected as cover art, as the only albums amarok has cover art for are those that happened to have the cover art embedded within each file (which is generally not what i want).

i've looked through all the options i can find in the program itself, as well as searching the forums, wiki, and FAQs, for any clue as to why this is happening. i have gathered from the forum posts that using a 'folder.jpg' as an album's cover art is a feature that has been implemented in amarok for quite some time now, so i'm quite clueless as to why this isn't working for me. of course, i AM able to manually 'set custom cover' for each individual album, but it's very time consuming with a large collection such as mine, and considering this feature is supposedly implemented already, it seems beside the point.

sorry for going on and on about it. any light which could be shed on this topic would be greatly appreciated.

thanks.
newblacknoise
Registered Member
Posts
2
Karma
0
well, after screwing around for a while longer, to no avail, i decided to install the latest stable version, 1.4.1, and hey presto, there are my cover images, all as they should be.

is this something worth reporting as a bug, or is it more likely to be a freakish anomalie?
User avatar
markey
KDE Developer
Posts
2286
Karma
3
OS
Yes, please make a bug report.


--
Mark Kretschmann - Amarok Developer
iain_benson
Registered Member
Posts
2
Karma
0
I think I've tracked it down.

CollectionDB::URLsFromQuery checks to see if the device id for the image is mounted

Code: Select all
if ( MountPointManager::instance()->isMounted( id ) )


When the files are on the local hard disk, the id will be -1. The MountPointManager class does not register -1 as being mounted.

The simplest solution is to add a check for -1 to the above test (there are 4 places in CollectionDB where this needs changing)

Code: Select all
if ( (if==-1) || MountPointManager::instance()->isMounted( id ) )


The better solution is to fix MountPointManager to registed -1 as mounted, but I haven't done that yet as I don't want to break it!

Last edited by iain_benson on Wed Aug 02, 2006 9:23 pm, edited 1 time in total.


Bookmarks



Who is online

Registered users: Bing [Bot], Google [Bot], Sogou [Bot]