Kryten2X4B wrote:I was thinking more along the lines of "It's possible to get the non-annoying behavhior today without patching the sources (which most people wouldn't know how to do - especially if they're using binary packages most of the time) or waiting for an update where the plain-text option may, or may not, be implemented".

Ignacio Serantes wrote:I don't know who write lastFM service but there is a bug with ignoreWallet configuration option.

This option is totally ignored because LastFmServiceConfig::LastFmServiceConfig() has incorrect logic.

The line

if( KWallet::Wallet::isEnabled() )

must be changed for

if( config.hasKey( "ignoreWallet" ) && ( config.readEntry( "ignoreWallet", QString() ) == "no" ) && KWallet::Wallet::isEnabled() )

or something similar. I include "config.hasKey( "ignoreWallet" )" because I don't know how to do a typecast in C.

With this change the line:

KConfigGroup config = KGlobal::config()->group( configSectionName() );

must be moved before the if.

Code: Select all

config.readEntry( "ignoreWallet", QVariant(false) ).toBool()

bcooksley wrote:It is completely safe to read a variable that does not exist, that is what the default value ( QString() in your case, or "" ). You may wish to use a boolean instead.

Code: Select all

config.readEntry( "ignoreWallet", QVariant(false) ).toBool()

Ignacio Serantes wrote:Any news about this?

I send the patch to the list two weeks ago but I don't know if patch was commited or not.

Kryten2X4B wrote:Actaully, you can make it non-annoying even without removing/disabling amarok's support/need for kwallet. Okay, it's annoying the first time but after that it's seamless.

What you do is create an additonal wallet within kwallet manager, and set it to be password-less. After that, you make sure amarok (and other apps where you think a plain-text password is secure enough) uses this insecure wallet rather than the one with a strong password. Additionally, as soon as amarok tries to use this insecure wallet you tell kwallet to "Allow always".

It's possible to do, although the UI of kwallet makes it harder to accomplish than what it needs to be. I always have to experiment a bit before I remember how to do it...

Ignacio Serantes wrote:I'm compiling Amarok so for me there is no problem and I'm not a C++ programmer so, I could miss something important.

If Leo is really busy and nobody is complain about the same problem I think that the best is wait for Leo to avoid solve a problem but create a new one.

It's a minor bug so there is no need to hurry up.

markey wrote:No, the problem is that Leo might forget about it entirely. Please make a "Merge Request" on Gitorious, that's the best way for us:
http://gitorious.org/amarok/amarok