This forum has been archived. All content is frozen. Please use KDE Discuss instead.

QMAX bug in 02/12 CVS snapshot

Tags: None
(comma "," separated)
MEF
Karma
0

QMAX bug in 02/12 CVS snapshot

Thu Dec 02, 2004 8:52 pm
Thanks for putting back the CVS snapshots! I\'m compiling right now...

There was one build failure; at line 51 of blockanalyzer.cpp, it does this:

[code:1]m_rows = QMAX( uint(double(height()+1) / (HEIGHT+1)), MIN_ROWS );[/code:1]

For me (gcc-3.2.2 Red Hat, KDE 3.3.1), I get a parse error on this line; probably because QMAX is defined as a macro and is expanding its arguments badly? (I don\'t claim to know a great deal about C++).

Changing that line to the following two let me compile the new amaroK.

[code:1]m_rows = uint(double(height()+1) / (HEIGHT+1));
if(MIN_ROWS > m_rows) m_rows = MIN_ROWS;[/code:1]

The compile just finished; time to test it out and see if the cover manager is better behaved now. :)

MEF
User avatar
markey
KDE Developer
Posts
2286
Karma
3
OS

Re:QMAX bug in 02/12 CVS snapshot

Thu Dec 02, 2004 9:38 pm
Thanks for noting, fixed now.


--
Mark Kretschmann - Amarok Developer


Bookmarks



Who is online

Registered users: Bing [Bot], gfielding, Google [Bot], markhm, Sogou [Bot], Yahoo [Bot]