This forum has been archived. All content is frozen. Please use KDE Discuss instead.

last.fm updates -- Scrobbler::engineNewMetaData()

Tags: None
(comma "," separated)
Matt Zukowski
Karma
0
I have a couple of long mp3\'s (compliation mixes) with .cue files. I was pleasantly surprised to find that amaroK looks in these cue files, and appropriately pulls the correct artist/track name based on the .cue\'s time signatrues (whoever did this, nice job!)

However, I found that for some reason amarok wasn\'t submitting these track names to last.fm. So I had a look in scrobbler.cpp and found this:

[code:1]
if ( !trackChanged )
{
// Tags were changed, update them if not yet submitted.
// TODO: In this case submit could be enabled if the artist or title
// tag was missing initially and disabled submit
debug() << \"It\'s still the same track, but metadata has changed so I will submit.\" << endl;
if ( m_item )
{
m_item->setArtist( bundle.artist() );
m_item->setAlbum( bundle.album() );
m_item->setTitle( bundle.title() );
}
return;
}
[/code:1]

Basically it looks like the feature to make this work is already there, but it\'s turned off for some reason. Commenting out the return statement at the end made it work exactly like it should -- it now submits the metadata to last.fm whenever the track info is updated.

Just curious why is this function is disabled? Only reason I can think of is to prevent abuse (i.e. someone sitting there and changing the track name constantly)... but really if someone\'s persistent about screwing with last.fm, there\'s better ways to do it.

Can someone just take out that return statement? k thanx bye


Bookmarks



Who is online

Registered users: bancha, Bing [Bot], daret, Evergrowing, Google [Bot], lockheed, sandyvee, Sogou [Bot]