This forum has been archived. All content is frozen. Please use KDE Discuss instead.

New applet in merge requests

Tags: None
(comma "," separated)
Manuw2009
Registered Member
Posts
65
Karma
0
OS

New applet in merge requests

Fri Mar 11, 2011 9:49 pm
Hi guys,

Just to let you know that I submitted a merge request with a new basic applet, enabling to display all albums of the collection in a cover grid view.
https://git.reviewboard.kde.org/r/100841/
comments welcome !
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Mon Mar 28, 2011 7:10 am
Comments anyone ?
valoriez
KDE CWG
Posts
625
Karma
3
OS

Re: New applet in merge requests

Mon Mar 28, 2011 7:23 am
I like it; it's very attractive. What exactly does it DO?
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Mon Mar 28, 2011 8:52 am
Thanx !

Well, it's just another way to browse the collection.
Only implemented double-click by now, which appends the album to playlist, but I guess we could implement all "classical" functionalities from the album tree right click menu , although, as an applet IMHO it should remain simple/basic.
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Tue Jul 12, 2011 5:55 pm
bump...
User avatar
kfunk
KDE Developer
Posts
53
Karma
0
OS

Re: New applet in merge requests

Tue Jul 12, 2011 6:10 pm
Hey, manuw2009.

We're just about to release v2.4.2. We'll have a look at your patch for the next release. It's still needs some minor polishing. (As stated on the merge request).

Still, many thanks for your contribution. You're welcome!
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Thu Aug 18, 2011 7:43 am
hi,

Could anyone help on this topic ?
I think the missing cover problem as stated in the merge request is only a matter of delivering the image file in the merge request diff.
it works quite well at my end ???
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Wed Aug 24, 2011 11:27 am
Bump...
OK, here is my proposal :
please integrate this to playground for testing purpose
User avatar
google01103
Manager
Posts
6668
Karma
25

Re: New applet in merge requests

Sat Aug 27, 2011 6:03 pm
with large collections it would be helpful to be able to filter using album or artist - something akin to that found in the cover tool

grouping might be interesting also - example: years where a line break and the year differentiate demarcate the years


OpenSuse Leap 42.1 x64, Plasma 5.x

Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Sun Mar 25, 2012 12:39 pm
Hi,

It's been a while...
Can't believe this has never been released...
I have been using this ever since at my end
User avatar
Mamarok
Manager
Posts
6071
Karma
16
OS

Re: New applet in merge requests

Sun Mar 25, 2012 1:48 pm
Manu, the code is in playground since quite some time. Also, as the reviewboard indicates this still needs some polishing to be pushed to master.


Running Kubuntu 22.10 with Plasma 5.26.3, Frameworks 5.100.0, Qt 5.15.6, kernel 5.19.0-23 on Ryzen 5 4600H, AMD Renoir, X11
FWIW: it's always useful to state the exact Plasma version (+ distribution) when asking questions, makes it easier to help ...
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Wed Mar 28, 2012 6:19 am
Hi,

Yes, it is in playground, but I think the main issue was that my original submitted merge was missing some resource files which prevented covers from appearing.
Could anybody test the playground version and update their views ?
It's working fine at my end (I am using both coverbling & covergrind compiled from playground, 2.5 version)
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Sun Jun 02, 2013 5:48 pm
Hi,
It's been more than 2 years.
And I have been using the applets (both coverflow & covergrid from playground) with no issue at all.
Isn't anybody willing to move them to amarok ? :'(
I haven't heard from or seen any potential replacement since then ("graphic" view of all albums in collection)...
User avatar
strohel
KDE Developer
Posts
54
Karma
0
OS

Re: New applet in merge requests

Sun Jun 02, 2013 8:44 pm
Hi, it seems that the covergrid applet was somehow forgotten in playground, sorry about that.

I have some comments and suggestions for behaviour of the applet (+ I haven't studied the code yet), review board would be a better place to discuss these, plus it is *the* place to gather opinions from other developers. Would you mind reposting it there (the updated version, perhaps the one from playground, targetted at current Amarok git master)?
Manuw2009
Registered Member
Posts
65
Karma
0
OS

Re: New applet in merge requests

Mon Jun 17, 2013 2:45 pm
Hi,

Sorry but it's been a while and I have forgotten how that works (submitting merge requests was a pain if I remember properly)
My view is that I was building straight from git both applets playground versions
as here :
https://launchpad.net/~manu-wagner/+archive/ppa-amarok-experimental


Bookmarks



Who is online

Registered users: Bing [Bot], Evergrowing, Google [Bot], Sogou [Bot]