This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Lyrics

Tags: None
(comma "," separated)
xatax
Registered Member
Posts
49
Karma
0

Re:Lyrics

Tue Apr 05, 2005 10:03 pm
as it will take some time, to have id3v2 lyrics support into taglib, and probably even longer for lyrics2 / lyrics3 support, i think we might actualy implement it ourselves. (this is not a promise(mental note: might be harder than you think))
Scott M. Likens
Registered Member
Posts
23
Karma
0

Re:Lyrics

Wed Apr 06, 2005 1:41 am
xatax wrote:
as it will take some time, to have id3v2 lyrics support into taglib, and probably even longer for lyrics2 / lyrics3 support, i think we might actualy implement it ourselves. (this is not a promise(mental note: might be harder than you think))


I don\'t know if the devs are willing to jump the \'fence\' for lyrics2/lyrics3 let alone lyrics in taglib not existing.

The easiest thing to do would be to submit a patch to taglib to make it supported, then throw it into amarok after some time.

Otherwise a filesystem check for lyrics.txt would be the most sane method, problem is that puts the user in copyright limbo, and that puts the developers as corporate US America wants to put developers in jail for writing bad software, that could put a few developers in limbo also.

Which is most likely why it\'s not implemented.

TADA
User avatar
eean
KDE Developer
Posts
1016
Karma
0
OS

Re:Lyrics

Wed Apr 06, 2005 1:46 am
A filesystem check for lyrics.txt clearly wouldn\'t work since people have more the one file in the same directory. I don\'t see why it would have any legal problems beyond whats already there.

In regards to patching taglib, I believe thats xatax\'s plan.


Amarok Developer
xatax
Registered Member
Posts
49
Karma
0

Re:Lyrics

Wed Apr 06, 2005 2:00 am
Yup,
i made a patch, but Scott Wheeler denied to commit it straight because:

New virtual methods can\'t be added to classes in binary compatible releases (i.e. 1.4)

Also since those two classes are almost identical I\'ll probably just write a common base class so that the code isn\'t duplicated all over the place.

He did said he will try to provide a support for lyrics tag by TagLib 1.4 release.

But, after talking with him some other new ideas poped into my mind. Implementing lyrics3 support & id3v2 lyrics tag support straight into amaroK. But this needs some thinking first.


Bookmarks



Who is online

Registered users: Bing [Bot], gfielding, Google [Bot], Sogou [Bot]