This forum has been archived. All content is frozen. Please use KDE Discuss instead.

different brush size setting when in eraser mode

Tags: None
(comma "," separated)
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
I know this has came up before in other posts.

Currently, the brush size uses the same size whether you are painting or erasing. This makes erasing line work (and probably other things) difficult since you have to constantly be changing brush sizes. Having a different brush size for normal and eraser would be a nice fix.

Does anyone else think this would be helpful? I actually already coded up a simple patch that I think works pretty well. I don't want to add this if no one else would find this useful.

thoughts?
User avatar
Artmessiah
Registered Member
Posts
143
Karma
0
OS
I would find this very useful. It is a pain to constantly resize the eraser when drawing.


slangkamp
KDE Developer
Posts
607
Karma
4
Size is just one aspect of the eraser, maybe someone wants to have a completely different eraser. So it should be solved in a more general fashion. I think this could be combined with the binding presets to shortcuts which was discussed here: viewtopic.php?f=139&t=123325 and I also posted about it on the mailinglist http://mail.kde.org/pipermail/kimagesho ... 12430.html
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
@slangkamp: I read through the mailing list post and the forum post.

I see one use case out of this forum post.

My issue is that I ink with a small brush, but I always erase with a large one

I need to be able to switch between them and my other brushes quickly.


The first statement is a use case for a workflow problem. It is very specific to the size of the brush/eraser. The second statement is an implied solution to get around the problem. Everything that follows seems to be workarounds and hacks for fixing the original use case.

in the real world, an eraser is a completely different tool than a brush. This is not the case in Krita though. The eraser tool and the brush are the same - only changing the blending mode of the current brush (as far as I know). This is a technically simple solution to erasing, not a natural or intuitive one.

I think a better long term solution would be to separate the "erase mode" from the brush mode. Their needs to be a dedicated eraser tool. The eraser tool should give you an option to select what type of eraser you want. You can select the brush size and properties just like you do a normal brush.

That would be the direction I would go for a long term solution. For a short term fix to alleviate this problem, I would make the brush size use a different value when in "erase mode". I don't know if you do much painting, but this is a very annoying issue when doing any type of line work. If it is going to be a while before any type of large re-write, short term solutions really help people get by. Otherwise, this will continue to be a pain point with no solution at all.
ramskulls
Registered Member
Posts
134
Karma
2
I sorely need this, but I also love Krita's ability to turn any brush into an eraser quickly.

Is ir possible to be able to 'lock' a preset's properties in such a way that flipping to eraser mode and back will reset to the original setting? :-\
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
The way the patch I made works is that that pressing "erase mode" button will reference a different value for the brush size. There is an eraser mode brush size and a normal brush size. Everything else works the same.
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS
@scottpetrovic: it would be best to first check whether this isn't already solved in Mohit's Google Summer of Code work. He should be merging his work to master pretty soon, and then we can check whether the issue is already solved. If not, it sounds like a good idea.
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
@boudewjin - thanks. I didn't realize he was touching this so much. I looked at his patch and it doesn't appear he changed the eraser brush size. He did change a lot of code, though, so I don't think I would touch that file until his changes are merged in. We'll see what happens!
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
I checked out Mohit's commit and it doesn't look iike it includes the worfklow enhancement for a separate eraser size. This improvement is difficult to explain in words...so..

I made a short a youtube video!
https://www.youtube.com/watch?v=z6gzb5W ... e=youtu.be

Like I state in the description, you can assume that every time I have to erase, I have to change the brush size *twice*. Once to make the brush size larger to erase a bigger area. Another brush size change to shrink it back down to continue sketching.

By adding a separate variable for the eraser, this will almost eliminate all of the brush resizing work entirely! I will always have the sketch size, and will always have the eraser size. Pressing the E key is all I will need to do.

This changes the workflow of erasing from

1. toggle the eraser mode
2. change the brush size to be bigger
3. erase
4. toggle the eraser mode back
5. shrink the brush size

to

1. toggle to eraser mode
2. erase
3. toggle the eraser mode back
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS
If we make the E switch not just toggle the erase mode/blending mode, but also swap the size, it should be a pretty easy patch, and I'm not at all opposed to it going in :-)
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
nice. I submitted a patch along the line with what I was thinking. For the code, the values of the brush size seem to really only be referenced in the resource manager and UI directly. Updating the values like the diff seemed to be the cleanest and simplest way to change them.

https://git.reviewboard.kde.org/r/120681/diff/#
ramskulls
Registered Member
Posts
134
Karma
2
Nice. :_) will this patch be included in the new build coming out soon? Kinda excited to work on krita again now... ^^ after exams of course
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
@ramskulls - I just committed the change to the source code, so it will be available whenever you see a build that was done after October 21.
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS
There's one now for Win64, OSX and hopefully also Krita Lime. I'll do the official announcement tomorrow, but check files.kde.org for the latest Win/OSX builds and Line for Ubuntu.

There's of course also a ton of other stuff -- all your tool config patches, cage transform, liquify and broken psd loading :-)
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS
@boudewijn - dang! you're so fast.


Bookmarks



Who is online

Registered users: bancha, Bing [Bot], Evergrowing, Google [Bot], lockheed, mesutakcan