This forum has been archived. All content is frozen. Please use KDE Discuss instead.
The Discussions and Opinions forum is a place for open discussion regarding everything related to KDE, within the boundaries of KDE Code of Conduct. If you have a question or need a solution for a KDE problem, please post in the apppropriate forum instead.

Bug 205157 - two clicks on file to rename

Tags: None
(comma "," separated)
funkybomber
Registered Member
Posts
7
Karma
0
Hello,

It would be nice if this feature/bugfix could be implemented for Plasma 5.8
It has been requested in past KDE versions by many users here in the forums:

viewtopic.php?f=224&t=108832&p=254539&hilit=double+click+to+rename#p254539
viewtopic.php?f=83&t=117522&p=292413&hilit=double+click+to+rename#p292413
viewtopic.php?f=223&t=130078&p=347718&hilit=double+click+to+rename#p347718


Also it's in the KDE bugtracking system and currently has a "CONFIRMED" status:

https://bugs.kde.org/show_bug.cgi?id=205157#c10


I'm ready to put my money where my mouth is and I'm willing to do a one-off $200 donation to the KDE Plasma 5 project IF this solution finally gets implemented on Plasma 5.8 (preferably as an option off-by-default so that other user work flows are not disrupted).

Please let me know what you think.


EDIT (15/12/2017) :
My reward for the bugfix has been submitted as promised ($200 ~> €170). I never thought I'd see the day! Congratulations to everyone involved! ;D
https://www.kde.org/community/donations ... ations.php

Last edited by funkybomber on Fri Dec 15, 2017 11:16 am, edited 1 time in total.
User avatar
Rog131
Registered Member
Posts
828
Karma
10
My thoughts...

KDE releases

In the past the KDE was released under the single label (...KDE3, KDE4). Now the KDE is releasing as separate items the KDE Frameworks 5 (KF5). Plasma 5 and the KDE Applications. KDE Schedules: https://community.kde.org/Schedules


Bug report

Bug 205157 - two clicks on file to rename: https://bugs.kde.org/show_bug.cgi?id=205157 is filed agains the Dolphin. It is a wish and it's status is confirmed: https://bugs.kde.org/page.cgi?id=fields.html#status
CONFIRMED

This bug is valid and has recently been filed. Bugs in this state become IN_PROGRESS when somebody is working on them, or become resolved and marked RESOLVED.



Dolphin

The Dolphin is released with the KDE Applications. Next release is the 16.08:
Thursday, August 18, 2016: KDE Applications 16.08 Release


There is a patch - https://bugs.kde.org/show_bug.cgi?id=205157#c11 to enable the "Fast renaming". Seems to work at here.
Image
At here:
Dolphin 16.04.3
KF5 5.24.0
Qt 5.7.0


To get the patch to the Dolphin you could file a review request: https://community.kde.org/Infrastructure/Review_Board .Open review requests for Dolphin: https://git.reviewboard.kde.org/groups/ ... w-closed=0 .But the fastest way is to apply the patch to your own Dolphin.
funkybomber
Registered Member
Posts
7
Karma
0
Hi Rog131, thanks for taking time to explain the KDE release schedules to me.

This whole deal with the patch "https://bugs.kde.org/show_bug.cgi?id=205157#c11" just raises some more questions for me:
Why didn't the user andreas.krutzler (who created the patch) just submit it to the Review Board?

I can't get my head around on how there can be a solution for a confirmed bug just laying around and not getting picked up/or being sent to the Review Board.

If THAT is not part of the standard bug fixing procedure, then how is the bug 205157 (or any other listed KDE bug for that matter) supposed to get a RESOLVED status at some point?

It seems to me that this (not pushing patches to the review board) can only lead to bugs getting piled up in the KDE bugtracking system, while in reality the solutions sit just right there!

Just another clarification, please. Am I allowed to do a request for this patch to the review board even though I'm not the author? For all I know this patch might not work or it could even break a stable system (I don't know how to apply patches to test this, sorry). Isn't it reasonable that only the author (or someone with a know-how of the code) should push it to the review board?

Thanks for bearing up with me! I truly struggle to understand the logic behind how this whole thing works.
User avatar
Rog131
Registered Member
Posts
828
Karma
10
KDE review board - Review Request #128715: https://git.reviewboard.kde.org/r/128715/
funkybomber
Registered Member
Posts
7
Karma
0
Rog131 wrote:KDE review board - Review Request #128715: https://git.reviewboard.kde.org/r/128715/


Yeah, I contacted the patch author right around the time of my previous forum post so that he would submit his patch to the review board. Apparently he was surprised as much as I was at the extra step for the bug to be resolved. Too bureaucratic.

Anyway, it's good that the review board is having a look at it, but the first replies/comments are somewhat disheartening. They are trying to figure out a way to implement it without adding an extra option. :|
And apparently they are also looking for it to be enabled by default when both 'single click' and 'inline renaming' are enabled. But this makes zero sense. This was only supposed to be relevant with the 'double click' option enabled. As the title says: "two clicks on file to rename". In a 'single click' environment the file just opens/executes with the first click.

It feels like they are trying to give a solution to a different problem than the one at hand... Complicating things for the sake of complicating things. :|


Bookmarks



Who is online

Registered users: Bing [Bot], claydoh, Google [Bot], rblackwell, Yahoo [Bot]