This forum has been archived. All content is frozen. Please use KDE Discuss instead.
The Discussions and Opinions forum is a place for open discussion regarding everything related to KDE, within the boundaries of KDE Code of Conduct. If you have a question or need a solution for a KDE problem, please post in the apppropriate forum instead.

How Aaron Seigo was breaking down Kicker

Tags: None
(comma "," separated)
Anixx
Registered Member
Posts
103
Karma
-1
OS
This is http://websvn.kde.org/?view=revision&revision=406411 a personal commit by Aaron Seigo after which the buttons on the taskbar in KDE 3.4 ceased to be visually pushed, when using the Classic mode.

The key line in file kicker/taskbar/taskcontainer.cpp before:

Code: Select all
style().drawPrimitive(QStyle::PE_HeaderSection, p, QRect(0, 0, width(), height()), colors, sunken ? QStyle::Style_Down : QStyle::Style_Raised);

after:

Code: Select all
style().drawPrimitive(QStyle::PE_HeaderSection, p, QRect(0, 0, width(), height()), colors)


After reverting this change and restoring the removed parameter to the function the taskbar works well again. I am currently testing the patch to submit it into Trinity.

I always suspected that Aaron introduced bugs in the latest releases of KDE3 because many bugs were introduced exactly in the most recent releases, including this bug which was very annoying. Now we have the proof. Probably nobody dared to revert him because he was the project leader.
DaSheep
Registered Member
Posts
95
Karma
1
OS
Well he states clearly that he was not really happy with the result and that more work was needed...

Lots of developers work really hard to make a good product, sure sometimes they make mistakes or bad decisions but to call that 'breaking down' is just downright paranoid.

If you think reverting the patch will improve trinnity, great! But please don't attack personal members of the community, nobody benefits from that.
User avatar
Moult
Global Moderator
Posts
663
Karma
2
OS
Have you tried talking to him? That might give you a new perspective.


Moult, proud to be a member of KDE forums since 2008-Oct.
thinkMoult - source for tech, art, and animation: hilarity and interest ensured!
WIPUP.org - a unique system to share, critique and track your works-in-progress projects.


Bookmarks



Who is online

Registered users: Bing [Bot], Google [Bot], Yahoo [Bot]