Hi,

Does anyone know if we should expect the new baloo search to work in file comments yet?

Code: Select all

% echo TestContents > TestFile

% attr -s xdg.comment -V TestComment TestFile     
Attribute "xdg.comment" set to a 11 byte value for TestFile:
TestComment

% balooshow TestFile
79038 /home/dave/TestFile
        Word Count: 1
        Line Count: 1
        User Comment: TestComment

% baloosearch TestComment


% baloosearch TestContents

  79038 /home/dave/TestFile


Thanks!

Uhh, yeah. I didn't bother implementing that. It's not included in the "global" search. You can still explicitly search through the comments and that will work. It just so happens that I don't think there is any user visible way to tell Baloo to search through the comments. Oops.

The main reason I didn't add it was cause users mostly lack the context as to why a file is appearing on the search results, specially through "krunner" or any other search interface. Even in Dolphin, the comment is not visible by default. It seemed better to only search through the comment when explicitly asked to.

In 4.14, we plan to ship a new query interface. This should help your use case.

Hi Vishesh,

vHanda wrote:Uhh, yeah. I didn't bother implementing that.

Fair enough! Thanks for the quick reply. I thought this might be the case - I took a quick look at the code, and although I could see comments being added to the database, I couldn't see anything to pull them back out again.

vHanda wrote:It's not included in the "global" search. You can still explicitly search through the comments and that will work.

By explicitly, do you mean programmatically? Or how?

vHanda wrote:The main reason I didn't add it was cause users mostly lack the context as to why a file is appearing on the search results, specially through "krunner" or any other search interface. Even in Dolphin, the comment is not visible by default. It seemed better to only search through the comment when explicitly asked to.

Yes, I can see the point of view. Only searching comments when asked to doesn't seem unreasonable.

vHanda wrote:In 4.14, we plan to ship a new query interface. This should help your use case.

Okay, that's good news. I definitely have a set of files to which I added comments by way of meta data specifically because I could then run searches against that data. It actually worked pretty nicely. You see, you give us features, and we devise uses for them!

Anyway, good luck with the new search infrastructure. Indexing seems much quicker.

Yes. By explicitly, I mean the feature is available in the code, just not exposed.