Hello,

Since QWebKit is being deprecated, I was wondering how stable Skrooge is when building it against QWebEngine.

Currently it seems that I can't even compile it:

Code: Select all

Scanning dependencies of target skg_monthly
[ 63%] Building CXX object plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/skgmonthlyplugin.cpp.o
[ 63%] Building CXX object plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/skgmonthlypluginwidget.cpp.o
In file included from /tmp/nix-build-skrooge-2.10.5.drv-0/skrooge-2.10.5/plugins/generic/skg_monthly/skgmonthlypluginwidget.h:24:0,
                 from /tmp/nix-build-skrooge-2.10.5.drv-0/skrooge-2.10.5/plugins/generic/skg_monthly/skgmonthlyplugin.cpp:38:
/tmp/nix-build-skrooge-2.10.5.drv-0/skrooge-2.10.5/build/plugins/generic/skg_monthly/ui_skgmonthlypluginwidget_base.h:15:36: fatal error: QtWebKitWidgets/QWebView: No such file or directory
 #include <QtWebKitWidgets/QWebView>
                                    ^
compilation terminated.
[ 63%] Building CXX object plugins/generic/skg_undoredo/CMakeFiles/skg_undoredo.dir/skgundoredo_settings.cpp.o
make[2]: *** [plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/build.make:67: plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/skgmonthlyplugin.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /tmp/nix-build-skrooge-2.10.5.drv-0/skrooge-2.10.5/plugins/generic/skg_monthly/skgmonthlypluginwidget.h:24:0,
                 from /tmp/nix-build-skrooge-2.10.5.drv-0/skrooge-2.10.5/plugins/generic/skg_monthly/skgmonthlypluginwidget.cpp:22:
/tmp/nix-build-skrooge-2.10.5.drv-0/skrooge-2.10.5/build/plugins/generic/skg_monthly/ui_skgmonthlypluginwidget_base.h:15:36: fatal error: QtWebKitWidgets/QWebView: No such file or directory
 #include <QtWebKitWidgets/QWebView>
                                    ^
compilation terminated.
make[2]: *** [plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/build.make:91: plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/skgmonthlypluginwidget.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2122: plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....


Hi,

In the README, you can see that you need to use -DSKG_WEBENGINE=ON to enable the build with QWebEngine instead of QWebKit.
Something like:

Code: Select all

cmake .. -DCMAKE_INSTALL_PREFIX=`kf5-config --prefix` -DQT_PLUGIN_INSTALL_DIR=`kf5-config --qt-plugins` -DCMAKE_BUILD_TYPE=release [b]-DSKG_WEBENGINE=ON[/b]

The migration is still ongoing, so do not hesitate to open bugs if you find some issues.
Regards.

Hello,

Many thanks for your reply, I was using the proper CMake flag (-DSKG_WEBENGINE=ON), the compilation error I am reporting is with this one. Should I post this elsewhere?

Hi,
I did a correction to avoid this error. Could you try to build the last git version?
Regards.

Sorry for not contacting earlier,

I have tried building with QWebEngine revision 8096030c22afef782115f78a074ec75490f7c0db, but it still fails:

Code: Select all

[ 59%] Building CXX object plugins/generic/skg_dashboard/CMakeFiles/skg_dashboard.dir/skgdashboard_settings.cpp.o
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_bookmark/skgbookmark_settings.cpp: In function '{anonymous}::Q_QGS_s_globalskgbookmark_settings::Type* {anonymous}::Q_QGS_s_globalskgbookmark_settings::innerFunction()':
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_bookmark/skgbookmark_settings.cpp:12:5: warning: but 'skgbookmark_settingsHelper::skgbookmark_settingsHelper()' does not throw; perhaps it should be declared 'noexcept' [-Wnoexcept]
     skgbookmark_settingsHelper() : q(nullptr) {}
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
[ 59%] Building CXX object plugins/generic/skg_bookmark/CMakeFiles/skg_bookmark.dir/skg_bookmark_autogen/mocs_compilation.cpp.o
[ 59%] Built target skg_advice
[ 60%] Building CXX object plugins/generic/skg_dashboard/CMakeFiles/skg_dashboard.dir/skg_dashboard_autogen/mocs_compilation.cpp.o
[ 60%] Built target skgbankgui
[ 60%] Generating ui_skgdebugpluginwidget_base.h
Scanning dependencies of target skg_debug
[ 60%] Building CXX object plugins/generic/skg_debug/CMakeFiles/skg_debug.dir/skgdebugplugin.cpp.o
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_dashboard/skgdashboard_settings.cpp: In function '{anonymous}::Q_QGS_s_globalskgdashboard_settings::Type* {anonymous}::Q_QGS_s_globalskgdashboard_settings::innerFunction()':
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_dashboard/skgdashboard_settings.cpp:12:5: warning: but 'skgdashboard_settingsHelper::skgdashboard_settingsHelper()' does not throw; perhaps it should be declared 'noexcept' [-Wnoexcept]
     skgdashboard_settingsHelper() : q(nullptr) {}
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 60%] Linking CXX shared module ../../../lib/skg_bookmark.so
[ 60%] Linking CXX shared module ../../../lib/skg_dashboard.so
Scanning dependencies of target skg_delete
[ 60%] Building CXX object plugins/generic/skg_delete/CMakeFiles/skg_delete.dir/skgdeleteplugin.cpp.o
[ 60%] Building CXX object plugins/generic/skg_debug/CMakeFiles/skg_debug.dir/skgdebugpluginwidget.cpp.o
[ 60%] Built target skg_bookmark
[ 60%] Building CXX object plugins/generic/skg_debug/CMakeFiles/skg_debug.dir/skg_debug_autogen/mocs_compilation.cpp.o
[ 60%] Built target skg_dashboard
[ 60%] Building CXX object plugins/generic/skg_delete/CMakeFiles/skg_delete.dir/skg_delete_autogen/mocs_compilation.cpp.o
[ 61%] Generating skgfile_settings.h, skgfile_settings.cpp
[ 61%] Generating ui_skgfilepluginwidget_pref.h
[ 61%] Linking CXX shared module ../../../lib/skg_delete.so
Scanning dependencies of target skg_highlight
[ 61%] Building CXX object plugins/generic/skg_highlight/CMakeFiles/skg_highlight.dir/skghighlightplugin.cpp.o
Scanning dependencies of target skg_file
[ 61%] Building CXX object plugins/generic/skg_file/CMakeFiles/skg_file.dir/skgfileplugin.cpp.o
[ 62%] Linking CXX shared module ../../../lib/skg_debug.so
[ 62%] Built target skg_delete
[ 63%] Building CXX object plugins/generic/skg_highlight/CMakeFiles/skg_highlight.dir/skg_highlight_autogen/mocs_compilation.cpp.o
[ 63%] Built target skg_debug
[ 63%] Generating skgprint_settings.h, skgprint_settings.cpp
[ 63%] Generating ui_skgprintpluginwidget_pref.h
Scanning dependencies of target skg_print
[ 63%] Building CXX object plugins/generic/skg_print/CMakeFiles/skg_print.dir/skgprintplugin.cpp.o
[ 63%] Building CXX object plugins/generic/skg_print/CMakeFiles/skg_print.dir/skgprint_settings.cpp.o
[ 63%] Linking CXX shared module ../../../lib/skg_highlight.so
[ 63%] Building CXX object plugins/generic/skg_file/CMakeFiles/skg_file.dir/skgfile_settings.cpp.o
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_print/skgprint_settings.cpp: In function '{anonymous}::Q_QGS_s_globalskgprint_settings::Type* {anonymous}::Q_QGS_s_globalskgprint_settings::innerFunction()':
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_print/skgprint_settings.cpp:12:5: warning: but 'skgprint_settingsHelper::skgprint_settingsHelper()' does not throw; perhaps it should be declared 'noexcept' [-Wnoexcept]
     skgprint_settingsHelper() : q(nullptr) {}
     ^~~~~~~~~~~~~~~~~~~~~~~
[ 63%] Building CXX object plugins/generic/skg_file/CMakeFiles/skg_file.dir/skg_file_autogen/mocs_compilation.cpp.o
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_file/skgfile_settings.cpp: In function '{anonymous}::Q_QGS_s_globalskgfile_settings::Type* {anonymous}::Q_QGS_s_globalskgfile_settings::innerFunction()':
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_file/skgfile_settings.cpp:12:5: warning: but 'skgfile_settingsHelper::skgfile_settingsHelper()' does not throw; perhaps it should be declared 'noexcept' [-Wnoexcept]
     skgfile_settingsHelper() : q(nullptr) {}
     ^~~~~~~~~~~~~~~~~~~~~~
[ 63%] Built target skg_highlight
[ 63%] Building CXX object plugins/generic/skg_print/CMakeFiles/skg_print.dir/skg_print_autogen/mocs_compilation.cpp.o
[ 63%] Generating ui_skgpropertiesplugindockwidget_base.h
Scanning dependencies of target skg_selectall
[ 63%] Building CXX object plugins/generic/skg_selectall/CMakeFiles/skg_selectall.dir/skgselectallplugin.cpp.o
Scanning dependencies of target skg_properties
[ 63%] Building CXX object plugins/generic/skg_properties/CMakeFiles/skg_properties.dir/skgpropertiesplugin.cpp.o
[ 63%] Linking CXX shared module ../../../lib/skg_file.so
[ 64%] Linking CXX shared module ../../../lib/skg_print.so
[ 64%] Building CXX object plugins/generic/skg_selectall/CMakeFiles/skg_selectall.dir/skg_selectall_autogen/mocs_compilation.cpp.o
[ 64%] Built target skg_file
[ 64%] Generating skgundoredo_settings.h, skgundoredo_settings.cpp
[ 64%] Generating ui_skgundoredoplugindockwidget_base.h
[ 64%] Generating ui_skgundoredopluginwidget_pref.h
Scanning dependencies of target skg_undoredo
[ 64%] Building CXX object plugins/generic/skg_undoredo/CMakeFiles/skg_undoredo.dir/skgundoredoplugin.cpp.o
[ 64%] Building CXX object plugins/generic/skg_properties/CMakeFiles/skg_properties.dir/skgpropertiesplugindockwidget.cpp.o
[ 64%] Built target skg_print
[ 64%] Building CXX object plugins/generic/skg_undoredo/CMakeFiles/skg_undoredo.dir/skgundoredoplugindockwidget.cpp.o
[ 64%] Linking CXX shared module ../../../lib/skg_selectall.so
[ 64%] Building CXX object plugins/generic/skg_properties/CMakeFiles/skg_properties.dir/skg_properties_autogen/mocs_compilation.cpp.o
[ 64%] Built target skg_selectall
[ 64%] Building CXX object plugins/generic/skg_undoredo/CMakeFiles/skg_undoredo.dir/skgundoredo_settings.cpp.o
[ 64%] Generating ui_skgmonthlypluginwidget_base.h
Scanning dependencies of target skg_monthly
[ 64%] Building CXX object plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/skgmonthlyplugin.cpp.o
In file included from /tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/plugins/generic/skg_monthly/skgmonthlypluginwidget.h:24:0,
                 from /tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/plugins/generic/skg_monthly/skgmonthlyplugin.cpp:37:
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_monthly/ui_skgmonthlypluginwidget_base.h:15:36: fatal error: QtWebKitWidgets/QWebView: No such file or directory
 #include <QtWebKitWidgets/QWebView>
                                    ^
compilation terminated.
make[2]: *** [plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/build.make:67: plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/skgmonthlyplugin.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2016: plugins/generic/skg_monthly/CMakeFiles/skg_monthly.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 65%] Building CXX object plugins/generic/skg_undoredo/CMakeFiles/skg_undoredo.dir/skg_undoredo_autogen/mocs_compilation.cpp.o
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_undoredo/skgundoredo_settings.cpp: In function '{anonymous}::Q_QGS_s_globalskgundoredo_settings::Type* {anonymous}::Q_QGS_s_globalskgundoredo_settings::innerFunction()':
/tmp/nix-build-skrooge-next.drv-0/skrooge-8096030/build/plugins/generic/skg_undoredo/skgundoredo_settings.cpp:12:5: warning: but 'skgundoredo_settingsHelper::skgundoredo_settingsHelper()' does not throw; perhaps it should be declared 'noexcept' [-Wnoexcept]
     skgundoredo_settingsHelper() : q(nullptr) {}
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
[ 65%] Linking CXX shared module ../../../lib/skg_properties.so
[ 65%] Linking CXX shared module ../../../lib/skg_undoredo.so
[ 65%] Built target skg_properties
[ 65%] Built target skg_undoredo
make: *** [Makefile:130: all] Error 2
builder for ‘/nix/store/bzlaspxa81gmdm0v70x55mi1l9asidaf-skrooge-next.drv’ failed with exit code 2
error: build of ‘/nix/store/bzlaspxa81gmdm0v70x55mi1l9asidaf-skrooge-next.drv’ failed


If I understood well, the problem is on this line: https://cgit.kde.org/skrooge.git/tree/p ... se.ui#n179, which mentions:

Code: Select all

<header>QtWebKitWidgets/QWebView</header>


QtWebKitWidgets should not appear with QWebengine, right?

Hi,
I did a new commit.
Regards.

Many thanks, I have tried 225c3d1fe0cbb23aa26da75b6c08c72352af3cbd and it worked! As soon as a stable version appears, I will push it in NixOS with QWebEngine enabled.

One last question: What is the designer library (SKG_DESIGNER cmake option) about? Would the majority of Skrooge users need it?


Best regards.

Hi,

SKG_DESIGNER must be used to generate the needed library for QtDesigner.
This is needed ONLY for developers.
So NOT NEEDED for end user.
Regards.

PS: I will update the README to add this information.

I am having troubles to compile with QWebEngine too:

Code: Select all

make clean
cmake .. -DCMAKE_INSTALL_PREFIX=`kf5-config --prefix` -DQT_PLUGIN_INSTALL_DIR=`kf5-config --qt-plugins` -DCMAKE_BUILD_TYPE=release -DSKG_BUILD_TEST=OFF -DSKG_DESIGNER=OFF -DSKG_WEBENGINE=ON
(...)

-- Configuring done
-- Generating done
-- Build files have been written to: /home/Bajado/Instalables/skrooge/build

So far so good, but then:

Code: Select all

make
(..)
[ 22%] Building CXX object skgbasegui/CMakeFiles/skgbasegui.dir/skgsortfilterproxymodel.cpp.o
[ 22%] Building CXX object skgbasegui/CMakeFiles/skgbasegui.dir/skgflowlayout.cpp.o
[ 23%] Building CXX object skgbasegui/CMakeFiles/skgbasegui.dir/skgwebview.cpp.o
/home/Bajado/Instalables/skrooge/skgbasegui/skgwebview.cpp: In member function 'virtual void SKGWebView::exportInFile(const QString&)':
/home/Bajado/Instalables/skrooge/skgbasegui/skgwebview.cpp:264:26: error: 'pdfPrintingFinished' is not a member of 'QWebEnginePage'
         connect(page(), &QWebEnginePage::pdfPrintingFinished, this, &SKGWebView::fileExporter);
                          ^
/home/Bajado/Instalables/skrooge/skgbasegui/skgwebview.cpp: In lambda function:
/home/Bajado/Instalables/skrooge/skgbasegui/skgwebview.cpp:326:17: error: 'class QWebEnginePage' has no member named 'print'
         page()->print(printer, [](bool) {});
                 ^
/home/Bajado/Instalables/skrooge/skgbasegui/skgwebview.cpp: In member function 'virtual void SKGWebView::onPrint()':
/home/Bajado/Instalables/skrooge/skgbasegui/skgwebview.cpp:342:17: error: 'class QWebEnginePage' has no member named 'print'
         page()->print(&m_printer, [](bool) {});
                 ^
skgbasegui/CMakeFiles/skgbasegui.dir/build.make:754: recipe for target 'skgbasegui/CMakeFiles/skgbasegui.dir/skgwebview.cpp.o' failed
make[2]: *** [skgbasegui/CMakeFiles/skgbasegui.dir/skgwebview.cpp.o] Error 1
CMakeFiles/Makefile2:1630: recipe for target 'skgbasegui/CMakeFiles/skgbasegui.dir/all' failed
make[1]: *** [skgbasegui/CMakeFiles/skgbasegui.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
root@liet:/home/Bajado/Instalables/skrooge/build#


Am I missing something?

Thanks
JM

To enable QWEBENGINE (Not recommended yet), you need at least Qt 5.9

I committed a correction for that: https://commits.kde.org/skrooge/29e8ccb ... 04e54671e6