Some of you may have noticed that there is now a possibility to upload patches for review on the new Phabricator site from within KDevelop (under the Export Diff button in the Patch Review toolview).

Working with Phabricator requires some adaptation to habits and tools. For instance, to create more useful review requests from uncommitted local changes one must provide the context in the patchfile to be uploaded (ReviewBoard would reconstruct that context automatically). The usual version control systems are all able to generate patch files with a configurable context (number of lines before and after each changed hunk).

It is thus not very difficult to support this functionality in the Patch Review tool but that requires an additional control element and the question is whether that is justified.

I'd thus like to have an idea how welcome this feature would be or not. Please tick all options that apply below.

I would personally welcome the feature (and thus wrote an implementation) because there have been times in the past where I wanted or needed patchfiles with more (or less!) than the standard 3 lines of context - independent from Phabricator.

Thanks to everyone taking the time to read and answer!

I think this would be a useful feature, and there's plenty of space for such an option.

FWIW, the patch-review tool could be used to upload committed changes, by using the 'view diff' option from git history/annotations.

Thanks for this first answer!

flherne wrote:FWIW, the patch-review tool could be used to upload committed changes, by using the 'view diff' option from git history/annotations.

Yes, and from the git/branches view to submit a diff of the tip of a topic branch relative to say the master branch. I cannot say at this point how easy it would be to access the reference commit information from where the phabricator plugin is invoked.

FWIW, both ways of uploading to Phabricator have their pros, cons and .... fans.