When chunkCount>barWidth and chunkCount<2*barWidth the bar ends when chunkNumber=barWidth.

Fix (Applied on SVS-version 480096)
Change UNIT32 to double on chunks_per_pixel
--------------------------------------
chunkbar.cpp

Code: Select all

void ChunkBar::drawMoreChunksThenPixels(QPainter *p,const BitSet & bs,const QColor & color)
   {
      Uint32 w = contentsRect().width();
      double chunks_per_pixel = (double)bs.getNumBits() / w;   
      QValueList<Range> rs;
      
      for (Uint32 i = 0;i < w;i++)
      {
         Uint32 num_dl = 0;
         Uint32 jEnd= (Uint32)((i+1)*chunks_per_pixel+0.5);
         for (Uint32 j = (Uint32)(i*chunks_per_pixel);j < jEnd;j++)
            if (bs.get(j))
               num_dl++;
   
         if (num_dl == 0)
            continue;



Pär H
[/code]

Sorry, Korrektion.
Chunks did never reach 100%

Code: Select all

   void ChunkBar::drawMoreChunksThenPixels(QPainter *p,const BitSet & bs,const QColor & color)
   {
      Uint32 w = contentsRect().width();
      double chunks_per_pixel = (double)bs.getNumBits() / w;   
      QValueList<Range> rs;
      
      for (Uint32 i = 0;i < w;i++)
      {
         Uint32 num_dl = 0;
         Uint32 jStart=(Uint32)(i*chunks_per_pixel);
         Uint32 jEnd= (Uint32)((i+1)*chunks_per_pixel+0.5);
         for (Uint32 j = jStart;j < jEnd;j++)
            if (bs.get(j))
               num_dl++;
   
         if (num_dl == 0)
            continue;
   
         int fac = int(100*num_dl / (jEnd-jStart));



You're right, using an integer for chunks per pixel could cause some rounding errors.

You missed the calculation of fac, the roundning of the value almost newer reach 100%, 99% is interpreted as 75 when setting colour.

For example:

Code: Select all

int fac = int(100*((double)num_dl / (jEnd-jStart)) + 0.5);


Fixed, thanks !

Additional korrektion.

change:
int fac = int(100*((double)num_dl / (jEnd - jStart) + 0.5));
to
int fac = int(100*((double)num_dl / (jEnd - jStart)) + 0.5);
-----------

if
num_dl=(jEnd-jStart)=5 for example
then
int(100*(5/5+0.5)) = 150
and 150!=100 when selecting colour

korrekt
int (100*(5/5))+0.5) = int (100.5) = 100

* takes precendence over +

So 100*(5/5)+0.5) = 100 + 0.5 = 100.5

() take precendence over both + and *

**** didn't see them, just looked at your example.

EDIT: it's fixed now