I faild to download a torrent "tracker: Invalid response".
The same torrent is working in official client.

The .torrent is avaiable online at:
http://a.scarywater.net/fot/[FoT&A-W]Sailor_Stars_-_169.mp4.torrent

I get this : (load the logviewer plugin if you have an SVN version)

Error : This torrent is not allowed on this tracker.

Yes, same error for me, but I can successfully download it using the official client.

And if you check the request KT send you see that info_hach begins with an explanation mark ("!") - is that rely rigth - if it truly is an explanation mark in the beginning shuld you not encode it with %xx.

No the ! is OK. It's fixed now, the problem was the improper encoding of spaces.

has this been commited?

The .torrent in the first post works for me. A few hours old checkout rev. 483746. So I'm guessing it's comited.

Side note on that, got a build error in plugins/infowidget/infowidgetbase.cpp, two strange declarations. Two headers was declared like #include kt::something.h, removing the kt:: fixed the build. Looks like the ui file has two errors, with: widget class="kt::DownloadedChunkBar" and widget class="kt::AvailabilityChunkBar".

I haven't noticed any problems with the ui files.

<i>I haven't noticed any problems with the ui files.</i>

If I delete infowidgetbase.cpp so it must be recreated from the ui file I get the folowing error when building(rev. 483746):

../ktorrent/plugins/infowidget/infowidgetbase.cpp:24:36: kt::downloadedchunkbar.h: No such file or directory
../ktorrent/plugins/infowidget/infowidgetbase.cpp:25:38: kt::availabilitychunkbar.h: No such file or directory
Error creating ../ktorrent/plugins/infowidget/infowidgetbase.lo. Exit status 1.

For some reason the generated cpp file gets the includes wrong, like this #include "kt::downloadedchunkbar.h". The kt:: in the filename is obviously wrong.

When trying to open the ui file in designer, I get a Segmentation fault. It may be some problem on my setup, I'll try to investigate further.

This is the custom widgets part of the ui file :
<customwidgets>
<customwidget>
<class>kt::DownloadedChunkBar</class>
<header location="local">downloadedchunkbar.h</header>
<sizehint>
<width>-1</width>
<height>20</height>
</sizehint>
<container>0</container>
<sizepolicy>
<hordata>5</hordata>
<verdata>5</verdata>
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
<pixmap>image0</pixmap>
</customwidget>
<customwidget>
<class>kt::AvailabilityChunkBar</class>
<header location="local">availabilitychunkbar.h</header>
<sizehint>
<width>-1</width>
<height>20</height>
</sizehint>
<container>0</container>
<sizepolicy>
<hordata>5</hordata>
<verdata>5</verdata>
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
<pixmap>image0</pixmap>
</customwidget>
</customwidgets>

As you can see, the header files specified are without the kt::, so this appears to be a stupid bug in your version uic

<i>As you can see, the header files specified are without the kt::, so this appears to be a stupid bug in your version uic</i>

I thought so first too, but it looks more like a combination of my (stupid) uic(qt-copy from svn) and the ui file. Looking at the changes to the ui file, the last change to version 483018 adds the kt:: parts in the includehints section of the ui file.

<includehints>
<includehint>kt::downloadedchunkbar.h</includehint>
<includehint>kt::availabilitychunkbar.h</includehint>
<includehint>klistview.h</includehint>
</includehints>

Removing those kt::'s everything compiles nicely for me again.

BTW:
That commit reverse the changes made in the previous commit to that file too, Revision 481817. fixuifiles and i18n style guide fixes

Simple patch for the issues mentioned in my previus post:

Code: Select all

Index: extragear/network/ktorrent/plugins/infowidget/infowidgetbase.ui
===================================================================
--- extragear/network/ktorrent/plugins/infowidget/infowidgetbase.ui   (revision 484197)
+++ extragear/network/ktorrent/plugins/infowidget/infowidgetbase.ui   (working copy)
@@ -12,9 +12,6 @@
             <height>293</height>
         </rect>
     </property>
-    <property name="caption">
-        <string>InfoWidgetBase</string>
-    </property>
     <hbox>
         <property name="name">
             <cstring>unnamed</cstring>
@@ -739,8 +736,8 @@
 </images>
 <layoutdefaults spacing="6" margin="11"/>
 <includehints>
-    <includehint>kt::downloadedchunkbar.h</includehint>
-    <includehint>kt::availabilitychunkbar.h</includehint>
+    <includehint>downloadedchunkbar.h</includehint>
+    <includehint>availabilitychunkbar.h</includehint>
     <includehint>klistview.h</includehint>
 </includehints>
 </UI>


It's fixed

It's fixed

Great, thanks.