This includes all the bug fixes since 1.2rc1.

Packages can be found on the downloads page.

BUGS BUGS BUGS... damn it!

Sorry but I found some bugs which need to be fixed (in the new rc2):

1) when I leave KTorrent in the System Tray sometimes it closes by itself without any error notice (simply it shuts down);

2) I created a new torrent from a directory (multifile) and then I posted it to the tracker. When I've downloaded the tracker modified torrent I tried to import it in KTorrent using as target the directory from which I've created the torrent. It checked and it added to the transfers list but it doesn't upload anything;

3) When I've removed that torrent from transfers list, KTorrent closed and an error signal (SIGEVG or something similar) showed up but it was useless for debug purpose (no stack saved);

I tried many times but same results.

axelgenus wrote:BUGS BUGS BUGS... damn it!

Sorry but I found some bugs which need to be fixed (in the new rc2):

1) when I leave KTorrent in the System Tray sometimes it closes by itself without any error notice (simply it shuts down);

Haven't noticed it here, if you run it from a console with the --debug and --nofork options, what gets printed to the console ?

2) I created a new torrent from a directory (multifile) and then I posted it to the tracker. When I've downloaded the tracker modified torrent I tried to import it in KTorrent using as target the directory from which I've created the torrent. It checked and it added to the transfers list but it doesn't upload anything;

Are you connected to anybody ? Is somebody downloading the torrent ?

3) When I've removed that torrent from transfers list, KTorrent closed and an error signal (SIGEVG or something similar) showed up but it was useless for debug purpose (no stack saved);

Sounds like the weird bug Ivan is working on, I'm not getting that bug.

George wrote:Haven't noticed it here, if you run it from a console with the --debug and --nofork options, what gets printed to the console ?

No luck! On the terminal window the messages are normal except when I remove the torrent (I read in the forum that probably is a FAT32 partition related error; my partition *IS* FAT32).

These are the messages:

(in the console)
> "KCrash: Application 'ktorrent' crashing...". Then appear this message:

(KCrash window)
> Using host libthread_db library "/lib/libthread_db.so.1".
> [Thread debugging using libthread_db enabled]
> [New Thread 16384 (LWP 8097)]
> [New Thread 32769 (LWP 8210)]
> 0x00002aaaae161dba in waitpid () from /lib/libpthread.so.0
> #0 0x00002aaaae161dba in waitpid ()
> from /lib/libpthread.so.0
> #1 0x00002aaaabc8a06b in KCrash::defaultCrashHandler ()
> from /usr/kde/3.4/lib/libkdecore.so.4
> #2 0x00002aaaae160bf8 in __pthread_sighandler ()
> from /lib/libpthread.so.0
> #3 0x00002aaaae9ade90 in killpg () from /lib/libc.so.6
> #4 0x0000000000000000 in ?? ()

George wrote:Are you connected to anybody ? Is somebody downloading the torrent ?

No, it's me trying to download again that files. It's strange: at first KTorrent checks the files, it gives no error, it creates a new directory inside the directory where I told it to check for my files and it starts a new download in the new sub-folder... what a mess!

George wrote:Sounds like the weird bug Ivan is working on, I'm not getting that bug.

I don't really know what's going on but it really needs to be fixed!

edit: ahhhh... I'm really going crazy! It seems like this is a random bug! I've done the same procedure over and over again and now it worked! I don't really know how's that possible...

Perhaps something ain't working in import plugin or it ain't fully compatible with a FAT32 partition (I really need such partitions because I share them with windows).

axelgenus wrote:

George wrote:Sounds like the weird bug Ivan is working on, I'm not getting that bug.

edit: ahhhh... I'm really going crazy! It seems like this is a random bug! I've done the same procedure over and over again and now it worked! I don't really know how's that possible...

I saw that crash when remowing torrents bug yestereday, but have not had time to see how to reproduce it and get a good backtrace. I'm kind of busy running TestDisk trying to reclaim a lost partition on my secondary disk(not fun):-(

axelgenus wrote:Perhaps something ain't working in import plugin or it ain't fully compatible with a FAT32 partition (I really need such partitions because I share them with windows).

<rant>
As everybody seems to have problems when using FAT32 I sometimes feel the urge to yell "Stop doing that". Giving George and Ivan opportunity to spend more of their time making the program better for the rest of us, who use sane and modern filesystyems:-) Afterall there exist windows filesystem drivers for ext2, not modern either but better than FAT32. There are even tools letting you read/write ReiserFS3 partitions.
</rant>

Knut wrote:I saw that crash when remowing torrents bug yestereday, but have not had time to see how to reproduce it and get a good backtrace.

That's the problem: each time I try to reproduce it, looking for a good backtrace, I'm not able to produce one...

Knut wrote:As everybody seems to have problems when using FAT32 I sometimes feel the urge to yell "Stop doing that". Giving George and Ivan opportunity to spend more of their time making the program better for the rest of us, who use sane and modern filesystyems:-)

That would be great! I'm the first to feel "encumbered" by Windows, but it's really necessary for my job so...

Knut wrote:Afterall there exist windows filesystem drivers for ext2, not modern either but better than FAT32. There are even tools letting you read/write ReiserFS3 partitions.

Can you give me some links?

I don't really like adding workarounds to make KT work with fat32 properly.

And it probably will be messy, seeing that it can't handle some characters in filenames So we would have to ask the user for a new name, and if there are many files with odd characters, that can be annoying.

Not to mention that we would have to figure out wether a directory is on a fat32 partition.

So much trouble for one stupid filesystem. But lots of people use it to share files between Windows and linux.

@Axelgenus :

The backtrace doesn't help much.

George wrote:I don't really like adding workarounds to make KT work with fat32 properly.

I can't think about a good programmer who loves workarounds.

George wrote:And it probably will be messy, seeing that it can't handle some characters in filenames So we would have to ask the user for a new name, and if there are many files with odd characters, that can be annoying.

I don't think that's the point. Many users use linux but many others use windows which can't handle such characters. Who makes torrent should not use such characters and the check should be done when the torrent is created and not when it's loaded...

George wrote:Not to mention that we would have to figure out wether a directory is on a fat32 partition.

Even this is not a problem: linux kernel should manage equally either linux partitions or FAT32...

George wrote:So much trouble for one stupid filesystem. But lots of people use it to share files between Windows and linux.

If there's a driver which manage ext2 (or other linux partitions) in windows would be very useful. I don't like FAT partitions but I really need to share data between Windows and Linux...

George wrote:The backtrace doesn't help much.

I guess... I'm going to recompile glibc without "omitfp" USE flag for better debug support (I hope this would help).

However the bug is showing even on not-FAT32 partitions (I tried ext3): when I remove a torrent from the list (completed or not, stopped or not) KTorrent crashes!

axelgenus wrote:

George wrote:I don't really like adding workarounds to make KT work with fat32 properly.

I can't think about a good programmer who loves workarounds.

George wrote:And it probably will be messy, seeing that it can't handle some characters in filenames So we would have to ask the user for a new name, and if there are many files with odd characters, that can be annoying.

I don't think that's the point. Many users use linux but many others use windows which can't handle such characters. Who makes torrent should not use such characters and the check should be done when the torrent is created and not when it's loaded...

NTFS will support those chars, and seeing that XP uses NTFS by default ...

Even this is not a problem: linux kernel should manage equally either linux partitions or FAT32...

Yeah but, I have to figure out when to apply the workarounds, seeing that they are not needed for all other filesystems.

If there's a driver which manage ext2 (or other linux partitions) in windows would be very useful. I don't like FAT partitions but I really need to share data between Windows and Linux...

I think I once used a program to read an ext2 partition under windows, but it was slow as hell and I completely forgot how it was named.

However the bug is showing even on not-FAT32 partitions (I tried ext3): when I remove a torrent from the list (completed or not, stopped or not) KTorrent crashes!

Compiling KT in debug mode (./configure --enable-debug=full ; make clean ; make) is more then enough to get a decent backtrace.

George wrote:NTFS will support those chars, and seeing that XP uses NTFS by default ...

I knew Linux NTFS partition's write support was incomplete and many times it breaks those partitions...

I have to figure out when to apply the workarounds, seeing that they are not needed for all other filesystems.

The simplest method I can imagine is to look at the mtab file for partitions' type: there you should find everything about mounted partitions even if you are using an Automounter (as Ivman or something alike).

I think I once used a program to read an ext2 partition under windows, but it was slow as hell and I completely forgot how it was named.

If it's really slow It's useless...

Compiling KT in debug mode (./configure --enable-debug=full ; make clean ; make) is more then enough to get a decent backtrace.

Thanks! I'm going to try that A.S.A.P. and then I'll send you a backtrace...

axelgenus wrote:

George wrote:NTFS will support those chars, and seeing that XP uses NTFS by default ...

I knew Linux NTFS partition's write support was incomplete and many times it breaks those partitions...

What I mean is that, we cannot just assume that all torrents will work on fat32 systems because most torrents are probably made on XP on an NTFS filesystem.

I have to figure out when to apply the workarounds, seeing that they are not needed for all other filesystems.

The simplest method I can imagine is to look at the mtab file for partitions' type: there you should find everything about mounted partitions even if you are using an Automounter (as Ivman or something alike).

You can also look in the proc filesystem, for that information.

George wrote:What I mean is that, we cannot just assume that all torrents will work on fat32 systems because most torrents are probably made on XP on an NTFS filesystem.

That's right... perhaps the easiest method is to hard-replace all "problematic" character (in filename). It only needs a function like: string ValidateString(string); where the input string is parsed and each "invalid" (on some partitions like FAT32) character is replaced (always, even if that filesystem can support them). In this way you should solve the problem even if you don't know anything about the partition in which you save the torrent...

George wrote:You can also look in the proc filesystem, for that information.

That's true but mtab is just a simple plain-text file, easy to parse...

You can even use HAL for that but that should be a little more difficult...

edit:
Ok, I recompiled KT in debug mode.
Do you remember when I told you that KT randomly shutted down wihout any notice? Well, it did that again. I found the log file in /home/lex/.kde3.4/share/apps/ktorrent and this is the last line: "Homer Simpson 3974103040 3973001216". I'm *not* downloading anything related to "Homer Simpson". The previous lines are normal (chunks downloaded, IP blacklisted, ecc, ecc...).

edit (another):
After those shutdowns the torrents become unreadable and the program gives many errors...

axelgenus wrote:

George wrote:What I mean is that, we cannot just assume that all torrents will work on fat32 systems because most torrents are probably made on XP on an NTFS filesystem.

That's right... perhaps the easiest method is to hard-replace all "problematic" character (in filename). It only needs a function like: string ValidateString(string); where the input string is parsed and each "invalid" (on some partitions like FAT32) character is replaced (always, even if that filesystem can support them). In this way you should solve the problem even if you don't know anything about the partition in which you save the torrent...

That could cause problems of it own (name clashes for example)

That's true but mtab is just a simple plain-text file, easy to parse...

Do cat /proc/mounts and you will see it's test to.

edit:
Ok, I recompiled KT in debug mode.
Do you remember when I told you that KT randomly shutted down wihout any notice? Well, it did that again. I found the log file in /home/lex/.kde3.4/share/apps/ktorrent and this is the last line: "Homer Simpson 3974103040 3973001216". I'm *not* downloading anything related to "Homer Simpson". The previous lines are normal (chunks downloaded, IP blacklisted, ecc, ecc...).

Ah, Homer to the rescue ...

Leaving debug code in can sometimes be usefull

It should be fixed know.

George wrote:Do cat /proc/mounts and you will see it's test to.

Well, at the end it seems like it's the same thing...

George wrote:Ah, Homer to the rescue ...
Leaving debug code in can sometimes be usefull
It should be fixed know.

Yeah, I supposed was something like a debug code but what do you mean by saying "It sould be fixed now."? Do you refer to SVN code? Did you fix the bug?

George wrote:

axelgenus wrote:

If there's a driver which manage ext2 (or other linux partitions) in windows would be very useful. I don't like FAT partitions but I really need to share data between Windows and Linux...

I think I once used a program to read an ext2 partition under windows, but it was slow as hell and I completely forgot how it was named.

Yeah, I have used something like that too, many years ago on windows 98 or something. It was actually some kind of filemanager for reading ext2 disks. Don't remember the name either and I recall it was not particularly good, as you say slow and it had some troubles with big partitions. But that was not what I was thinking about.

I heard some rumours about a real filesystem driver for ext2 on windows, a quick Google revealed this: Ext2Fsd http://sourceforge.net/projects/ext2fsd

Since I don't have any ext2 partitions anymore, I can't say how good this one really are.