This forum has been archived. All content is frozen. Please use KDE Discuss instead.

[BUG] Multifile import

Tags: None
(comma "," separated)
switchcakes
Registered Member
Posts
14
Karma
0

[BUG] Multifile import

Mon Jan 30, 2006 6:22 pm
1) line 81 of ktorrent/plugins/partfileimport/importdialog.cpp should read "Cannot load the torrent file : %1" <-- not "%s"

2) Whenever some files of a multifile torrent don't exist in the import data, it should be assumed that they were never meant to be downloaded originally and should be ignored, rather than ktorrent bailing out of the import process with an error. (As it is now, to get import working for torrents which contain some files I don't want, I need to create 0 byte files for those that I had never checked for download in the first place.)

Using SVN 1/30/06.
George
Moderator
Posts
5421
Karma
1

Re: [BUG] Multifile import

Mon Jan 30, 2006 7:17 pm
switchcakes wrote:1) line 81 of ktorrent/plugins/partfileimport/importdialog.cpp should read "Cannot load the torrent file : %1" <-- not "%s"


It is %1

2) Whenever some files of a multifile torrent don't exist in the import data, it should be assumed that they were never meant to be downloaded originally and should be ignored, rather than ktorrent bailing out of the import process with an error. (As it is now, to get import working for torrents which contain some files I don't want, I need to create 0 byte files for those that I had never checked for download in the first place.)


OK, fixed it, this was my last fix before the 1.2 release.

Last edited by George on Mon Jan 30, 2006 7:52 pm, edited 1 time in total.
switchcakes
Registered Member
Posts
14
Karma
0

Mon Jan 30, 2006 7:34 pm
Oops I meant line 101 not 81: "Cannot verify data : %s" should be "%1"
Thx for the fix.

Last edited by switchcakes on Mon Jan 30, 2006 9:10 pm, edited 1 time in total.
switchcakes
Registered Member
Posts
14
Karma
0

Mon Jan 30, 2006 9:09 pm
I've been busy importing, and I figure I may as well add to this thread:

3) Importer can't find/open torrent filenames that contain the '#' character.

I renamed my torrents to remove the '#' character in the .torrent name and imported again and found:

4) Those that have a toplevel directory with '#' in the name seem to go through the import process but after they're added to the download list, all the child files have 0% progress when they should have partial data (I double checked with another torrent data verifier app to make sure).

I haven't checked any torrents that have subdirectory names with the '#' character -- only a few torrent with a toplevel directory like this.
George
Moderator
Posts
5421
Karma
1

Tue Jan 31, 2006 4:58 pm
Got a torrent like that ?

Normally the # should be handled well. Are you doing the import from a fat partition ?


Bookmarks



Who is online

Registered users: abc72656, Bing [Bot], daret, Google [Bot], lockheed, Sogou [Bot], Yahoo [Bot]