This forum has been archived. All content is frozen. Please use KDE Discuss instead.

[PATCHES] InfoWidget and MultifileImport

Tags: None
(comma "," separated)
imported4-HayArms
Registered Member
Posts
6
Karma
0
Hi,

I've made two patches , one for the InfoWidget plugin and the other for the partimport plugin.

The first patch adds a little widget in the Status Tab of the InfoWidget that show the Chunk Size of the current torrent. The patch modifies 4 files :

- importwidgetbase.ui -> Added the widget on the screen

- infowidget.cpp -> updates the widget with the proper values

- torrentinterface.h -> Added the "Uint32 chunk_size" member in the
TorrentStats struct

- torrentcontrol.cpp -> Fill the chunk_size member in the TorrentStats struct
with proper values

The second patch adjust a little asymmetry in the Importdialog window and I also wrote a new algoritm for multi file torrents import . It is a little faster and imported better a file I started downloading with azureus than the original algorithm (even if it should just work as the original one , I don't know what changed)

A tar with the patches at URL : www.webalice.it/hayarms/ktorrentpatches.tar.bz2 :)

Bye

Marcello
George
Moderator
Posts
5421
Karma
1

Sun Feb 05, 2006 1:16 pm
I will test out your patch, but first I need to go over all the other forum posts.
George
Moderator
Posts
5421
Karma
1

Sun Feb 05, 2006 2:15 pm
The import plugin patch seems to be pretty good, a lot less complicated then my implementation. But when files are missing in the directory you are importing, things go wrong.

It goes OK until you reach the file which isn't there anymore, files after that do not get imported. Things will probably also go wrong, if the file sizes are not the same as in the torrent.
George
Moderator
Posts
5421
Karma
1

Sun Feb 05, 2006 2:29 pm
infowidget patch is good, I'm gonna commit that.
imported4-HayArms
Registered Member
Posts
6
Karma
0

Sun Feb 05, 2006 2:38 pm
I'll try to resolve the problems of the to the import patch and , if I'll succeed , I'll post the corrected version :)

Thanks

Bye

Marcello
imported4-HayArms
Registered Member
Posts
6
Karma
0

Sun Feb 05, 2006 6:06 pm
www.webalice.it/hayarms/importplugin.patch.bz2

Here an update for the importplugin patch, tell me if now works correctly :)

Greets

Marcello :)
George
Moderator
Posts
5421
Karma
1

Sun Feb 05, 2006 8:44 pm
I will try it out tomorrow.
George
Moderator
Posts
5421
Karma
1

Mon Feb 06, 2006 5:39 pm
Patch is OK and I have committed it,

But I changed the fix to the dialog and used Qt designer to align the 2 url selectors.

Btw, if you make patches, use svn diff, a lot easier to apply, seeing that it will make sure the paths are OK.


Bookmarks



Who is online

Registered users: abc72656, Bing [Bot], daret, Google [Bot], lockheed, Sogou [Bot], Yahoo [Bot]