I noticed this bug some weeks back already, but i wanted more time to be sure that the right click-> ban peer caused the crash.

Normally "ban peer" just works great, but sometimes when a peer tries to enable a connection again and this peer was already (manually) banned, it pops up for about 2 seconds and leaves the peerview again.

When i "right-click->ban peer" in these two seconds a peer pops-up, KTorrent crash. (always in one second)

-debug

Code: Select all

invalid length 24902
end from FAM server connection
invalid length 24902
invalid length 24902
invalid length 24902
invalid length 24902
end from FAM server connection
invalid length 24902
invalid length 24902
invalid length 24902
pure virtual method called
terminate called without an active exception
KCrash: Application 'ktorrent' crashing...


backtrace

Code: Select all

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1232938560 (LWP 9400)]
[KCrash handler]
#6  0xffffe410 in __kernel_vsyscall ()
#7  0xb687e9a1 in raise () from /lib/tls/i686/cmov/libc.so.6
#8  0xb68802b9 in abort () from /lib/tls/i686/cmov/libc.so.6
#9  0xb6a5dc07 in __gnu_cxx::__verbose_terminate_handler ()
   from /usr/lib/libstdc++.so.6
#10 0xb6a5b915 in __gxx_personality_v0 () from /usr/lib/libstdc++.so.6
#11 0xb6a5b94a in std::terminate () from /usr/lib/libstdc++.so.6
#12 0xb6a5bfb9 in __cxa_pure_virtual () from /usr/lib/libstdc++.so.6
#13 0xb5dbdc4f in kt::PeerView::banPeer (this=0x8477488, peer=0x8fa91e0)
    at peerview.cpp:162
#14 0xb5dbdf13 in kt::PeerView::contextItem (this=0x8477488, id=-147)
    at peerview.cpp:212
#15 0xb5dbf214 in kt::PeerView::qt_invoke (this=0x8477488, _id=112,
    _o=0xbfff2ae8) at peerview.moc:117
#16 0xb704ce29 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#17 0xb704d738 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#18 0xb73fa81b in QPopupMenu::activated () from /usr/lib/libqt-mt.so.3
#19 0xb71717c7 in QPopupMenu::actSig () from /usr/lib/libqt-mt.so.3
#20 0xb7171e74 in QPopupMenu::mouseReleaseEvent () from /usr/lib/libqt-mt.so.3
#21 0xb797d81b in KPopupMenu::mouseReleaseEvent () from /usr/lib/libkdeui.so.4
#22 0xb70875fd in QWidget::event () from /usr/lib/libqt-mt.so.3
#23 0xb6fe2dc6 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#24 0xb6fe3350 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#25 0xb777cced in KApplication::notify () from /usr/lib/libkdecore.so.4
#26 0xb6f7415d in QApplication::sendSpontaneousEvent ()
   from /usr/lib/libqt-mt.so.3
#27 0xb6f6f558 in QETWidget::translateMouseEvent ()
   from /usr/lib/libqt-mt.so.3
#28 0xb6f6dcf1 in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#29 0xb6f87473 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#30 0xb6ffb8b7 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#31 0xb6ffb7da in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#32 0xb6fe18d5 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#33 0x0805e365 in main (argc=2, argv=0xbfff3894) at main.cpp:111


I think i've made crash KTorrent about 8 times in all the time i've used KTorrent (with manual ban a peer) , which is not much, but it's a crash.

Normally, KT should block connection to already banned peer so there's no chance he appears back in PeerView even for a second.
Also as far as I can remember adding the same IP in filter won't change anything (won't crash) so that's not it too.

I have to check it out. Maybe take some preventive measures if I don't reproduce this crash.

I've started to doubt myself now. I'll try some more heavy banning somewhere.