Just updated to revision 527824, and encountered a new and extremely annoying dialog:-) The dialog asks:"This torrent has reached its maximum share ratio. Ignore the limit and start seeding anyway?" for every one of the stopped torrents I have with more than max share ratio.

Not only is the dialog annoying, but it even defaults to yes, making it start the torrents explicit stopped if you are unwary. It appears on start up and any visit to the QM if you press the OK or apply buttons(regardless of any changes made too).

Update:
Actually it pop up evertime I do anything related to up or download, like adding and removing torrents too.

I guess the intention of the dialog are good, making people reconsider sharing torrents even if their max ratio is reached. But it's awful for people with more than one such stopped torrent, it will only lead to people delete the torrents as soon as they stop them. I think a easier way to set the default max share ratio to anything else than 1(in a config dialog or whatever), will give a better result in this regard.

BTW, the flag/country thingy is nice. Doubt it's actually usefull for anything, but has a funny trivia factor:-)

first you got that pop-up dialog when the shared ratio limit is what you decided

but when you remove the torrent (which the normal thing to do after you share it like you want) you got that again that pop-up.

The 2 pop-up are annoying:
the first one that pop-up that bugs you about to share more that what you decided.

why allow the user to fix a share ratio's limit and bug him to share more after ?

and annoy him again when he remove the torrent ?

i suppose the 2nd dialog when you remove the torrent is a bug ?

That should not happen. Dialog is supposed to be shown only when the user explicitly starts a torrent with max share ratio reached. I'm not quite sure what happens if the QM tries to start the torrent but I'll check that.

Knut tell me, if you stop all torrents and restart KT would the dialogs be shown again?

@zebul666:
You got this completely wrong. Dialog is shown to ask the user if he wanted to share OVER the max share ratio he set up. So it's quite usable.


@both:
Actions like adding, stopping, removing torrents etc. trigger QM events. Actually, removing does not so there could be a bug present.
I made some changes to queue manager recently so there are possible bugs just be patient I'll get them. After all this is a development version

Ivan wrote:That should not happen.

Ivan wrote:Dialog is supposed to be shown only when the user explicitly starts a torrent with max share ratio reached. I'm not quite sure what happens if the QM tries to start the torrent but I'll check that.

I'm using manual QM only, if that helps.

Ivan wrote:Knut tell me, if you stop all torrents and restart KT would the dialogs be shown again?

Stopping both up and downloads, then restarting KTorrents give the dialog again.

I also accidentally answered yes to the first one, it resulted in a torrent not possible to manually stop. Selecting the torrent and pressing stop only gave a new batch of the dialog, but the torrent kept on seeding. Had to check the use limit checkbox to make it stop.

Ivan wrote:just be patient I'll get them. After all this is a development version

, no problem

And the commit 528024 - Fixed a small bug in QueueManager - thanks to Cade , looks like it fixed the issue. Great work as usuall, thanks:-)

I was hoping it'll kill two flies