Hi!

There are a lot of data being output in the logviewer. This makes it quite difficult to copy something from the log view. For example, I noticed a blacklisted IP that I wanted to check out. But the selection is removed as soon as something is added to the log.

I have several suggestions to make this (hopefully) better:

1) Have a button and/or menu command that opens the log in the default text editor AND/OR a Copy button/menu command that copies the entire log contents (snapshot) to the clipboard

2) Pause the update of the log view when a selection is made (and remove the selection after a Copy). I've seen this solution in some other software, can't remember which though.

3) Classify log output in MAIN, PEER, <plugin>, DHT etc. and below those maybe in INFO/ERROR. And of course be able to selected what class of messages are of interest. (I know this is probably a lot of work and that it will probably be implemented in version 94.1.3beta7 unless I get up to speed in Linux programming). Just a thought though.

PS.

I noticed some strange log entries:

Code: Select all

Already connected to -BC0064-åT°3z¨ö[US]ä©Ôù

[US] being the control char.

Code: Select all

Already connected to -BC0062-3[95]È[1B]©ÔÊE7¦[81]1

[nn] being hex codes.

Are they peer identifiers? Maybe they will make some text editors wanna run home to mommy?

Maybe some poor schmuck of implementor of another client that didn't do his homework? (i.e. reading the protocol definition)

DS

/rob

Ivan is going to add the possibility to filter out stuff from the logviewer. Maybe he can add a button to open the log in a text editor. I don't know if 2 is that usefull, you can try convincing Ivan.

As for the messages, most peer id look like this -DD0123- followed by random ****. The first part identifies the client and the version. The random **** can be anything, then it all kind of depends how Qt's classes interpret that data.

We're going to filter log messages as George stated. I have a few ideas on how to improve that, so I think it would more-less solve your problems.

Have a button and/or menu command that opens the log in the default text editor AND/OR a Copy button/menu command that copies the entire log contents (snapshot) to the clipboard

It's an easy job to do, but the question is *where* to place those buttons in GUI? Toolbar seems like a good place, but I'm not really sure it's appropriate.

Of course, you can always open log with your favorite text editor at any time and copy whatever selection you want. Log file is located in ~/.kde/share/apps/ktorrent/log

Classify log output in MAIN, PEER, <plugin>, DHT etc. and below those maybe in INFO/ERROR. And of course be able to selected what class of messages are of interest. (I know this is probably a lot of work and that it will probably be implemented in version 94.1.3beta7 unless I get up to speed in Linux programming). Just a thought though.

I'm already working on this.

As for the messages, most peer id look like this -DD0123- followed by random ****. The first part identifies the client and the version. The random **** can be anything, then it all kind of depends how Qt's classes interpret that data.

I'm not really sure where do we parse this message, but if there's an easy access to Peer objects we could easily change this message to something like this:

Already connected to BitComet 0.63 (82.208.212.0)

or something...

Is it a good idea to use focus on log viewer and then crtl+o to open it, crtl+p to pause?
(maybe also a crtl+r(mark line aka remember) and crtl+f(find) as in konversation)

But i agree that the gui is clean and should stay this way, without too much icons and buttons... Maybe even a rightclick in log viewer is enough for this purpose.(?)

But i agree that the gui is clean and should stay this way, without too much icons and buttons... Maybe even a rightclick in log viewer is enough for this purpose.(?)

That would surely be enough for me.

There are no date/time stamps in the log, is it for saving space?

Nice to hear there are already plans for work on the log!

/rob

A typo in the log (I think): "packet_length to large 67108901"
Should maybe be "too large"?
/rob

Is it a good idea to use focus on log viewer and then crtl+o to open it, crtl+p to pause?
(maybe also a crtl+r(mark line aka remember) and crtl+f(find) as in konversation)

It's a good idea. As soon as I finish this initial improvement I'll try doing that if there's enough time before next RC.

A typo in the log (I think): "packet_length to large 67108901"
Should maybe be "too large"?

I'll fix that with my next commit.

Ivan wrote:It's a good idea. As soon as I finish this initial improvement I'll try doing that if there's enough time before next RC.

Ah don't worry, to me KTorrent is a piece of masterwork without this too.