After running ktorrent for a while, it will crashes (invalid read). This happened the first time after todays commits. I haven't checked it, but maybe following informations from valgrind will help you to find the problem:

Code: Select all

==9230== Invalid read of size 1
==9230==    at 0x4101D7E: bt::AuthenticationMonitor::update() (authenticationmonitor.cpp:83)
==9230==    by 0x40F12DE: bt::Server::update() (server.cpp:176)
==9230==    by 0x80713F3: KTorrentCore::update() (ktorrentcore.cpp:460)
==9230==    by 0x8071C95: KTorrentCore::qt_invoke(int, QUObject*) (ktorrentcore.moc:228)
==9230==    by 0x493FE5C8: QObject::activate_signal(QConnectionList*, QUObject*) (in /usr/qt/3/lib/libqt-mt.so.3.3.6)
==9230==    by 0x493FED9C: QObject::activate_signal(int) (in /usr/qt/3/lib/libqt-mt.so.3.3.6)
==9230==    by 0x49732228: QTimer::timeout() (in /usr/qt/3/lib/libqt-mt.so.3.3.6)
==9230==    by 0x494211FD: QTimer::event(QEvent*) (in /usr/qt/3/lib/libqt-mt.so.3.3.6)
==9230==    by 0x4939F496: QApplication::internalNotify(QObject*, QEvent*) (in /usr/qt/3/lib/libqt-mt.so.3.3.6)
==9230==    by 0x493A0120: QApplication::notify(QObject*, QEvent*) (in /usr/qt/3/lib/libqt-mt.so.3.3.6)
==9230==    by 0x49A28B5B: KProtocolInfo::inputType(QString const&) (in /usr/kde/3.5/lib/libkdecore.so.4.2.0)
==9230==  Address 0xDED616C7 is not stack'd, malloc'd or (recently) free'd
KCrash: Application 'ktorrent' crashing...

PS: Maybe valgrind should be used to check the ktorrent a little bit. I've got a lot's of uninitialised reads and sometimes it crashes at exit when I've played a little bit with the plugins. Sry, that I have not the time to look over the code

I've been having crashes today as well, I'll see what I can dig up with gdb.

Seems it crashes rather quickly:

Code: Select all

(gdb) run --debug --nofork
Starting program: /usr/kde/3.5/bin/ktorrent --debug --nofork

Program received signal SIGSEGV, Segmentation fault.
0xb7e7dfc3 in bt::AuthenticationMonitor::update (this=0xb7f00574) at authenticationmonitor.cpp:83
83                                              FD_SET(fd,&rfds);
(gdb) bt
#0  0xb7e7dfc3 in bt::AuthenticationMonitor::update (this=0xb7f00574) at authenticationmonitor.cpp:83
#1  0xb7e6ae29 in bt::Server::update (this=0x82e0c28) at server.cpp:176
#2  0x08075675 in KTorrentCore::update (this=0x82e1ef0) at ktorrentcore.cpp:460
#3  0x08076123 in KTorrentCore::qt_invoke (this=0x82e1ef0, _id=4, _o=0xbfff1068) at ktorrentcore.moc:228
#4  0xb7026349 in QObject::activate_signal () from /usr/qt/3/lib/libqt-mt.so.3
#5  0xb7026b1d in QObject::activate_signal () from /usr/qt/3/lib/libqt-mt.so.3
#6  0xb735f9d9 in QTimer::timeout () from /usr/qt/3/lib/libqt-mt.so.3
#7  0xb704947e in QTimer::event () from /usr/qt/3/lib/libqt-mt.so.3
#8  0xb6fc6c27 in QApplication::internalNotify () from /usr/qt/3/lib/libqt-mt.so.3
#9  0xb6fc78b1 in QApplication::notify () from /usr/qt/3/lib/libqt-mt.so.3
#10 0xb76237aa in KApplication::notify () from /usr/kde/3.5/lib/libkdecore.so.4
#11 0xbfff1510 in ?? ()
#12 0x082e1f28 in ?? ()
#13 0xbfff1304 in ?? ()
#14 0xbfff1238 in ?? ()
#15 0xb6cc0b7d in malloc () from /lib/libc.so.6
#16 0xb6f7599e in QEventLoop::processEvents () from /usr/qt/3/lib/libqt-mt.so.3
#17 0xb6fdd499 in QEventLoop::enterLoop () from /usr/qt/3/lib/libqt-mt.so.3
#18 0xb6fdd386 in QEventLoop::exec () from /usr/qt/3/lib/libqt-mt.so.3
#19 0xb6fc67cf in QApplication::exec () from /usr/qt/3/lib/libqt-mt.so.3
#20 0x0805f756 in main (argc=3, argv=0xbfff16d4) at main.cpp:114

Strange, I didn't experience any crashes when I tested it. I'll see if I can reproduce it.

I have KT running for 20 minutes or so, and haven't seen the crash yet.

Were you guys running with or without encryption ?

Without plugins, Encryption, Unencrypted connections allowed, DHT, Behind a NAT-Router+Firewall (ports forwarded), maximum connections+ global connection limit+upload rate+download rate+upload slots set, uploading and downloading at the moment (2 download, 23 upload)

Running under linux-2.6.17, glibc 2.4, kdelibs 3.5.3. iptables not running locally at the moment. The router is a linksys wrt54gs with dd-wrt 0.23 sp1. ports are forwarded manually and traffic is shaped.

Without it runs day+ without a problem, as soon as i turn on encryption it takes less then one minute to crash here.

Code: Select all

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1233054016 (LWP 25392)]
[New Thread -1245598800 (LWP 25431)]
[KCrash handler]
#6  0xb7f4a878 in bt::AuthenticationMonitor::update ()
   from /usr/lib/libktorrent.so.0
#7  0xb7f3b278 in bt::Server::update () from /usr/lib/libktorrent.so.0
#8  0x0806dbb4 in KTorrentCore::update ()
#9  0x08072dde in KTorrentCore::qt_invoke ()
#10 0xb7031eb9 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#11 0xb7032954 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#12 0xb73c739e in QTimer::timeout () from /usr/lib/libqt-mt.so.3
#13 0xb7056eb1 in QTimer::event () from /usr/lib/libqt-mt.so.3
#14 0xb6fc7e56 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#15 0xb6fc8052 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#16 0xb7762e31 in KApplication::notify () from /usr/lib/libkdecore.so.4
#17 0xb6f59157 in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#18 0xb6fb9843 in QEventLoop::activateTimers () from /usr/lib/libqt-mt.so.3
#19 0xb6f6cf67 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#20 0xb6fe0947 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#21 0xb6fe086a in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#22 0xb6fc6965 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#23 0x0805e51f in main ()



OK, try it now, I have thrown in some safety checks and fixed another bug.

Nope, crashing

Code: Select all

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1233013056 (LWP 332)]
[New Thread -1245705296 (LWP 367)]
[KCrash handler]
#6  0xb7f5476a in bt::AuthenticationMonitor::update ()
   from /usr/lib/libktorrent.so.0
#7  0xb7f45288 in bt::Server::update () from /usr/lib/libktorrent.so.0
#8  0x0806dbb4 in KTorrentCore::update ()
#9  0x08072dde in KTorrentCore::qt_invoke ()
#10 0xb703beb9 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#11 0xb703c954 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#12 0xb73d139e in QTimer::timeout () from /usr/lib/libqt-mt.so.3
#13 0xb7060eb1 in QTimer::event () from /usr/lib/libqt-mt.so.3
#14 0xb6fd1e56 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#15 0xb6fd2052 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#16 0xb776ce31 in KApplication::notify () from /usr/lib/libkdecore.so.4
#17 0xb6f63157 in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#18 0xb6fc3843 in QEventLoop::activateTimers () from /usr/lib/libqt-mt.so.3
#19 0xb6f76f67 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#20 0xb6fea947 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#21 0xb6fea86a in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#22 0xb6fd0965 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#23 0x0805e51f in main ()


Allright, try it now, I haven't been able to reproduce it yet, but I have some suspicion what is causing it and my last commit should prevent it from happening.

Looks fine. Good work

EDIT: I must correct me. It crashed again

Forgot Backtrace:

Code: Select all

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1232111952 (LWP 10835)]
0xb7f57efd in bt::AuthenticationMonitor::update (this=0xb7fd4b14) at authenticationmonitor.cpp:108
108                             if (FD_ISSET(fd,&rfds))
(gdb) bt
#0  0xb7f57efd in bt::AuthenticationMonitor::update (this=0xb7fd4b14) at authenticationmonitor.cpp:108
#1  0xb7f472ff in bt::Server::update (this=0x823c520) at server.cpp:176
#2  0x080713f4 in KTorrentCore::update (this=0x823c468) at ktorrentcore.cpp:460
#3  0x08071c96 in KTorrentCore::qt_invoke (this=0x823c468, _id=4, _o=0xbf9541b8) at ktorrentcore.moc:228
#4  0xb71b22c9 in QObject::activate_signal () from /usr/qt/3/lib/libqt-mt.so.3
#5  0xb71b2a9d in QObject::activate_signal () from /usr/qt/3/lib/libqt-mt.so.3
#6  0xb74e5f29 in QTimer::timeout () from /usr/qt/3/lib/libqt-mt.so.3
#7  0xb71d4efe in QTimer::event () from /usr/qt/3/lib/libqt-mt.so.3
#8  0xb7153197 in QApplication::internalNotify () from /usr/qt/3/lib/libqt-mt.so.3
#9  0xb7153e21 in QApplication::notify () from /usr/qt/3/lib/libqt-mt.so.3
#10 0xb77dab5c in KApplication::notify () from /usr/kde/3.5/lib/libkdecore.so.4
#11 0xbf954670 in ?? ()
#12 0x0823c4a0 in ?? ()
#13 0xbf954454 in ?? ()
#14 0xb6f07019 in operator new () from /usr/lib/gcc/i686-pc-linux-gnu/4.1.1/libstdc++.so.6
Previous frame inner to this frame (corrupt stack?)

Updating now... will let you know when i come back of walking with the dog.

EDIT
Same crash

Code: Select all

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1232959808 (LWP 7785)]
[New Thread -1245504592 (LWP 7799)]
[KCrash handler]
#6  0xb7f617f3 in bt::AuthenticationMonitor::update ()
   from /usr/lib/libktorrent.so.0
#7  0xb7f52288 in bt::Server::update () from /usr/lib/libktorrent.so.0
#8  0x0806dbb4 in KTorrentCore::update ()
#9  0x08072dde in KTorrentCore::qt_invoke ()
#10 0xb7048eb9 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#11 0xb7049954 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#12 0xb73de39e in QTimer::timeout () from /usr/lib/libqt-mt.so.3
#13 0xb706deb1 in QTimer::event () from /usr/lib/libqt-mt.so.3
#14 0xb6fdee56 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#15 0xb6fdf052 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#16 0xb7779e31 in KApplication::notify () from /usr/lib/libkdecore.so.4
#17 0xb6f70157 in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#18 0xb6fd0843 in QEventLoop::activateTimers () from /usr/lib/libqt-mt.so.3
#19 0xb6f83f67 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#20 0xb6ff7947 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#21 0xb6ff786a in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#22 0xb6fdd965 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#23 0x0805e51f in main ()


Sure you have the latest, you need 559763 or later ?

George wrote:Sure you have the latest, you need 559763 or later ?

no this was with 559739, the latest gives the same result however. I'll wipe and do a clean install to be sure.

EDIT
Yeah, co fresh did the trick, i think we're cool here

Nope (7 torrents seeding and one leeching)

Code: Select all

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1233819968 (LWP 3002)]
[New Thread -1246364752 (LWP 3036)]
[KCrash handler]
#6  0xb7e8f803 in bt::AuthenticationMonitor::update ()
   from /usr/lib/libktorrent.so.0
#7  0xb7e80298 in bt::Server::update () from /usr/lib/libktorrent.so.0
#8  0x0806dbb4 in KTorrentCore::update ()
#9  0x08072dde in KTorrentCore::qt_invoke ()
#10 0xb6f76eb9 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#11 0xb6f77954 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#12 0xb730c39e in QTimer::timeout () from /usr/lib/libqt-mt.so.3
#13 0xb6f9beb1 in QTimer::event () from /usr/lib/libqt-mt.so.3
#14 0xb6f0ce56 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#15 0xb6f0d052 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#16 0xb76a7e31 in KApplication::notify () from /usr/lib/libkdecore.so.4
#17 0xb6e9e157 in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#18 0xb6efe843 in QEventLoop::activateTimers () from /usr/lib/libqt-mt.so.3
#19 0xb6eb1f67 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#20 0xb6f25947 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#21 0xb6f2586a in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#22 0xb6f0b965 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#23 0x0805e51f in main ()