[Request] Automatic global max ratio. • KDE Community Forums

This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Board index

[Request] Automatic global max ratio.

Page 1 of 1 (10 posts)

Tags:

pkulak Registered Member Posts 12 Karma 0	[Request] Automatic global max ratio. Thu Jul 27, 2006 6:45 pm I like to set all my torrents max ratios to 1.1. That way I can just forget about them and not worry about uploading 10 gigs while I'm at work or something like that. Right now I have to find every torrent and set it manually, but it would be nice if I could just set it in one place.
George Moderator Posts 5421 Karma 1	Fri Jul 28, 2006 4:37 pm Sounds reasonable, we will add it to the TODO list.
pkulak Registered Member Posts 12 Karma 0	Fri Jul 28, 2006 6:53 pm Yay!
khrothgar Registered Member Posts 4 Karma 0	Sun Jul 30, 2006 6:55 am I have a small patch to do this. Code: Select all Index: apps/ktorrent/downloadpref.ui =================================================================== --- apps/ktorrent/downloadpref.ui (revision 567783) +++ apps/ktorrent/downloadpref.ui (working copy) @@ -12,19 +12,22 @@ <height>499</height> </rect> </property> - <vbox> + <property name="caption"> + <string>DownloadPref</string> + </property> + <grid> <property name="name"> <cstring>unnamed</cstring> </property> - <widget class="QLayoutWidget"> + <widget class="QLayoutWidget" row="0" column="0"> <property name="name"> <cstring>layout8</cstring> </property> - <hbox> + <grid> <property name="name"> <cstring>unnamed</cstring> </property> - <widget class="QLayoutWidget"> + <widget class="QLayoutWidget" row="0" column="1"> <property name="name"> <cstring>layout6</cstring> </property> @@ -32,88 +35,6 @@ <property name="name"> <cstring>unnamed</cstring> </property> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1</cstring> - </property> - <property name="text"> - <string>Maximum downloads:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_5</cstring> - </property> - <property name="text"> - <string>Maximum seeds:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel2</cstring> - </property> - <property name="text"> - <string>Maximum connections per torrent:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_7</cstring> - </property> - <property name="text"> - <string>Global connection limit</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel3</cstring> - </property> - <property name="text"> - <string>Maximum upload rate:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_4</cstring> - </property> - <property name="text"> - <string>Maximum download rate:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel5</cstring> - </property> - <property name="text"> - <string>Port:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_3</cstring> - </property> - <property name="text"> - <string>UDP tracker port:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_6</cstring> - </property> - <property name="text"> - <string>Number of upload slots:</string> - </property> - </widget> - </vbox> - </widget> - <widget class="QLayoutWidget"> - <property name="name"> - <cstring>layout5</cstring> - </property> - <vbox> - <property name="name"> - <cstring>unnamed</cstring> - </property> <widget class="KIntNumInput"> <property name="name"> <cstring>max_downloads</cstring> @@ -219,9 +140,14 @@ <number>100</number> </property> </widget> + <widget class="KDoubleNumInput"> + <property name="name"> + <cstring>num_max_ratio</cstring> + </property> + </widget> </vbox> </widget> - <widget class="QLayoutWidget"> + <widget class="QLayoutWidget" row="0" column="2"> <property name="name"> <cstring>layout7</cstring> </property> @@ -289,7 +215,7 @@ </property> <property name="sizeHint"> <size> - <width>179</width> + <width>281</width> <height>20</height> </size> </property> @@ -306,7 +232,7 @@ </property> <property name="sizeHint"> <size> - <width>179</width> + <width>281</width> <height>20</height> </size> </property> @@ -323,28 +249,146 @@ </property> <property name="sizeHint"> <size> - <width>179</width> + <width>281</width> <height>20</height> </size> </property> </spacer> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_2_2_2_2</cstring> + </property> + <property name="text"> + <string>(0 is no limit)</string> + </property> + </widget> </vbox> </widget> - </hbox> + <widget class="QLayoutWidget" row="0" column="0"> + <property name="name"> + <cstring>layout5</cstring> + </property> + <vbox> + <property name="name"> + <cstring>unnamed</cstring> + </property> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1</cstring> + </property> + <property name="text"> + <string>Maximum downloads:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_5</cstring> + </property> + <property name="text"> + <string>Maximum seeds:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel2</cstring> + </property> + <property name="text"> + <string>Maximum connections per torrent:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_7</cstring> + </property> + <property name="text"> + <string>Global connection limit</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel3</cstring> + </property> + <property name="text"> + <string>Maximum upload rate:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_4</cstring> + </property> + <property name="text"> + <string>Maximum download rate:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel5</cstring> + </property> + <property name="text"> + <string>Port:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_3</cstring> + </property> + <property name="text"> + <string>UDP tracker port:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_6</cstring> + </property> + <property name="text"> + <string>Number of upload slots:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_6_2</cstring> + </property> + <property name="text"> + <string>Max share ratio:</string> + </property> + </widget> + </vbox> + </widget> + </grid> </widget> - <widget class="QCheckBox"> + <widget class="QCheckBox" row="1" column="0"> <property name="name"> <cstring>keep_seeding</cstring> </property> <property name="text"> <string>&Keep seeding after download is finished</string> </property> + <property name="accel"> + <string>Alt+K</string> + </property> <property name="checked"> <bool>true</bool> </property> </widget> - <widget class="QGroupBox"> + <spacer row="3" column="0"> <property name="name"> + <cstring>spacer6</cstring> + </property> + <property name="orientation"> + <enum>Vertical</enum> + </property> + <property name="sizeType"> + <enum>Expanding</enum> + </property> + <property name="sizeHint"> + <size> + <width>20</width> + <height>50</height> + </size> + </property> + </spacer> + <widget class="QGroupBox" row="2" column="0"> + <property name="name"> <cstring>groupBox1</cstring> </property> <property name="title"> @@ -364,24 +408,7 @@ </widget> </hbox> </widget> - <spacer> - <property name="name"> - <cstring>spacer6</cstring> - </property> - <property name="orientation"> - <enum>Vertical</enum> - </property> - <property name="sizeType"> - <enum>Expanding</enum> - </property> - <property name="sizeHint"> - <size> - <width>20</width> - <height>20</height> - </size> - </property> - </spacer> - </vbox> + </grid> </widget> <layoutdefaults spacing="6" margin="11"/> <includehints> @@ -403,6 +430,8 @@ <includehint>knuminput.h</includehint> <includehint>knuminput.h</includehint> <includehint>knuminput.h</includehint> + <includehint>knuminput.h</includehint> + <includehint>knuminput.h</includehint> <includehint>kactivelabel.h</includehint> </includehints> </UI> Index: apps/ktorrent/pref.cpp =================================================================== --- apps/ktorrent/pref.cpp (revision 567783) +++ apps/ktorrent/pref.cpp (working copy) @@ -151,6 +151,7 @@ Settings::setMaxTotalConnections(dp->max_total_conns->value()); Settings::setMaxUploadRate(dp->max_upload_rate->value()); Settings::setMaxDownloadRate(dp->max_download_rate->value()); + Settings::setMaxRatio(dp->num_max_ratio->value()); Settings::setKeepSeeding(dp->keep_seeding->isChecked()); Settings::setPort(dp->port->value()); Settings::setNumUploadSlots(dp->num_upload_slots->value()); @@ -173,6 +174,7 @@ dp->max_total_conns->setValue(Settings::maxTotalConnections()); dp->max_upload_rate->setValue(Settings::maxUploadRate()); dp->max_download_rate->setValue(Settings::maxDownloadRate()); + dp->num_max_ratio->setValue(Settings::maxRatio()); dp->keep_seeding->setChecked(Settings::keepSeeding()); dp->udp_tracker_port->setValue(Settings::udpTrackerPort()); dp->port->setValue(Settings::port()); Index: apps/ktorrent/ktorrent.kcfg =================================================================== --- apps/ktorrent/ktorrent.kcfg (revision 567783) +++ apps/ktorrent/ktorrent.kcfg (working copy) @@ -36,6 +36,11 @@ <default>0</default> <min>0</min> </entry> + <entry name="maxRatio" type="Double"> + <label>Maximum share ratio(0 = no limit)</label> + <default>0</default> + <min>0</min> + </entry> <entry name="port" type="Int"> <label>Port</label> <default>6881</default> Index: apps/ktorrent/ktorrentcore.cpp =================================================================== --- apps/ktorrent/ktorrentcore.cpp (revision 567783) +++ apps/ktorrent/ktorrentcore.cpp (working copy) @@ -159,7 +159,10 @@ } tc->setPreallocateDiskSpace(true); - + + if(Settings::maxRatio()>0) + tc->setMaxShareRatio(Settings::maxRatio()); + torrentAdded(tc); qman->torrentAdded(tc); }
George Moderator Posts 5421 Karma 1	Sun Jul 30, 2006 7:19 am To late to add it to 2.0 (string freeze at the moment, so no GUI changes), but we can add it to trunk.
khrothgar Registered Member Posts 4 Karma 0	Fri Sep 29, 2006 8:16 am this patch work with latest svn 590016 Code: Select all Index: apps/ktorrent/downloadpref.ui =================================================================== --- apps/ktorrent/downloadpref.ui (revision 590016) +++ apps/ktorrent/downloadpref.ui (working copy) @@ -12,19 +12,22 @@ <height>499</height> </rect> </property> - <vbox> + <property name="caption"> + <string>DownloadPref</string> + </property> + <grid> <property name="name"> <cstring>unnamed</cstring> </property> - <widget class="QLayoutWidget"> + <widget class="QLayoutWidget" row="0" column="0"> <property name="name"> <cstring>layout8</cstring> </property> - <hbox> + <grid> <property name="name"> <cstring>unnamed</cstring> </property> - <widget class="QLayoutWidget"> + <widget class="QLayoutWidget" row="0" column="1"> <property name="name"> <cstring>layout6</cstring> </property> @@ -32,88 +35,6 @@ <property name="name"> <cstring>unnamed</cstring> </property> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1</cstring> - </property> - <property name="text"> - <string>Maximum downloads:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_5</cstring> - </property> - <property name="text"> - <string>Maximum seeds:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel2</cstring> - </property> - <property name="text"> - <string>Maximum connections per torrent:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_7</cstring> - </property> - <property name="text"> - <string>Global connection limit</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel3</cstring> - </property> - <property name="text"> - <string>Maximum upload rate:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_4</cstring> - </property> - <property name="text"> - <string>Maximum download rate:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel5</cstring> - </property> - <property name="text"> - <string>Port:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_3</cstring> - </property> - <property name="text"> - <string>UDP tracker port:</string> - </property> - </widget> - <widget class="QLabel"> - <property name="name"> - <cstring>textLabel1_6</cstring> - </property> - <property name="text"> - <string>Number of upload slots:</string> - </property> - </widget> - </vbox> - </widget> - <widget class="QLayoutWidget"> - <property name="name"> - <cstring>layout5</cstring> - </property> - <vbox> - <property name="name"> - <cstring>unnamed</cstring> - </property> <widget class="KIntNumInput"> <property name="name"> <cstring>max_downloads</cstring> @@ -222,9 +143,14 @@ <number>2</number> </property> </widget> + <widget class="KDoubleNumInput"> + <property name="name"> + <cstring>num_max_ratio</cstring> + </property> + </widget> </vbox> </widget> - <widget class="QLayoutWidget"> + <widget class="QLayoutWidget" row="0" column="2"> <property name="name"> <cstring>layout7</cstring> </property> @@ -292,7 +218,7 @@ </property> <property name="sizeHint"> <size> - <width>179</width> + <width>281</width> <height>20</height> </size> </property> @@ -309,7 +235,7 @@ </property> <property name="sizeHint"> <size> - <width>179</width> + <width>281</width> <height>20</height> </size> </property> @@ -326,28 +252,146 @@ </property> <property name="sizeHint"> <size> - <width>179</width> + <width>281</width> <height>20</height> </size> </property> </spacer> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_2_2_2_2</cstring> + </property> + <property name="text"> + <string>(0 is no limit)</string> + </property> + </widget> </vbox> </widget> - </hbox> + <widget class="QLayoutWidget" row="0" column="0"> + <property name="name"> + <cstring>layout5</cstring> + </property> + <vbox> + <property name="name"> + <cstring>unnamed</cstring> + </property> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1</cstring> + </property> + <property name="text"> + <string>Maximum downloads:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_5</cstring> + </property> + <property name="text"> + <string>Maximum seeds:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel2</cstring> + </property> + <property name="text"> + <string>Maximum connections per torrent:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_7</cstring> + </property> + <property name="text"> + <string>Global connection limit</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel3</cstring> + </property> + <property name="text"> + <string>Maximum upload rate:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_4</cstring> + </property> + <property name="text"> + <string>Maximum download rate:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel5</cstring> + </property> + <property name="text"> + <string>Port:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_3</cstring> + </property> + <property name="text"> + <string>UDP tracker port:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_6</cstring> + </property> + <property name="text"> + <string>Number of upload slots:</string> + </property> + </widget> + <widget class="QLabel"> + <property name="name"> + <cstring>textLabel1_6_2</cstring> + </property> + <property name="text"> + <string>Max share ratio:</string> + </property> + </widget> + </vbox> + </widget> + </grid> </widget> - <widget class="QCheckBox"> + <widget class="QCheckBox" row="1" column="0"> <property name="name"> <cstring>keep_seeding</cstring> </property> <property name="text"> <string>&Keep seeding after download is finished</string> </property> + <property name="accel"> + <string>Alt+K</string> + </property> <property name="checked"> <bool>true</bool> </property> </widget> - <widget class="QGroupBox"> + <spacer row="3" column="0"> <property name="name"> + <cstring>spacer6</cstring> + </property> + <property name="orientation"> + <enum>Vertical</enum> + </property> + <property name="sizeType"> + <enum>Expanding</enum> + </property> + <property name="sizeHint"> + <size> + <width>20</width> + <height>50</height> + </size> + </property> + </spacer> + <widget class="QGroupBox" row="2" column="0"> + <property name="name"> <cstring>groupBox1</cstring> </property> <property name="title"> @@ -367,24 +411,7 @@ </widget> </hbox> </widget> - <spacer> - <property name="name"> - <cstring>spacer6</cstring> - </property> - <property name="orientation"> - <enum>Vertical</enum> - </property> - <property name="sizeType"> - <enum>Expanding</enum> - </property> - <property name="sizeHint"> - <size> - <width>20</width> - <height>20</height> - </size> - </property> - </spacer> - </vbox> + </grid> </widget> <layoutdefaults spacing="6" margin="11"/> <includehints> @@ -406,6 +433,8 @@ <includehint>knuminput.h</includehint> <includehint>knuminput.h</includehint> <includehint>knuminput.h</includehint> + <includehint>knuminput.h</includehint> + <includehint>knuminput.h</includehint> <includehint>kactivelabel.h</includehint> </includehints> </UI> Index: apps/ktorrent/pref.cpp =================================================================== --- apps/ktorrent/pref.cpp (revision 590016) +++ apps/ktorrent/pref.cpp (working copy) @@ -151,6 +151,7 @@ Settings::setMaxTotalConnections(dp->max_total_conns->value()); Settings::setMaxUploadRate(dp->max_upload_rate->value()); Settings::setMaxDownloadRate(dp->max_download_rate->value()); + Settings::setMaxRatio(dp->num_max_ratio->value()); Settings::setKeepSeeding(dp->keep_seeding->isChecked()); Settings::setPort(dp->port->value()); Settings::setNumUploadSlots(dp->num_upload_slots->value()); @@ -173,6 +174,7 @@ dp->max_total_conns->setValue(Settings::maxTotalConnections()); dp->max_upload_rate->setValue(Settings::maxUploadRate()); dp->max_download_rate->setValue(Settings::maxDownloadRate()); + dp->num_max_ratio->setValue(Settings::maxRatio()); dp->keep_seeding->setChecked(Settings::keepSeeding()); dp->udp_tracker_port->setValue(Settings::udpTrackerPort()); dp->port->setValue(Settings::port()); Index: apps/ktorrent/ktorrent.kcfg =================================================================== --- apps/ktorrent/ktorrent.kcfg (revision 590016) +++ apps/ktorrent/ktorrent.kcfg (working copy) @@ -36,6 +36,11 @@ <default>0</default> <min>0</min> </entry> + <entry name="maxRatio" type="Double"> + <label>Maximum share ratio(0 = no limit)</label> + <default>0</default> + <min>0</min> + </entry> <entry name="port" type="Int"> <label>Port</label> <default>6881</default> Index: apps/ktorrent/ktorrentcore.cpp =================================================================== --- apps/ktorrent/ktorrentcore.cpp (revision 590016) +++ apps/ktorrent/ktorrentcore.cpp (working copy) @@ -152,6 +152,9 @@ } tc->setPreallocateDiskSpace(true); + + if(Settings::maxRatio()>0) + tc->setMaxShareRatio(Settings::maxRatio()); torrentAdded(tc); qman->torrentAdded(tc);
George Moderator Posts 5421 Karma 1	Fri Sep 29, 2006 5:42 pm Hmm, did we forget to check your previous patch ?
George Moderator Posts 5421 Karma 1	Fri Sep 29, 2006 5:48 pm Can you send this by e-mail ? Copy pasting screws things up, and causes the patch to fail.
pkulak Registered Member Posts 12 Karma 0	Thu Oct 05, 2006 8:58 pm Has that patch been added yet?
imported4-Ivan Registered Member Posts 819 Karma 0	Thu Oct 05, 2006 9:09 pm Yes. It's in SVN trunk currently.

Page 1 of 1 (10 posts)

Bookmarks

Who is online

Registered users: bartoloni, Bing [Bot], Evergrowing, Google [Bot], q.ignora, watchstar