This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Feature Request: Sort by ratio

Tags: None
(comma "," separated)
stoked
Registered Member
Posts
32
Karma
0

Feature Request: Sort by ratio

Thu Dec 14, 2006 1:30 pm
Hello,

first....thanks for this great client...using the beta1 here, works like a charm! :)

One thing is missing though, a column for ratios...so that we could sort the torrents by ratio. I'm not a programmer but I can't imagine this is very hard to implement as individual ratios per file are already there...

Is it be possible to add this?

I would love to see which torrents upped my ratio the most...
...especially for private trackers this would be a very useful feature!! ;)
User avatar
bassmadrigal
Registered Member
Posts
113
Karma
0

Thu Dec 14, 2006 2:56 pm
Well it is implemented in the latest svn r613282 (but is still a little buggy). When I went to sort, it kept wanting to swap my .90 with my .50 ratio, which in turn bumped all my others around. This seemed to be redundant.

But so at least you know it is there, now if they can get all the kinks worked out...

Jeremy
imported4-Ivan
Registered Member
Posts
819
Karma
0

Thu Dec 14, 2006 3:52 pm
Well it is implemented in the latest svn r613282 (but is still a little buggy). When I went to sort, it kept wanting to swap my .90 with my .50 ratio, which in turn bumped all my others around. This seemed to be redundant.

What do you mean by this? It works fine here. Could you explain this a bit so I could possibly fix it?
User avatar
bassmadrigal
Registered Member
Posts
113
Karma
0

Thu Dec 14, 2006 10:26 pm
Ivan wrote:
Well it is implemented in the latest svn r613282 (but is still a little buggy). When I went to sort, it kept wanting to swap my .90 with my .50 ratio, which in turn bumped all my others around. This seemed to be redundant.

What do you mean by this? It works fine here. Could you explain this a bit so I could possibly fix it?


I will try to explain it better.

Right now I have 11 torrents ranging from 1.26 to nan (not sure what nan stands for but I assume it is none uploaded). When I click on the share ratio column It will sort them, but this is the order in which it does it.

1.08
nan
1.26
0.91
0.62
0.54
0.50
0.39
0.37
0.34
0.31
0.28

And right now the last two (0.31 and 0.28) are rapidly changing spots. I don't really know a better way to say it. It doesn't seem to stop and it seems to vary which torrents do it each time I try. When I sort the opposite way 0.50 and 0.62 are changing rapidly.

Hopefully this will help, but this is kind of a hard thing to explain without actually showing it.

Jeremy
User avatar
bassmadrigal
Registered Member
Posts
113
Karma
0

Sun Dec 17, 2006 5:26 pm
I think I may have found what causes this bug (at least visually, I am not good enough with programming to dig through the code to find the bug), but... I think what causes it is when you have a file you have downloaded some info but have not uploaded anything yet (like a newly added torrent which has downloaded 128K but has not uploaded anything) and you get the "nan" in the share ratio slot. This seems to be the only time I have the share ratios jump around.

Hopefully this explains enough, and I haven't had a chance to check the latest svn to see if you already fixed it. (Plus I don't have any new torrents to add yet)

Jeremy
George
Moderator
Posts
5421
Karma
1

Sun Dec 17, 2006 7:29 pm
We should prevent the nan from happening (it mean not a number, for the people wondering about it, it is caused when you divide by zero)
Linder
Registered Member
Posts
35
Karma
0

Sun Jan 07, 2007 4:35 pm
George wrote:We should prevent the nan from happening (it mean not a number, for the people wondering about it, it is caused when you divide by zero)
J
Just replace it with 0.00? Seem correct enough.
imported4-Ivan
Registered Member
Posts
819
Karma
0

Sun Jan 07, 2007 5:49 pm
It's fixed already.


Bookmarks



Who is online

Registered users: bartoloni, Bing [Bot], Google [Bot], Yahoo [Bot]