Arr, I'm a bit dazzled here.

I wanted to implement some kind of a feedback when there are no incoming connections (i.e. port isn't forwarded). However, I can't seem to differentiate between incoming connections and those originated by ktorrent. Hints?

We don't keep track wether a Peer was an incoming connection or an outgoing. However the authentication is done in separate classes.

Hym, is there a way to check whether port is forwarded then (from within ktorrent)?

You can place a check in ServerAuthenticate class. If we receive at least one incoming connection - ports are OK.

Also look for Authenticate(S):xxx.xxx.xxx.xxx message in the log file. It indicates an incoming connection

Here's a patch which adds a message in lower left corner when there are no incoming connections. The only problem is that it could fight for place with search messages - maybe putting it above the statusbar on the right would be a good idea, although it is probably better visible on its current location. Anyhow, it disappears when there are incoming connections, so it shouldn't bother anyone on a properly set up firewall.

Apply to r663929, although should work with any other.

I haven't got the time to look it at it today, but it's the first thing I'm gonna do tomorrow.

The patch works, but can't we think of some better way to test this ? One that isn't dependant on seeing incoming connections which might take some time.

The only thing that springs to mind is checking the port externally (from some server), but that's not very feasible nor reliable.

qbittorrent checks for incoming connections too, can't say about azureus, currently I'm unable to download the source code.

Even on a torrent with 1 seed and 8 peers I get incoming connections promptly after starting, so it shouldn't be that much of an issue. One thing I think is worth considering is disabling that message when there is no active torrents - but then, some might overlook it.

All in all, I think this feature can be especially beneficial to less computer-savvy of us, who complain that downloads on ktorrent are slow and they don't have their ports open/forwarded Even if you have everything set up properly, something might screw up some time and without that you won't even notice something is wrong.

I will add it, but hide it when there are no running torrents.

OK, it is committed.

Nice.