I have noticed that some of the peers that I upload to claim to have 00.00% availability even though I have uploaded about 01.22% to them. Those peers will never give any data to me, and will usually use up most of my upload bandwith. After banning those peers I get a better download speed because I can use my upload bandwidth for valid peers. These peers always show 00.00% availability no matter how much I upload to them. This is different from normal peers, which start out at 00.00% and increase their percent proportionally with the data the I send them.

So here's the feature request:
Automatically ban peers that report less availability then ktorrent knows it has given them.

Code: Select all

if  ( data_uploaded / total_file_size ) * 100 > reported_availability
then ban the peer


Not a bad idea, obviously we need some sort of error margin. I would also not do the calculation in percentages but in bytes.

And we need to take into account the current chunk a peer is downloading from us. If we upload one piece of 16K to a peer, that peer will have downloaded 16K from us, but seeing that this is not a full chunk, it's percentage will still be 0.