This release contains all the bugfixes from the last few months and a couple of new features, like the filterbar (hit CTRL+F and you can filter out torrents) and the possibility to manage the files of a torrent via the default webgui.

Just compiled it on my gentoo box, and it crashes on every second tab change (Start app, select any other tab, select another tab -> crash, no matter what tabs to select). So i reverted back to 2.2.2 which is very stable

PS Donno if it's right place to report.

prizident wrote:Just compiled it on my gentoo box, and it crashes on every second tab change (Start app, select any other tab, select another tab -> crash, no matter what tabs to select).

I cannot confirm these crashes. ktorrent 2.2.3 on KDE 3.5.8 Debian unstable/amd64. ktorrent 2.2.3 seems to be running fine so far no matter how I switch among 4 tabs I've created.

Debian packages for 2.2.3:

* Debian testing (lenny) and unstable (sid) : get packages from unstable
* Official Debian stable (etch) backports: i386, amd64, i386 (for debugging) and amd64 (for debugging) (Thanks to Modestas)

Also please remove the following entry from 2.2.2 downloads section:
* Debian testing (lenny) and unstable (sid) : get packages from unstable
You may leave 2.2.2 entry for Debian etch though. Since there are reports of crashes with 2.2.3, I'll keep 2.2.2 packages.

Ok, time to wake up from my sleeper cell and look at where Ubuntu diverges from Debian and see if we can't meet up again on 2.2.3

Ok, just uploaded to Hardy, will be backported to Gutsy, Feisty, Dapper within a week

prizident wrote:Just compiled it on my gentoo box, and it crashes on every second tab change (Start app, select any other tab, select another tab -> crash, no matter what tabs to select). So i reverted back to 2.2.2 which is very stable

PS Donno if it's right place to report.

It's the threaded file list generation (rev. 728567). I just tried to revert it and replace with the timer-based version I posted earlier here, and it works ok.

Patches for Debian Sid are available at http://kmlinux.fjfi.cvut.cz/~makovick/ktorrent/

jmak wrote:It's the threaded file list generation (rev. 728567). I just tried to revert it and replace with the timer-based version I posted earlier here, and it works ok.

Patches for Debian Sid are available at http://kmlinux.fjfi.cvut.cz/~makovick/ktorrent/

Thanks. Though I'm waiting for a word from devs on this one. SMP systems are probably more prone to this crash because I can't reproduce it.

Btw, what was the point of threaded file list generation? I see a few minor differences, but ktorrent 2.2.3 GUI still blocks (not immediately, but after ~2 secs) when selecting a torrent with 7000+ files.

MoDaX wrote:Thanks. Though I'm waiting for a word from devs on this one. SMP systems are probably more prone to this crash because I can't reproduce it.

That's possible - I am running on an SMP Core2.

MoDaX wrote:Btw, what was the point of threaded file list generation? I see a few minor differences, but ktorrent 2.2.3 GUI still blocks (not immediately, but after ~2 secs) when selecting a torrent with 7000+ files.

I couldn't test the original patch due to crashing, but the version above behaves quite well regarding the GUI response. With a 25k file torrent, GUI reacts normally, only switching to another torrent takes about a second because the list has to be cleared, and this cannot be reasonably backgrounded. Also, the patched version generates the list only when it is actually visible.

Crashes confirmed on Ubuntu Gutsy -- repeatedly navigating up and down the filelist in 2.2.3 results in this crash.

Code: Select all

 Qt: Warning: X Error: BadPixmap (invalid Pixmap parameter) 4
  Major opcode:  158
  Minor opcode:  5
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  244
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  0
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  0
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  234
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadLength (poly request too large or internal Xlib length error) 16
  Major opcode:  11
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadPixmap (invalid Pixmap parameter) 4
  Major opcode:  56
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  243
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  0
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  185
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  0
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: X Error: BadRequest (invalid request code or no such operation) 1
  Major opcode:  0
  Minor opcode:  0
  Resource id:  0x40002
Qt: Warning: ktorrent: Fatal IO error: client killed



I will try to rebuild ktorrent with the said changes backed out and see if it improves the situation.

Backing out the mentioned changeset indeed fixes the crasher. I am going to commit this reversal into Hardy.

I think that given the scope and severity of the bug, 2.2.3.1 or 2.2.4 should be released soon

OK, try the latest SVN version (738262), crash should be gone now. (Note anonsvn servers can be a bit behind on the regular SVN servers, so make sure you have at least revision 738262)

Are you going to release a new version (tarball) to fix this bug soon (today, tomorrow)?

Ok, this QTimers based fix is being applied to Hardy currently, then after that's done I'll roll backported packages.