This forum has been archived. All content is frozen. Please use KDE Discuss instead.

[svn] annoying messages on startup from Search plugin

Tags: None
(comma "," separated)
MoDaX
Registered Member
Posts
241
Karma
0
OS
KTorrent trunk has been displaying messages like the following ones below on startup for quite a while already (the image below is just an example, more appear about missing favicons from other sites).

Image

They are related to "Search" plugin. Although they are harmless, they are extremely annoying because I need to "Cancel" all of them each time I start KTorrent. I also do not think it is a good idea to query web sites of the search engines each time KTorrent starts (due to privacy concerns). Please add an option to disable such queries or better yet, cache favicons.
George
Moderator
Posts
5421
Karma
1
MoDaX wrote:KTorrent trunk has been displaying messages like the following ones below on startup for quite a while already (the image below is just an example, more appear about missing favicons from other sites).

Image

They are related to "Search" plugin. Although they are harmless, they are extremely annoying because I need to "Cancel" all of them each time I start KTorrent. I also do not think it is a good idea to query web sites of the search engines each time KTorrent starts (due to privacy concerns). Please add an option to disable such queries or better yet, cache favicons.


The favicons are only downloaded once, and if the download fails we do not show error messages.
MoDaX
Registered Member
Posts
241
Karma
0
OS
George wrote:The favicons are only downloaded once, and if the download fails we do not show error messages.

Then why do I see these each time on startup? Do you record somewhere that favicon is not available?
George
Moderator
Posts
5421
Karma
1
MoDaX wrote:
George wrote:The favicons are only downloaded once, and if the download fails we do not show error messages.

Then why do I see these each time on startup? Do you record somewhere that favicon is not available?


I found the problem, KIO::copy seems to show these messages without KT knowing. I have now used a different KIO method to download the icons, and this doesn't show the error messages.

This doesn't change the fact that the icons aren't downloaded though. So you might want to setup your proxy in the KDE settings, so that the icons can get downloaded.
MoDaX
Registered Member
Posts
241
Karma
0
OS
George wrote:This doesn't change the fact that the icons aren't downloaded though. So you might want to setup your proxy in the KDE settings, so that the icons can get downloaded.

That's not the problem. Icons are not downloaded because they simply do not exist on those sites. It seems that the code does not assume this is possible and will always try to download missing icons each time on startup (failing each time as there is nothing to download). The code which adds search engines does not check if favicon actually exists before adding it to the opensearch xml file.


Bookmarks



Who is online

Registered users: Bing [Bot], Google [Bot], Yahoo [Bot]