Another minor glitch is the fact that "Dont' Download" files appear with 0% complete. I know KTorrent knows how much they are complete, because when I see my stats on the tracker, ktorrent announces it correctly (90% complete, for example).

Thanks for the great work

i23098 wrote:Another minor glitch is the fact that "Dont' Download" files appear with 0% complete. I know KTorrent knows how much they are complete, because when I see my stats on the tracker, ktorrent announces it correctly (90% complete, for example).

Thanks for the great work

Well, that's a bit debatable. 0% of the file has been downloaded, so it's 0% complete. In that sense, it's totally correct. However, you do have 100% of the file that you care about, so in that sense it's incorrect. Ktorrent reports the overall torrent percentage as a percentage of what you told it to download as opposed to the whole torrent, so that would imply that those that aren't downloaded should be listed at 100% rather than 0%, but what the individual files are reporting is technically correct.

Now, personally, I want it to stay the way it is because then it says what percentage of the file I actually have. I might deselect it for some reason and want to reselect it later. I could accidentally deselect it and then think that it's all there because it shows as 100% complete. I could have some other reason to want to temporarily deselect it. In any case, it's useful for it to tell you how much of the file is actually there like it currently does. Having it say 100% when there's really 0% of the file there doesn't coincide with how the rest of the widget works and it doesn't add any useful information.

Personally, I think that the info widget should display the actual percentage of files that are there - just like it does now - because that's what it's there for. Having the overall torrent percentage reflect the percentage of what you actually want is useful and gives you the information that you're looking for, but doing that for each individual file wouldn't really give any additional information. If anything, I'd like to be able to get main window to display the actual percentage of the torrent in addition to the percentage of what you told it to download as opposed to making the info widget changed to display percentages of what you asked for instead of the actual percentages.

Kalessin wrote:0% of the file has been downloaded, so it's 0% complete. In that sense, it's totally correct. However, you do have 100% of the file that you care about, so in that sense it's incorrect.

I don't understand how can be correct Try to deselect a file that you've download... It doesn't show 100%, and it was fully downloaded.

Kalessin wrote:Now, personally, I want it to stay the way it is because then it says what percentage of the file I actually have.

No it doesn't... That is what I'm requesting

Kalessin wrote:Having it say 100% when there's really 0% of the file there doesn't coincide with how the rest of the widget works and it doesn't add any useful information.

I don't understand what you are trying to say I want KTorrent to say 100% if I have 100% of the file. Downloaded by KTorrent or not.

Kalessin wrote:Personally, I think that the info widget should display the actual percentage of files that are there

Me too

Kalessin wrote: - just like it does now -

No, it doesn't If you deselect a file (put as Do Not Download) that you have 100%, it doesn't appear 100%.

If you want, in the Files, there could be the current "% Completed" should be renamed to "% Dowloaded" and a new column "% Completed" that really means the % completed of the file that I have should be added.

i23098 wrote:

Kalessin wrote:0% of the file has been downloaded, so it's 0% complete. In that sense, it's totally correct. However, you do have 100% of the file that you care about, so in that sense it's incorrect.

I don't understand how can be correct Try to deselect a file that you've download... It doesn't show 100%, and it was fully downloaded.

Kalessin wrote:Now, personally, I want it to stay the way it is because then it says what percentage of the file I actually have.

No it doesn't... That is what I'm requesting

Kalessin wrote:Having it say 100% when there's really 0% of the file there doesn't coincide with how the rest of the widget works and it doesn't add any useful information.

I don't understand what you are trying to say I want KTorrent to say 100% if I have 100% of the file. Downloaded by KTorrent or not.

Kalessin wrote:Personally, I think that the info widget should display the actual percentage of files that are there

Me too

Kalessin wrote: - just like it does now -

No, it doesn't If you deselect a file (put as Do Not Download) that you have 100%, it doesn't appear 100%.

If you want, in the Files, there could be the current "% Completed" should be renamed to "% Dowloaded" and a new column "% Completed" that really means the % completed of the file that I have should be added.

Okay. If you've totally downloaded a file with ktorrent (or had ktorrent find it by checking data), then it lists 100%, even if you deselect it. However, if you had a file from a separate source and deselected that file when first importing the torrent, then it probably doesn't say how much you actually have since it will never check unselected files. I've never actually done that, so I didn't think about that (though it looks like you have and that that's what you're complaining about). What I thought you were complaining about was that ktorrent didn't report 100% on files that you didn't have but hadn't selected (the idea being that the download on that file is 100% complete since you have all of it you wanted - it's 100% of 0, but it's still 100%). Apparently, I completely misunderstood what you were saying.

As for it checking files which you haven't selected... I'm not sure if that's a good idea or not. It depends on why you wouldn't select them and what it does when their selected. If ktorrent does something to files which it thinks are missing chunks, then it could be a problem because on checking the unselected files, it would end up altering them - and since you didn't select them, presumably you didn't want them altered. If, on the other hand, it simply checked them and didn't alter them at all, then it shouldn't be a problem. In either case, presumably if you didn't select the files, it was because you didn't want ktorrent to alter them, so whatever ktorrent ends up doing, it shouldn't be altering unselected files.

Of course, you can always have all files selected from the get-go and then deselect them after the torrent has finished checking all of the files. That could be a bit annoying though. Still, maybe checking the files isn't what your average person who deselects files wants. Maybe the a major reason why someone would deselect files that they had would be so that ktorrent wouldn't take the time to check them - particularly with large torrents. I don't know. I find it weird to deselect a file that you already have. The main reason that I deselect files that I have part of is to force ktorrent to download other files in the torrent first. That being the case, I still want ktorrent to have them all selected at the start since otherwise it wouldn't allocate space for them. So, I'm not quite sure what the point of this is.

Regardless, the odd thing about deselecting files and having them tracked in any way is that by deselecting them, you are basically saying that you don't want ktorrent to track them. So, while it probably wouldn't be all that hard to make ktorrent do the check when a torrent is loaded (and it would make the values in the info widget more correct), it kind of goes against the whole idea of deselecting files. Of course, the basic idea of deselecting files is that you don't want them and don't want to waste bandwidth downloading and sharing them, so selecting and deselecting files back and forth isn't really what the basic idea of the functionality in the first place - though it certainly can be useful.

In any case, I'm sure that ktorrent could be altered to check all files when a torrent is loaded, but I'm not sure that it's entirely desirable. And you can still get the basic desired behavior by selecting all of the files at first and then deselecting the ones you want deselected after ktorrent has finished checking the files.