This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Want to commit few enhancement

Tags: None
(comma "," separated)
stalker_by
Registered Member
Posts
4
Karma
0

Want to commit few enhancement

Mon Aug 10, 2009 6:21 pm
I want commit few interface improvements:

Image

1. Torrent status icon moved to torrent name
2. Added progress bar of download status, insted text field
3. ...error in screenshot... :oops:
3.1 If download estimate too long (>30 day) shows infinity sign
4. If download speed < 1 Kb, shows "0.26 Kb/s" instead "260 B/s"
5. If torrent seeding, status colored in blue

How I can commit that?

P.S.

I use lates STABLE release of source


svn co svn://anonsvn.kde.org/home/kde/branches ... /ktorrent/

Last edited by stalker_by on Mon Aug 10, 2009 6:24 pm, edited 1 time in total.
stalker_by
Registered Member
Posts
4
Karma
0

Mon Aug 10, 2009 6:22 pm
WTF, localized version... :evil:

In few hours post screen in English
stoeptegel
Registered Member
Posts
1075
Karma
0

Mon Aug 10, 2009 8:46 pm
Your best bet is that you should wait for George whether he wants this or not. You can also sign up for an kde account, but it is probable wiser for you to wait what George want with this.

EDIT
Btw, thanks for letting me know of the exsistence of ideneb i will love it.
(can all macosX apps be installed on this OS?)
stalker_by
Registered Member
Posts
4
Karma
0

Mon Aug 10, 2009 10:22 pm
Whos George and how I can contact him?

About iDeneb, sorry but I still can`t install it on my PC :(.
stoeptegel
Registered Member
Posts
1075
Karma
0

Mon Aug 10, 2009 11:07 pm
stalker_by wrote:Whos George and how I can contact him?


George is the main programmer, he will read this topic eventually.


About iDeneb, sorry but I still can`t install it on my PC :(.


Why? Is this because of your BIOS?
George
Moderator
Posts
5421
Karma
1

Mon Aug 10, 2009 11:14 pm
I'm busy with the release of 3.2.3 and 3.3beta1 at the moment, send me the patch, will review it as soon as I can (probably tomorrow). You can send it to joris DOT guisson AT gmail DOT com.
sek.tor
Registered Member
Posts
59
Karma
0
OS

Wed Aug 12, 2009 2:58 am
very good job. cool features. please send me sources. xsektorx on gmail

деб-пакеты тоже не помешают, а то ломает. спасибо
George
Moderator
Posts
5421
Karma
1

Thu Aug 13, 2009 7:38 pm
I'm not seeing number 3.1 and 4 in the patch you sent me

There are a few problems with the patch :
- It doesn't compile (pixeldelegate.h should be progressdelegate.h in viewmanager.cpp), but fixed that myself
- ProgressDelegate should be in the kt namespace
- The TRACKER_STOPPED status shouldn't return an error icon seeing that there is no error

The progressbar and the blue color for seeding are OK.

What is the reason behind moving the tracker status icons to the name column ?

Also showing tracker icons is rather pointless, seeing that in trunk support for using multiple trackers at the same time has been added. So there is a very distinct possibility that some trackers work OK and some don't, which results in there being no actual tracker status for a torrent in trunk.

Further more it is unlikely that there will be a 3.2.4 release, so the patch will have to go into trunk.
stalker_by
Registered Member
Posts
4
Karma
0

Fri Aug 14, 2009 9:03 am
Sorry, this my first patch :oops:

> What is the reason behind moving the tracker status icons to the name column ?

When torrent status changes from "non-ok" to "ok" row height changes too, it anger me. And as I think it more demonstrably.

> Also showing tracker icons is rather pointless, seeing that in trunk support for using multiple trackers at the same time has been added. So there is a very distinct possibility that some trackers work OK and some don't, which results in there being no actual tracker status for a torrent in trunk.

But, if torrent status "non-ok" shows warning icon, it mean that we can show OK icon when all really OK, or not?


Bookmarks



Who is online

Registered users: Bing [Bot], Evergrowing, Google [Bot]