Registered Member
|
I want commit few interface improvements:
1. Torrent status icon moved to torrent name 2. Added progress bar of download status, insted text field 3. ...error in screenshot... 3.1 If download estimate too long (>30 day) shows infinity sign 4. If download speed < 1 Kb, shows "0.26 Kb/s" instead "260 B/s" 5. If torrent seeding, status colored in blue How I can commit that? P.S. I use lates STABLE release of source svn co svn://anonsvn.kde.org/home/kde/branches ... /ktorrent/
Last edited by stalker_by on Mon Aug 10, 2009 6:24 pm, edited 1 time in total.
|
Registered Member
|
|
Registered Member
|
Your best bet is that you should wait for George whether he wants this or not. You can also sign up for an kde account, but it is probable wiser for you to wait what George want with this.
EDIT Btw, thanks for letting me know of the exsistence of ideneb i will love it. (can all macosX apps be installed on this OS?) |
Registered Member
|
|
Registered Member
|
|
Moderator
|
|
Registered Member
|
|
Moderator
|
I'm not seeing number 3.1 and 4 in the patch you sent me
There are a few problems with the patch : - It doesn't compile (pixeldelegate.h should be progressdelegate.h in viewmanager.cpp), but fixed that myself - ProgressDelegate should be in the kt namespace - The TRACKER_STOPPED status shouldn't return an error icon seeing that there is no error The progressbar and the blue color for seeding are OK. What is the reason behind moving the tracker status icons to the name column ? Also showing tracker icons is rather pointless, seeing that in trunk support for using multiple trackers at the same time has been added. So there is a very distinct possibility that some trackers work OK and some don't, which results in there being no actual tracker status for a torrent in trunk. Further more it is unlikely that there will be a 3.2.4 release, so the patch will have to go into trunk. |
Registered Member
|
Sorry, this my first patch
> What is the reason behind moving the tracker status icons to the name column ? When torrent status changes from "non-ok" to "ok" row height changes too, it anger me. And as I think it more demonstrably. > Also showing tracker icons is rather pointless, seeing that in trunk support for using multiple trackers at the same time has been added. So there is a very distinct possibility that some trackers work OK and some don't, which results in there being no actual tracker status for a torrent in trunk. But, if torrent status "non-ok" shows warning icon, it mean that we can show OK icon when all really OK, or not? |
Registered users: Bing [Bot], Evergrowing, Google [Bot]