I think it would make alot of sense to move the plugins for UPnP and ZeroConf into libktorrent and to have some checkboxes in Settings->Configure KTorrent->Network to enable/disable those functions. Other applications using libktorrent might want to have access to such functionality. I don't know what to do with the current UPnP tab in the main window since it would be somewhat chaotic to move GUI-stuff into the lib.

Or is it a really bad idea?

jonas wrote:I think it would make alot of sense to move the plugins for UPnP and ZeroConf into libktorrent and to have some checkboxes in Settings->Configure KTorrent->Network to enable/disable those functions. Other applications using libktorrent might want to have access to such functionality. I don't know what to do with the current UPnP tab in the main window since it would be somewhat chaotic to move GUI-stuff into the lib.

Or is it a really bad idea?

UPnP consists of two parts, the plugin and libktupnp. You could move the library to libktorrent/src/upnp and the GUI bit to ktorrent itself, and then add something to the settings to enable or disable it (and only show the widget when it is enabled for example). I would not be opposed to this.

Likewise I have very little objection against moving zeroconf to libktorrent. Though it adds a new dependency on a library.

If you want to do this, I would definitely check if we are compatible with http://bittorrent.org/beps/bep_0026.html, we probably aren't, the plugin hasn't been changed in ages.