I just tried to update my ktorrent install from git, but libktorrent is failing to compile with the following error:

Code: Select all

/usr/include/qt4/QtCore/qhash.h: In member function ‘QHashNode<Key, T>** QHash<Key, T>::findNode(const Key&, uint*) const [with Key = QSharedPointer<bt::PeerConnector>, T = QHashDummyValue]’:
/usr/include/qt4/QtCore/qhash.h:784:   instantiated from ‘int QHash<Key, T>::remove(const Key&) [with Key = QSharedPointer<bt::PeerConnector>, T = QHashDummyValue]’
/usr/include/qt4/QtCore/qset.h:84:   instantiated from ‘bool QSet<T>::remove(const T&) [with T = QSharedPointer<bt::PeerConnector>]’
/home/moose/build/ktorrent-git/libktorrent/src/peer/peermanager.cpp:295:   instantiated from here
/usr/include/qt4/QtCore/qhash.h:875: error: no matching function for call to ‘qHash(const QSharedPointer<bt::PeerConnector>&)’


It happens with the 1.1 and master branches, as well as the v1.1beta1 tag. The machine only really has qt 4.6 available, since trying to install the 4.7 debian packages would remove the rest of kde. The current version of 4.1-dev that I have installed is using 4.6 just fine it seems.

A qHash function must not be defined for QSharedPointer's in Qt 4.6

Is that the only place where the compile fails ? (use make -k so make will continue after a compile error)

Seems thats the only compile failure I can see. It stops before finishing completely, but thats likely linking steps which depend on the file that failed..

Try it now, this revision should fix it:

https://projects.kde.org/projects/extra ... d2cecde9f7

But I don't have Qt 4.6 to test against.

George wrote:Try it now, this revision should fix it:

https://projects.kde.org/projects/extra ... d2cecde9f7

But I don't have Qt 4.6 to test against.

Ok, that at least led me to something that did work. It seems that version check was a little off, I have qt 4.6.3 installed, and checking against 4.6.0 didn't catch my Qt version (Maybe use '< QT_VERSION_CHECK(4.7.0)' ?). Also, it errored out in peermanager.cpp and peerconnector.cpp, so I added that #if block to peerconnector.h, and removed it from peermanager.cpp, and it compiled.

Tomasu wrote:The machine only really has qt 4.6 available, since trying to install the 4.7 debian packages would remove the rest of kde.

That should not be happening. Message me privately if you want help on this.