If I go to Advanced -> Speed limits and then enter a max upload speeds, say 200 k and then hit ok, ktorrent is completely ignoring that amount and using all my bandwidth. If I set a global limit for all torrents that limit is respected, but individual ones are not.

I can only see a problem with the individual download speed limit, individual upload limit is working here.

I don't know what to say then. It is happening to me and I have been using ktorrent since 2.x. I am limiting this one right now to 100 k and it is completeley ignoring that rule and uploading at 500 k. I think I am going to downgrade back to 4.13, I can't even tell how many torrents I have going in this new one since the tabs are gone. I'll wait for 4.2.x.

I get the same behaviour as Erik.
On the "Speed Limits" dialogue box, changing either the "Upload Limit" or "Assured Upload Speed" has no effect on the actual upload speed of the selected torrent.
However, changing the global limit on "Configure", "Network", "Ports & Limits", "Maximum upload speed" has immediate effect.

I couldn't reproduce it originally and certainly not after my fix for the individual download speed limit.

Maybe you should give latest from the master branch a try.

I also found that upload speed limits were being ignored for individual torrents in ktorrent 4.2. Because the tabs were removed from the UI in version 4.2, I went back to 4.1.3, and speed limits are working fine.

Eaxctly the same problem here.. individual upload speed limits are totally ignored.

..also going to try going back to 4.1.3, really not enjoying 4.2 at all.

The enclosed patch gets ktorrent 4.1.3 building with the latest version of KDE (i.e. what I have under Fedora Core 17), for those of you that can reproduce the per-torrent upload speed-limit problem (as I can).

I just copied a little bit of code from the ktorrent 4.2 source code.

Code: Select all

--- ktorrent-4.1.3/plasma/applet/applet.cpp   2011-11-22 10:23:25.000000000 -0700
+++ ktorrent-4.1.3-sb/plasma/applet/applet.cpp   2013-01-06 13:13:07.021103763 -0700
@@ -21,6 +21,9 @@
 #include "applet.h"
 #include <QFile>
 #include <QGraphicsLinearLayout>
+#include <QDBusConnection>
+#include <QDBusConnectionInterface>
+#include <QDBusMessage>
 #include <KConfigDialog>
 #include <KLocale>
 #include <KRun>
@@ -340,19 +343,37 @@
 
    void Applet::iconClicked()
    {
-      TaskManager::TaskDict tasks = TaskManager::TaskManager::self()->tasks();
-      for (TaskManager::TaskDict::iterator i = tasks.begin();i != tasks.end();i ++)
+      QDBusConnection session_bus = QDBusConnection::sessionBus();
+      QDBusConnectionInterface* dbus_service = session_bus.interface();
+      if (!session_bus.isConnected() || !dbus_service || !dbus_service->isServiceRegistered("org.ktorrent.ktorrent"))
+      {
+         // can't find the window, try launching it
+         KUrl::List empty;
+         KRun::run("ktorrent", empty, 0);
+      }
+      else
       {
-         if (i.value()->className() == "ktorrent")
-         {
-            KWindowSystem::activateWindow(i.key());
-            return;
-         }
+         QDBusMessage msg = QDBusMessage::createMethodCall("org.ktorrent.ktorrent", "/ktorrent/MainWindow_1", "org.kde.KMainWindow", "winId");
+         QDBusPendingCall call = session_bus.asyncCall(msg, 5000);
+         QDBusPendingCallWatcher* watcher = new QDBusPendingCallWatcher(call ,this);
+         connect(watcher, SIGNAL(finished(QDBusPendingCallWatcher*)), this, SLOT(dbusCallFinished(QDBusPendingCallWatcher*)));
       }
-
-      // can't find the window, try launching it
-      KUrl::List empty;
-      KRun::run("ktorrent", empty, 0);
+   }
+   
+   void Applet::dbusCallFinished(QDBusPendingCallWatcher* self)
+   {
+      if (self->isError())
+      {
+         // call failed, try launching it
+         KUrl::List empty;
+         KRun::run("ktorrent", empty, 0);
+      }
+      else
+      {
+         QDBusPendingReply<qlonglong> reply = *self;
+         KWindowSystem::activateWindow(reply.value());      
+      }
+      self->deleteLater();
    }
 
    void Applet::clearData()
--- ktorrent-4.1.3/plasma/applet/applet.h   2011-11-22 10:23:25.000000000 -0700
+++ ktorrent-4.1.3-sb/plasma/applet/applet.h   2013-01-06 13:14:50.611291345 -0700
@@ -27,6 +27,7 @@
 #include "fadingnavigationwidget.h"
 
 class QGraphicsLinearLayout;
+class QDBusPendingCallWatcher;
 
 namespace Plasma
 {
@@ -68,6 +69,7 @@
       void iconClicked();
       void selectPrev();
       void selectNext();
+      void dbusCallFinished(QDBusPendingCallWatcher* self);
       
    private:
       void updateTorrentCombo();