Hi folks. While trying out the Metadata editor, I came across these bug reports:

https://bugs.kde.org/show_bug.cgi?id=313203
https://bugs.kde.org/show_bug.cgi?id=309254

I put together a patch to fix this and am wondering if someone could take a look and verify that it works on their system and that the fields it is writing is now correct.

Cheers,
Alan

If you have created a patch to address these issues I would suggest uploading it on Reviewboard (reviewboard.kde.org) with the appropriate groups / people set as reviewers. If you're unsure on whom to add, feel free to ask here.

The best people to review this are the developers of the code i'm afraid.

Hmm. I tried to create a New Review Request on reviewboard, but it does not recognize my diff as a diff ...

The patch is attached to https://bugs.kde.org/show_bug.cgi?id=313203

How was the patch generated? Can you try recreating it using git diff (which Reviewboard should recognise)?

bcooksley wrote: git diff

Done, that works. Now all I need is more people testing it to make sure it doesn't mess anything up and that it has the desired effect.

For those of you running (k)ubuntu, I have packaged a version of kipi-plugins with my patch. It's available on my ppa: https://launchpad.net/~alan-pater/+archive/dwc

There is a test image available on the bug report: https://bugs.kde.org/show_bug.cgi?id=313203
Better would be if someone has a lot of exising image tagged with these fields, and tested it on them. Please make backup copies, just in case!

The relevant fields are in > Edit all Metadata > Edit XMP > Credits.