• src/kthumb.cpp
  

  Code: Select all

      return image.rgbSwapped();
    if (!image.isNull()) {
        if (ow > (2 * displayWidth)) {
            // there was a scaling problem, do it manually
            image = image.scaled(displayWidth, height).rgbSwapped();
        } else {
            image = image.scaled(displayWidth, height, Qt::IgnoreAspectRatio).rgbSwapped();
        }
        p.fill(QColor(100, 100, 100, 70));
        QPainter painter(&p);
        painter.drawImage(p.rect(), image);
        painter.end();
    } else
        p.fill(QColor(Qt::red).rgb());
    return p;

• src/mltdevicecapture.cpp
  

  Code: Select all

  if (!m_mltConsumer->is_stopped()) m_mltConsumer->stop();
    kDebug()<<"// STOP 6";
    delete m_mltConsumer;
    delete m_mltProducer;
   
    m_mltProducer = NULL;
    m_mltConsumer = NULL;
    //delete m_mltConsumer;
    return; // BLOCKS THE CODE BELOW
    /*if (m_showFrameEvent) delete m_showFrameEvent;
    m_showFrameEvent = NULL;
    if (m_consumerThreadStartedEvent) delete m_consumerThreadStartedEvent;
    m_consumerThreadStartedEvent = NULL;
    if (m_consumerThreadStoppedEvent) delete m_consumerThreadStoppedEvent;
    m_consumerThreadStoppedEvent = NULL;*/
   

    if (m_mltProducer) {
        QList <Mlt::Producer *> prods;
        Mlt::Service service(m_mltProducer->parent().get_service());

  
  As we can see the whole block code will never be executed. There is a return statement which blocks the code below it.
• Memory leak src/lib/external/kiss_fft/tools/kiss_fastfir.c
  

  Code: Select all

   kffsamp_t * h;
    // ...
    h = (kffsamp_t*)malloc(sizeof(kffsamp_t)*nh);
    // ...
    return 0;

  
  Forget to free the memory?
  
• src/lib/external/kiss_fft/tools/psdpng.c
  Memory leak with vals and row_pointers variables.

[src/renderer.h:58] -> [src/definitions.h:83]: (style) Variable 'Playlist' hides enumerator with same name
[src/kthumb.cpp:237]: (style) Statements following return, break, continue, goto or throw will never be executed
[src/lib/external/kiss_fft/tools/kiss_fastfir.c:81]: (style) Checking if unsigned variable 'nfft' is less than zero.
[src/lib/external/kiss_fft/tools/kiss_fastfir.c:467]: (error) Memory leak: h
[src/lib/external/kiss_fft/tools/kiss_fastfir.c:288]: (style) Checking if unsigned variable 'nread' is less than zero.
[src/lib/external/kiss_fft/tools/kiss_fastfir.c]: (information) Interrupted checking because of too many #ifdef configurations.
[src/lib/external/kiss_fft/tools/psdpng.c:173]: (error) Common realloc mistake: 'vals' nulled but not freed upon failure
[src/lib/external/kiss_fft/tools/psdpng.c:210]: (error) Common realloc mistake: 'row_pointers' nulled but not freed upon failure
[src/mltdevicecapture.cpp:218]: (style) Statements following return, break, continue, goto or throw will never be executed
[src/mltdevicecapture.cpp:535]: (style) Statements following return, break, continue, goto or throw will never be executed
[src/scopes/audioscopes/spectrogram.cpp:393]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/scopes/audioscopes/spectrogram.cpp:433]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/v4l/v4lcapture.cpp:67]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses
[src/widgets/kis_curve_widget.cpp:457]: (style) Clarify calculation precedence for - and ?