I'd like to remove the blue from the screen in the laptop, make it lighter grey or something and make the lines in the two rightmost thicker to get them to match the the three left ones a smidge more. Other than all thumbs upwards from me!

notmart wrote:You are thinking them more as generic icons in the desktop theme or info the plasma theme?
anyways good job, if you want to replace them is fine

These would be plasma theme icons since I assumed it might be useful if they benefitted the CSS magic for the dark version like other plasma theme icons. I had them as elements in a new icons/launcher.svg file. That ok?

jensreuterberg wrote:I'd like to remove the blue from the screen in the laptop, make it lighter grey or something and make the lines in the two rightmost thicker to get them to match the the three left ones a smidge more. Other than all thumbs upwards from me!

Perfect, thanks Jens. I was sorta going for a little touch of color to keep things from getting too drab but we can probably look for that opportunity elsewhere. I'll update this weekend and submit a review request.

alake wrote:

notmart wrote:You are thinking them more as generic icons in the desktop theme or info the plasma theme?
anyways good job, if you want to replace them is fine

These would be plasma theme icons since I assumed it might be useful if they benefitted the CSS magic for the dark version like other plasma theme icons. I had them as elements in a new icons/launcher.svg file. That ok?

The names of the files are supposed to overlap standard oxygen names, look at my last commits there, eventually replacing the files.
As for the computer icon, are needed both a desktop and a laptop, (and then would try to pick up the correct one depending where is running)

Well couldn't the blue use whatever highlight is set in the color theme? I mean that way it would shift based on the users color theme AND we could include a dab of color in all five so the computer doesn't stick out too much?

Looking great! One thought, the star (bookmark) icon currently looks very much like the red star associated with communism, which is probably something we want to avoid. Maybe make it hollow and/or more rounded?

Also, are the icons in the Kickoff tabbar suppose to look like action icons or app/other icons?

jensreuterberg wrote:Well couldn't the blue use whatever highlight is set in the color theme? I mean that way it would shift based on the users color theme AND we could include a dab of color in all five so the computer doesn't stick out too much?

yes, the highlight color can be taken from the stylesheet

Hans wrote:Looking great! One thought, the star (bookmark) icon currently looks very much like the red star associated with communism, which is probably something we want to avoid. Maybe make it hollow and/or more rounded?

or, the system icons replaced the star with an actual bookmark (the one i used the first version i posted yesterday)
they should probably be the same, either all be a star or all be a physical bookmark

Totally agreed on changing the star to a bookmark more like Marco did his. I'll try to figure out a design that uses the stylesheet highlight sensibly. I'm not sure that accent color needs to appear in each and every icon, but I agree that, if it's used at all here, it night need to be a bit more balanced across the layout than it currently is. Might just stick with the monochrome if I can't use the highlight in a compelling way.

I'm also eager to explore using the secondary colors of the color set for a touch more (restrained) expressiveness in the design.

The first problem I have with the 'bookmark' is that the favourites are not bookmarks. They do not represent a place that you want to mark. They are favourite applications.

The second is that I really don't think a lot of people will recognize that specific shape as a bookmark.

In the browser, it kinda works - because it remembers a specific place (site or a page) that you visited.

Testing the Project Neon 5 iso, I noticed that the dialog button icons (on the OK/Apply/Cancel buttons) look really alien within our new icon theme:
.
Can we replace them with ones that match our theme better?

colomar wrote:Testing the Project Neon 5 iso, I noticed that the dialog button icons (on the OK/Apply/Cancel buttons) look really alien within our new icon theme:
.
Can we replace them with ones that match our theme better?

uuh, weird, those are gtk icons O.o

that's what it's supposed to come up:

Hm. So do I have to file a bug? And if so: Where?

colomar wrote:Hm. So do I have to file a bug? And if so: Where?

probably is QtCurve (or even qt5 icon::fromTheme not working correctly even tough is strange because all the other icons are correct)
in the neon iso of last week btw seems to happen for dolphin but not for kwrite, and are both Qt5 apps, quite weird

alake wrote:Haha! It looks like we were of the same mind Marco. I just finished up working on those icons this morning. Even had the patch for kickoff ready and everything.

In any case here are the ones I did in case it's useful. No heartburn either way.

What's the status of this?
turns out, the current icon has problems in localization (aand now i remember why letters in icons -> bad idea )
https://bugs.kde.org/show_bug.cgi?id=336351