notmart wrote:This is the current status of the branch:
https://www.youtube.com/watch?v=o2bArmyI9qY

Big thumbs up from me Marco! Looks great!!

One minor suggestion is to perhaps use consistent wording. If the action is "remove" then the confirmation should be "The [widget] was removed" not "The [widget] was deleted".

Really nicely done though.

Another problem I have just though of with the notification method is that if the notification is not dismissed, it will sit in the notifications list. I suppose then after a couple of minutes, or however long it take for the plasma to officially deleted, the undo button will become useless, leading to a broken experience for those trying to get it back. I have the same problem with Amarok reverting audio streams and posting notifications, if you don't hit the revert button pretty much straight away it becomes useless, and then just clogs up your notification stream.

davidwright wrote:Another problem I have just though of with the notification method is that if the notification is not dismissed, it will sit in the notifications list. I suppose then after a couple of minutes, or however long it take for the plasma to officially deleted, the undo button will become useless, leading to a broken experience for those trying to get it back. I have the same problem with Amarok reverting audio streams and posting notifications, if you don't hit the revert button pretty much straight away it becomes useless, and then just clogs up your notification stream.

It shyould live for a couple of minutes (and the undo button should work for that time)
then after a couple of minutes, the notification should go away (together the applet)
if for some reason it doesn't, it's a bug of the notification applet.

What if you remove two plasmoids in a row? Would you get two notifications? If yes, then the "undo" button in the first notification won't work. If no, how long do you consider for "not removed in a row"? Waiting for the previous one to be removed from the list is definitely too long. I would say that as soon as the notification disappear, a new one should be raised. But then, the previous one is in the list, with and the "undo" button wouldn't work.