Registered Member
|
Regarding the metrics I've played around with them (today a bit more) and created a few screenshots with the "oxygen-demo" tool. You can see them in my Plasma / Oxygen 5 topic (both Oxygen and Breeze, item 2).
|
Registered Member
|
Thanks for those great suggestions sakayo! I'll review each of them with Hugo and see which changes comply with the HIG and make the most sense for the style. Thanks again! |
Registered Member
|
Here's a quick summary on this effort after work on this over the last few days (primarily work by Hugo who has been freaking brilliant):
- List and table header margins have been reduced - List and table item margins have been reduced - MenuBar margin heights have been reduced - Menu item margins have been reduced - Spacing between checkbox/radio button and its label has been reduced The primary purpose of these reductions was to resolve some visual inconsistencies while preserving the design goals of the style. A side-effect is that more data is shown in tables, lists and menus than before. These are the changes that will ship with Plasma 5.2. I don't have screenshots right now, but if you compile it from the breeze master repo feel free to share it here. We have also agreed to eventually create a separate Breeze Compact style to accommodate the tastes of those who prefer much more compactness in the layout without trying to do everything in one style to suit everyone's preferences and failing miserably. Thanks for everyone's help and patience in achieving this result: a more polished and refined Breeze widget style! |
Registered Member
|
Thank you both very much!
I've taken the Breeze metric commits of the last days (2ff1209, b4872a3, af0e034, f1fee30) and compiled default 5.1.2 with those on top to have screenshots of them here (named 002 in case further Git commits are made). You can compare them with the images in my topic (most changes are visible in the button and list screenshots). Input widgets: Breeze 002 Tab widgets: Breeze 002 Buttons: Breeze 002 Lists: Breeze 002 PS: May I ask if anyone of you involved in style development has seen my questions in the linked topic above (items 3, 4, 5, 9 and 12)? What are the plans regarding Oxygen? Thanks again! |
Registered Member
|
Would there be any possibility to make some of these spacing options available in a configuration menu? Maybe not exact sizes, but small medium etc.
|
Registered Member
|
In my oppinion, letting the metrics go in options is basically admitting failure of design. There are literally more than 50 different values used for these metrics, and if you want an harmonious, well balanced style (be it spacy or compact), you need to change them (pretty much all of them) in a coordinate manner. As such, you cannot put one or two in config, and leave the others hidden. You cannot also put the 50 of them in the config. Admittingly, you could provide several sets of metrics values (spaced, packed, intermediate, etc), but that is pretty much equivalent to what Andrew and I came up with when suggesting a Breeze-Compact theme, as an alternative to current Breeze. It also has the advantage of preserving the 'branding' of both themes (in their respective name), which an option would not do. |
Registered Member
|
There are too many things in there ! (which is nice: you did a torough review, but then, hard to answer) Some are bugs (and should be posted as such), and some are design choices. For instance: - missing shadows around menus and tooltips with oxygen: this is a bug, which I cannot reproduce here - 'new', shadowless, inactive tab design: design choice. In fact this was already available (on option) for oxygen @ kde4, and is now the only option, because they were too many complains with the old default style, about inactive tabs to be hard to distinguish from active one. Won't happen any more with this design. - new oxygen metrics: this was a long time (several years) request, back in the kde4 times, about oxygen being too packed. It could not be fixed at that time because of the code being bloated. While writting breeze I ended up with a cleaner code than with oxygen, so I backported the cleanup, and could (finally) put more 'air' into 'oxygen'. This is very unlikely to change any time soon, notably because oxygen is not the default theme anymore, and, being maintained by the same guy that maintains breeze, it gets lower priority. Personnaly, I like it a lot the way it is now (better than the kde4 version), and since in any case one cannot make everybody (basically, one, as a dev, cannot win, in matters of metrics), I'd be inclined to leave it like this. Regards, Hugo |
Registered Member
|
@Hugo
In that case, thanks for making Oxygen more maintainable! I have been using the Qt4 version of Breeze on Plasma 4 for a while now but I'm sure plenty will use Oxygen for years to come. Though, if you don't mind me asking: Who thought of Oxygen and who originally coded the Qt4 widget theme? Was it Nuno and you? |
Registered Member
|
Guys just imagine this on 12inch laptop of mine
in comparison to my current KDE 4 I don't even know why the layout of the preview was changed but it's probably better to left it for a different discussion. |
Registered Member
|
Thanks for the feedback. Unfortunately, it might be a bit off-topic since the Breeze widget style is not responsible for the size of that tooltip preview. |
Registered users: Bing [Bot], daret, Google [Bot], Sogou [Bot]