I only want to know if for a compact breeze theme the breeze icons also should remove the 2 px margin.

There should be no margins in any variant, that's just silly waste of bandwidth.
The margins and paddings are to be provided by the container (qstyle, css, qml, whatever), *never* the image.

luebking wrote:

I only want to know if for a compact breeze theme the breeze icons also should remove the 2 px margin.

There should be no margins in any variant, that's just silly waste of bandwidth.
The margins and paddings are to be provided by the container (qstyle, css, qml, whatever), *never* the image.

+1
obviously

luebking wrote:

I only want to know if for a compact breeze theme the breeze icons also should remove the 2 px margin.

There should be no margins in any variant, that's just silly waste of bandwidth.
The margins and paddings are to be provided by the container (qstyle, css, qml, whatever), *never* the image.

As I have mentioned here: viewtopic.php?f=285&t=123754#p324555

The margin is there to keep the aspect ratio and height of the objects that conform the icon. Which, by the way, doesn't affect the padding of the container/widget/however it's called . The image is still loaded at the size it's required.

That's not what I meant.
Of course the "dumb" icon cannot impact the algorithms of the container padding.
Also a "margin" that is related to the shape is no actual margin but, well, the shape

Keeping the height aligned is on the edge.
Actually what you do is to redefine 32x32 to 32x20, ie. icons are in general no squares but golden mean (or similar) bounded.
That's however still no internal margin.

What I meant was that the icons shall not bring paddings/margins to somehow enforce a button shape etc. to stay away by a minimum distance.
That's the only margin I object.

Just to close the loop on this thread, the list views now use less vertical space.

https://bugs.kde.org/show_bug.cgi?id=340999