in any case, yes don't hesitate to send me the code by email, I can have a look/reuse
(also: if you have questions about how configuration works I can give a hand too)

First, sorry for the jumbled reply order; I'm paying catchup.

hugo.pereira@free.fr wrote:Some more comments (again, for discussion, and for my own education):

by "the divider has been adjusted", you mean the slightly darker line above the blue one. Is that correct ? (you can notice it on the screenshot). If yes, although it look nice, I do not think it fits well with the current breeze theme design, as such shadows have been avoided so far, for the sake of flatness. (also: all shadows are bottom-right oriented, -meaning light comming from top left, whereas this one is at the top).
This IMHO matches much better the design choices that were made for oxygen (see e.g. tab bars), which, unless I'm mistaken, is also the style you use on the screenshot (correct?)

Sorry for the late reply on this one; I added the contrast line, and doubled the thickness of the line. I remember in a conversation a while ago we were talking about decos and widgets, and even though the theme is flatter it was mentioned that it's not *against* depth or detail; everyone just wants to be much, much more conservative and really consider the necessity of every draw. Where Oxygen started quite heavy and gradually got cleaner, we want to start clean and carefully introduce meaningful details - at least that was my interpretation of the conversation.

hugo.pereira@free.fr wrote:The way I've dealt with scales so far (and various button sizes) in Breeze was using QPainter::setWindow. You can then specify any arbitrary canvas size to do you're painting (even 1024x1024 if you feel like to), use either float or ints, and then things are rescaled (automagically) to the initial (=real) size, by Qt.
Should be aware though that lines that fall on the grid in the 'viewport' coordinate (the one from setWindow) might not in the real window so that you can get anti-aliasing artifacts).

I saw that you did that, when I was first putting together the code I scratched my head for a few minutes before I realised what it was doing. I gotta say hands-down Qt has some pretty wicked draw functionality. Your code has been fantastic for me to learn from.

hugo.pereira@free.fr wrote:in any case, yes don't hesitate to send me the code by email, I can have a look/reuse
(also: if you have questions about how configuration works I can give a hand too)

Fantastic; I'll send you the code after I do some extra cleanup tonight, and I'll see how deep I can get into adding a dummy configuration option or two without running screaming for help.

Kver wrote:First, sorry for the jumbled reply order; I'm paying catchup.
Sorry for the late reply on this one; I added the contrast line, and doubled the thickness of the line. I remember in a conversation a while ago we were talking about decos and widgets, and even though the theme is flatter it was mentioned that it's not *against* depth or detail; everyone just wants to be much, much more conservative and really consider the necessity of every draw. Where Oxygen started quite heavy and gradually got cleaner, we want to start clean and carefully introduce meaningful details - at least that was my interpretation of the conversation.

Yep, right. I guess I am conservative indeed. (comes with age )
Just throwing impressions and (counter) arguments here, for discussion only. (I rather code than design anyway).
More oppinions will be needed to decide what's detail and what's overkill.
Keep up the good work and investigations !

Another screenshot, with updated pin button ( = on all desktop), to match the thinner lines.
It is inspired from Kver's design (in the sense that it is rotated by 45°), but I tried to make it occupy more space inside the circle.
Again, comments, welcome (as a comparison to _current_ breeze decoration, not to chroma)

I like the rotated pin. I like the whole concept. only the exit icon is for me to flashy instead of the other icons. something like kven was thinking without color maybe?

andreas_k wrote:I like the rotated pin. I like the whole concept. only the exit icon is for me to flashy instead of the other icons. something like kven was thinking without color maybe?

That certainly looks good. The only issue I see with a surrounding circle as opposed to a surrounding disc, is that it forces you to make the glyph smaller, for the same button size, due to the extra needed space between the disc and the circle.

And then also there always was the argument that the close button *should* look flashy, so that people think twice before closing windows
How flashy is enough exactly is a matter of taste I guess.
I'll give a shot to your suggestion.

hugo.pereira@free.fr wrote:

andreas_k wrote:I like the rotated pin. I like the whole concept. only the exit icon is for me to flashy instead of the other icons. something like kven was thinking without color maybe?

That certainly looks good. The only issue I see with a surrounding circle as opposed to a surrounding disc, is that it forces you to make the glyph smaller, for the same button size, due to the extra needed space between the disc and the circle.

And then also there always was the argument that the close button *should* look flashy, so that people think twice before closing windows
How flashy is enough exactly is a matter of taste I guess.
I'll give a shot to your suggestion.

mmm. Then also, if I follow the icon theme, a simple 1pixel wide red cross should also be enough. (that's what you get on "close" buttons for dialogs)

hugo.pereira@free.fr wrote:mmm. Then also, if I follow the icon theme, a simple 1pixel wide red cross should also be enough. (that's what you get on "close" buttons for dialogs)

Yes everything is 1px in this icon size range.

Alright, so here's my personal 'Chroma' repo; Note to whoever builds/installs it: IT WILL REPLACE BREEZE.

I'm having a busy week, so I just don't have time to do all the namey stuff yet, but I don't want eternity to pass before the code is wild. :/

https://github.com/Ken-Vermette/breeze-chroma-windeco

Hi kver,
Just gave a shot at your repository. Couple of remarks:
on the compilation side, there are stuff missing from the CMakeLists to have it compile standalone (that is: outside of the master breeze directory), like ECM. I can send you the needed changes if you need.
also, there are too many files in the repository, that should be generated at compile time (moc_xxx.cpp or moc_xxx.h, and ui_xxx.h)

on the look side: the decoration looks good (much improvement with respect to the previous incarnation), though I still find it too distracting (with all due respect ). Wathever happens to this decoration being the default,
One thing that is missing with respect to current breeze is some feedback on button press, on top of the mouse-over animation.

also, please check https://bugs.kde.org/show_bug.cgi?id=344552 and breezedecoration code. There have been some issues when rendering title bar capion with some fonts, when using the old code (that you have), and which have been fixed since then.

Best regards,

Hugo

hugo.pereira@free.fr wrote:Hi kver,
Just gave a shot at your repository. Couple of remarks:
on the compilation side, there are stuff missing from the CMakeLists to have it compile standalone (that is: outside of the master breeze directory), like ECM. I can send you the needed changes if you need.
also, there are too many files in the repository, that should be generated at compile time (moc_xxx.cpp or moc_xxx.h, and ui_xxx.h)

on the look side: the decoration looks good (much improvement with respect to the previous incarnation), though I still find it too distracting (with all due respect ). Wathever happens to this decoration being the default,
One thing that is missing with respect to current breeze is some feedback on button press, on top of the mouse-over animation.

also, please check https://bugs.kde.org/show_bug.cgi?id=344552 and breezedecoration code. There have been some issues when rendering title bar capion with some fonts, when using the old code (that you have), and which have been fixed since then.

Best regards,

Hugo

On the standalone compilation changes...
YOU WOULD BE MY SAVIOUR.

I've actually been fighting with this all day today, I updated my development machine and I guess it killed some of the black-magic-voodoo the real hackers did during the sprint (Many credits to David Edmonton for getting me this far!); I'm assuming the update probably messed with either the CMAKE Modules, like yousaid - or at least the way mine were set up / configured.

I was hoping to clean up my repo, but without it compiling I just didn't want to mess with it. I knew I could get rid of anything with MOC in the name, but not really anything else. Rock meet hard place. I've been fighting with system stuff which I frankly don't know yet, and if there's some source-changes that will bypass all that I would be eternally grateful. I literally haven't slept today because of this. So, yeah, incredibly ludicrously appreciated if you would be willing to do that.

On Chroma being default, I don't think that's even going to be a thought for quite some time; I've settled on this being an experimental branch, and it actually relieves me a bit with the idea that we don't need to be nearly as conservative with the ideas in it. If the odd good idea comes out and we wanna back-port it: awesome. For now, it's our toy to experiment with.

andreas_k wrote:

hugo.pereira@free.fr wrote:mmm. Then also, if I follow the icon theme, a simple 1pixel wide red cross should also be enough. (that's what you get on "close" buttons for dialogs)

Yes everything is 1px in this icon size range.

Hi Andreas,
latest experimentation:
(that's pretty much the simplest you can get

I'd then use the red on mouse-over only, which makes it explicit enough (I think), that the button is dangerous:



Opinions ?
I'm using it now, and I find it very slick.

hugo.pereira@free.fr wrote:

andreas_k wrote:

hugo.pereira@free.fr wrote:mmm. Then also, if I follow the icon theme, a simple 1pixel wide red cross should also be enough. (that's what you get on "close" buttons for dialogs)

Yes everything is 1px in this icon size range.

Opinions ?
I'm using it now, and I find it very slick.

As a side note: I also tried using the red cross, but felt this too is too distracting (in fact, even more than the original white disk)

Hi Hugo,

sorry for the delay. Looks simple and straigt forward. the mouse over is, I don't now, I only can say not finished.

standard icons
- are realy realy nice. well done.
mouse over
- I know we have to use the red like (https://github.com/NitruxSA/plasma-next ... -in-Breeze)
- white x
- Is animation possible like a beated heart, like you want to destroy
- Is it possible to change the color of the full window decoration or the blue line so on mouse over the window decoration will be red. or the blue line go to red