This forum has been archived. All content is frozen. Please use KDE Discuss instead.

GIT access for doing commits

Tags: None
(comma "," separated)
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS

GIT access for doing commits

Mon Jul 28, 2014 4:02 am
I have a couple little commits with labeling fields things. What is the best way to potentially add this? Should I send a patch. I am working in a branch right now. I currently don't have commit access for the Krita repo. let me know! :)

thanks.
Ahmed.AbouElhamayed
Registered Member
Posts
5
Karma
0

Re: GIT access for doing commits

Mon Jul 28, 2014 5:48 am
I believe you should submit it for review:

https://git.reviewboard.kde.org/r/new/
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: GIT access for doing commits

Mon Jul 28, 2014 7:50 am
scottpetrovic wrote:I have a couple little commits with labeling fields things. What is the best way to potentially add this? Should I send a patch. I am working in a branch right now. I currently don't have commit access for the Krita repo. let me know! :)

thanks.


The first step is to add a review request on git.reviewboard.kde.org (for the calligra group). We have a sort of informal rule that after three reviewed patches, it's time to get your KDE account upgraded to developer -- https://techbase.kde.org/Contribute/Get ... or_Account. You can use me as your reference.
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS

Re: GIT access for doing commits

Mon Jul 28, 2014 1:02 pm
ok. Thanks. I will go that route. Like boud stated in bugzilla, it would probably be a good idea to put that on the site (the new one) :)
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: GIT access for doing commits

Mon Jul 28, 2014 1:09 pm
I did that this morning :-)
User avatar
scottpetrovic
Registered Member
Posts
520
Karma
4
OS

Re: GIT access for doing commits

Tue Jul 29, 2014 1:51 am
great. I just sent a little diff with mostly just some small .ui changes.

For a small little project to get better with the code, I kind of want to modify the layers docker a bit and condense it. I will come up with a mockup idea and post it on the forum. I guess that is the best route to getting feedack with UI changes. I have larger plans, but I might be over my head with what I am thinking.

Let me know if there is anything else with the new site that needs changing or updated. I am pretty much done with it at this point. We can roll it out whenever. I don't know if you want to 'unveil' it at a more strategic point in time. I am ok with whatever.
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: GIT access for doing commits

Tue Jul 29, 2014 6:24 am
I would like to switch as soon as possible!

For the layer docker, the width of the layer docker is determined by the representation of the layer, not the buttons. That code is in KoDocumentSectionDelegate.cpp, in libs/main.
User avatar
bcooksley
Administrator
Posts
19765
Karma
87
OS

Re: GIT access for doing commits

Thu Jul 31, 2014 9:22 am
In regards to a developer account - Scott already has one, as he needed one in order to be able to store the website theme in the repository at kde:websites/krita-org-theme.


KDE Sysadmin
[img]content/bcooksley_sig.png[/img]
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: GIT access for doing commits

Thu Jul 31, 2014 9:28 am
Ah, cool :-) Still, it's good for C++ patches to go through review first!


Bookmarks



Who is online

Registered users: Bing [Bot], claydoh, Evergrowing, Google [Bot], rblackwell