I just submitted my first minor patch to Krita's Comics Manager plug-in, and have a questions.

Do you prefer small patches where each one addresses a single issue or bug, like the one I just submitted, or should I combine multiple fixes into one patch?

And did I fill out everything correctly? Or was there something I missed that I should have done differently?

You can find my patch here https://phabricator.kde.org/D10284

ragnarb wrote:I just submitted my first minor patch to Krita's Comics Manager plug-in, and have a questions.

Do you prefer small patches where each one addresses a single issue or bug, like the one I just submitted, or should I combine multiple fixes into one patch?

And did I fill out everything correctly? Or was there something I missed that I should have done differently?

You can find my patch here https://phabricator.kde.org/D10284

It depends. If the small patches start depending on one another and are small patches it is best to make one big patch because otherwise these are virtually unreviewable(because we end up having to do an extra administration to figure out in which order patches go. We're still human at the end).

Things were filled out mostly correctly, though you didn't fill in a reviewer, which in our case should be something like "Krita" or the maintainer of that section of the code.

Thanks. That make sense. I'll stick to small patches for self contained fixes, and make bigger patches if there are multiple fixes that depend on each other.

I'll remember to add a reviewer next time around. woltherav picked up on the patch, and he's the one that wrote the Comics Manager, so it should be in good hands.