This forum has been archived. All content is frozen. Please use KDE Discuss instead.

Color Picker Improvements

Tags: None
(comma "," separated)
gpedrycz
Registered Member
Posts
2
Karma
0

Color Picker Improvements

Fri Jun 01, 2018 2:41 pm
Hey everyone !

I love krita ! I worked as freelance illustrator since last 8 years and finally i found replacement for PS . I had only one question ... I worked with tones of layers ( dust , light beens ) etc and when i do that i miss on Color Picker option in krita i mean to pick color not from all layers or from only currently layer but from "currently and BELLOW) You an imagine how useful it is when you work with bigger files with tones of layers etc I am more than sure that is pice of cake for developer to bring that kind of addition . Can i have hoppe to get that kind of feature in near future ?
User avatar
Deevad
Registered Member
Posts
451
Karma
1
OS

Re: Color Picker Improvements

Fri Jun 01, 2018 3:43 pm
Interesting feature request. But how to handle the user interface?

As you saw, right now the behavior of the color picker while using the FreehandPaintTool has no setup at all.
It mean you can access to two sub-mode by keyboard shortcut only:
1. Ctrl+click to color-pick the pixel color of all layers (the full image projection)
2. Ctrl+Alt+click to select the color only on the active selected layer.

Adding a new third behavior to the list would require a new set of key pressed and a new cursor icon. For the cursor icon, it is not a problem. A new default shortcut key is a harder topic; a lot shortcuts are already in use. Especially the modifiers and to change an existing one, you'll probably need to get a consensus with other user about it.
But adding the feature this way would be the easiest way by far. What would you propose as default keyboard shortcut?

An alternative and interesting way to add a new behavior could be to add an option.
We can think of keeping only two shortcut as above, and get:
1. First: Ctrl+click = depending of an option (by default: select color from all layers).
2. Ctrl+Alt+click = depending of an option (by default: select layer on the active layer selected).

Adding options to both color pick behavior could be a cleaner way to add new behaviors and something extensible.
Then the problem would be: where to expose in the user interface the new configuration ? The logic would be in the tool-option panel of the ColorPickerTool. But in this case, it would require the FreehandPaintTool and the ColorPickerTool to share the same settings. It would also imply the user to do way and back jumps between both tools to access the option and change it. ( But that's not a problem, the key 'V' while painting and the option of the LineTracingTool already use this design). i might remember some works were pushed in this direction recently (unifying the ColorPickerTool options while using FreehandPaintTool) for a feature to sample just a "percent of the target color". I saw it on the mailing-list. If this refactor was done, reviewed and accepted then this second alternative would probably easier and cleaner to integrate. How you would call this feature to fit on a small label of text?

I am more than sure that is pice of cake for developer to bring that kind of addition


The "I am more than sure" is probably not appropriate here. You probably dislike when someone tell "I am more than sure that is piece of cake for you to change the pose of this character in this illustration". In the best case; you can just sound as naive about computer programming. In the worth, offensive because it is not a good recognition of the amount of work necessary for development of any part of an application. I know that wasn't bad intention or done on purpose: that's why I do this feedback on the footer of my answer o)


gpedrycz
Registered Member
Posts
2
Karma
0

Re: Color Picker Improvements

Fri Jun 01, 2018 5:42 pm
Sorry a lot for " piece of cake " phrase I didnt want offense anybody :)

About implementation . From my 8 years of experiance working in Photoshop with bigger illustrations like that one
http://www.pedryczart.com/media/gallery/40.jpg most of artist us option " pic that layer and bellow " in 80% of time . because we have tons of effects and on dozen of layers so its only way to keep work flow smooth. So you second proposition keeping 2 shortcuts variant is more than enough .

About Color picker docker options . It will be more convenient if we will be able to setup primary and secondary variant of color picker tool behavior from color picker docker . I mean have a option slider : primary mode ( 3 options ) secondary mode ( three options ) and for these two options changing shortcut in shortcut menu . They need to be be renamed ofc : primary mode , secondary mode , ctrl+click , ctrl+alt+ click etc

That exactly how it work in Photoshop . In ps we just have only 1 shortcut ( cant bye changed ) and in docker we changing what kind of behavior picker will have.
But honestly no matter how you wish to handle that in UI it wil be game changer to artist creating more complex stuff like I am . There are chance to make that happend ? Right now that small features blocking my in using Krita in bigger commercial works ;/
User avatar
Deevad
Registered Member
Posts
451
Karma
1
OS

Re: Color Picker Improvements

Fri Jun 01, 2018 10:59 pm
Ok, on my side, I'm not a dev, so I can't add this type of feature. The next step for your feature request is to open a ticket on the bug tracker here https://bugs.kde.org/enter_bug.cgi?product=krita labeled as a "wish". Explain on it the feature and link to this discussion to the forum.

gpedrycz wrote:"small features blocking my in using Krita"


Be aware there is a lot of "wish" in the bug tracker and schedule of developers is overloaded already by many task . But sometime, during rewriting a part, this wish might find a developer with time for it. It can be month, years... So don't count on that bug-report to have effect into the next release (but who knows?). If you want to use Krita on short term, you'll have for sure to adapt.

gpedrycz wrote: "wil be game changer to artist creating more complex stuff like I am", "bigger commercial works"


I do large and complex commercial work with Krita since 2012. I was also Photoshop teacher (concept-art/illustration) in CG school for years. With years of experience in this field, it is the first time I hear about this specific usage of the color-picker. So, I guess the "game changer" will be relative in this case. If it would be a game changer, the team would have this feature request written ten time each month on the bug-tracker since years and everyone would complain about that on the forum and network. But It is not the case... Nothing is wrong in saying it is a feature that brings comfort for your own workflow and even if you are alone, that's fine. No need to try using manipulation like that fat "game changer". Don't transform your need into the problem of a project or a missed opportunity to reach your goal by putting pressure on other. Wrong strategy and counterproductive in open-source for your wish. :P

The feature is interesting, the choice of an alternative option to pick color of all the layer stack bellow the active one for the Ctrl+Alt+Click sounds good.
It deserve now a descent [wish] ticket in the bug-tracker in case a developer focus energy and pay attention on this topic. If you care about Krita and want to help making it better for the long term, report it.




Bookmarks



Who is online

Registered users: Bing [Bot], Google [Bot], Sogou [Bot]