This forum has been archived. All content is frozen. Please use KDE Discuss instead.

jpeg 2000 support

Tags: None
(comma "," separated)
aboxer
Registered Member
Posts
8
Karma
0

jpeg 2000 support

Sun Aug 18, 2019 11:36 pm
Hello!

Just discovered Krita and I think it's awesome!
My question - are there plans to add jpeg 2000 support
via OpenJPEG ? If so, I would be interested in helping out.
I have quite a bit of experience with OpenJPEG, so if someone prepares
the ground for a new codec, I can do the j2k-specific work.

Thanks,
Aaron
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: jpeg 2000 support

Mon Aug 19, 2019 7:22 am
Krita actually used to have an jpeg 2000 import/export filter using openjpeg. It was removed because we had nobody to maintain it, and because lots of people would save to jpeg 2000 thinking they had saved to jpeg and would come to us complaining Krita's jpeg files were invalid. The filter was removed in 2016, in commit 3747300737ffed138ae321b66234cab682481594.

It might be worth it to go back to before that commit and check out the state of the code as it was then -- or it might be easier to create a new plugin from scratch.
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Mon Aug 19, 2019 1:58 pm
Thanks, I guess users ruin everything! :)
Yes, I think easiest approach is to revive the old plugin - perhaps we can warn the user
to beware - they are not saving to jpeg.
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Mon Aug 19, 2019 2:00 pm
btw, I would be happy to support this plugin.
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: jpeg 2000 support

Mon Aug 19, 2019 6:02 pm
aboxer wrote:btw, I would be happy to support this plugin.


If you mean that you want to maintain it (fixing bugs, updating the openjpeg library when needed and so on), then you're very welcome :-) I can resurrect the old code and put it in a branch so work on it can begin.
User avatar
TheraHedwig
KDE Developer
Posts
1794
Karma
10
OS

Re: jpeg 2000 support

Mon Aug 19, 2019 6:32 pm
It might be worth it to check the pages on building Krita from source if you are indeed that serious. That way you can test your changes. If you need live-help, you can find us on #krita on freenode.
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Thu Aug 22, 2019 1:38 pm
OK, thanks! Yes, I am interested in maintaining and fixing bugs.
First, let me get Krita building.
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Thu Aug 22, 2019 1:59 pm
So, I get a build error:

QUAZIP_LIBRARIES
linked by target "kritastore" in directory /home/aaron/src/kritadev/build/krita/libs/store

I am on Disco Dingo, and I have installed the dependencies.
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Thu Aug 22, 2019 2:03 pm
"You will want to get the ‘dev’ library here, because you’re doing dev, and then Krita is using Qt5, so select that one. I"

What do you mean by select ? :)
User avatar
TheraHedwig
KDE Developer
Posts
1794
Karma
10
OS

Re: jpeg 2000 support

Thu Aug 22, 2019 2:05 pm
aboxer wrote:"You will want to get the ‘dev’ library here, because you’re doing dev, and then Krita is using Qt5, so select that one. I"

What do you mean by select ? :)

Select as in, use that library name for install.

Again, it's very recommendable to join #krita on freenode for live-help, we even have a webclient if you're new to irc.
User avatar
halla
KDE Developer
Posts
5092
Karma
20
OS

Re: jpeg 2000 support

Thu Aug 22, 2019 2:16 pm
This is the right package:

libquazip5-dev/disco,now 0.7.6-2 amd64 [installed]
C++ wrapper for ZIP/UNZIP (development files, Qt5 build)
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Thu Aug 22, 2019 2:21 pm
right, building now !
aboxer
Registered Member
Posts
8
Karma
0

Re: jpeg 2000 support

Thu Aug 22, 2019 2:43 pm
I think we can close this, and open new issues as they arise.


Bookmarks



Who is online

Registered users: bancha, Bing [Bot], Evergrowing, Google [Bot], Sogou [Bot]