I made patch for dragonplayer https://git.reviewboard.kde.org/r/125022/ it's enough to be seen and reviwed? Second patch https://git.reviewboard.kde.org/r/125069/ now conflicts with master, best practice to update patch?

anthonyfieroni wrote:I made patch for dragonplayer https://git.reviewboard.kde.org/r/125022/ it's enough to be seen and reviwed? Second patch https://git.reviewboard.kde.org/r/125069/ now conflicts with master, best practice to update patch?

You should publish them, so that people can see and review them.

If I click on your links, I only get:

You don't have access to this review request.

This review request is private. You must be a requested reviewer, either directly or on a requested group, and have permission to access the repository in order to view this review request.

When i click "Pusblish" alert appear "There must be at least one reviewer before this review request can be published."

anthonyfieroni wrote:When i click "Pusblish" alert appear "There must be at least one reviewer before this review request can be published."

Well, then add a reviewer or a review group (at the top right).
In your case, kdemultimedia (as group) might be a good choice.

They will get a notification about your review request.

Yeah, ty assign them to kdemultimedia and dolphin, now you can see them I will port Dragon to Solid/Power, but api is missing from last 2 versions 5.13 and 5.14, /usr/include/KF5/Solid/Solid/Power not present.

anthonyfieroni wrote:Yeah, ty assign them to kdemultimedia and dolphin, now you can see them

Yes, I can.

But you cannot give yourself a "Ship it!". A reviewer has to do that. That's the whole point of the review...

I think to make it visible to others To remove it?

anthonyfieroni wrote:I think to make it visible to others

The workflow normally goes like this:
- you create your review request, add some reviewers and publish it
- people maybe give comments
- if the maintainer(s) is/are fine with your patch, they give you a "Ship It!"
- you then submit your patch to the git repo (if you don't have a developer account, you can also ask for it being committed on your behalf), and mark the review request as "submitted" (preferably you specify the review request in your commit message, which closes it automatically then)

See also:
https://techbase.kde.org/Development/Review_Board

To remove it?

I'm not sure.
It might be possible that nobody will review it any more as it already has a "Ship It!".
If you don't get a reply in some days, you probably better discard it and create a new one. But that are only my personal thoughts.