This forum has been archived. All content is frozen. Please use KDE Discuss instead.

What am I allowed to do in SVN?

Tags: svn svn svn
(comma "," separated)
User avatar
JanGerrit
Moderator
Posts
647
Karma
3
OS

What am I allowed to do in SVN?

Sun Aug 16, 2009 1:47 pm
Hello,
I read the SVN Commit Policies on Techbase, but I was wondering about this:
Am I allowed to add code to e. g. Dolphin? I mean, the maintainer could not be happy with it.

An example:
If you search in Dolphin through the Nepomuk search bar the search field isn't cleared after pressing ENTER. I think it's a bug, am I allowed to correct it (I've got a SVN account) without creating a bug-report (for this I did, but I wanted to know it)?


Image
mattr
KDE Developer
Posts
24
Karma
0
OS
JanGerrit wrote:Hello,
I read the SVN Commit Policies on Techbase, but I was wondering about this:
Am I allowed to add code to e. g. Dolphin? I mean, the maintainer could not be happy with it.

An example:
If you search in Dolphin through the Nepomuk search bar the search field isn't cleared after pressing ENTER. I think it's a bug, am I allowed to correct it (I've got a SVN account) without creating a bug-report (for this I did, but I wanted to know it)?

In general, it's best to send a patch to the maintainer or maintainers of a project in order for them to look it over first. You could also post it on reviewboard.kde.org. This is the best thing to do to get feedback about your patch to ensure that the patch is correct, that the intended behavior that your patch would fix is indeed a bug, and that you have permission to commit your patch. It also ensures you won't be yelled at after the commit because you broke something.

In other words, use your best judgement as to whether or not you actually want to commit the patch straightaway or send it for review first.


Matt
User avatar
anda_skoa
KDE Developer
Posts
783
Karma
4
OS

Re: What am I allowed to do in SVN?

Mon Aug 17, 2009 12:46 pm
In case of file managment related discussions post to mailinglist kfm-devel.
Patches are, as mattr already wrote, best sent through reviewboard.kde.org

In your case use group "Dolphin".

Quite often maintainers will tell you after a while to commit right away.

Cheers,
_


anda_skoa, proud to be a member of KDE forums since 2008-Oct.
User avatar
JanGerrit
Moderator
Posts
647
Karma
3
OS

Re: What am I allowed to do in SVN?

Mon Aug 17, 2009 2:42 pm
Thanks, mattr and anda_skoa for these explanations :)


Image


Bookmarks



Who is online

Registered users: Bing [Bot], daret, Google [Bot], sandyvee, Sogou [Bot]