Hello,

I happened to notice this while browsing the 4.5.4 release announcement pages and looking at kdelibs/kdecore/util/kshareddatacache.cpp

Code: Select all

unsigned KSharedDataCache::totalSize() const

has added:

Code: Select all

if (lock.failed()) {
  return false;
}

Returning bool false for return type unsigned - is this a potential problem or does the code check for MAX_UINT or whatever?

See http://websvn.kde.org/branches/KDE/4.5/ ... ev=1193778

Regards,
Vishal

I suggest contacting the developer of the code in question or the KDE Core Development mailing list (kde-core-devel@kde.org) regarding this.

Yup, sent this in an email to the list, apparently its still in moderation queue - will post back if there's a response thanks

This is definitely wrong, but unfortunately not triggering any build error or warning due to bool being interpretable as integer and vice versa.

In thise it is pure luck that no error happens because false is usually 0 and total size of 0 will usually not lead to any further lookup access of the cache.

Good catch!

Cheers,
_