Code: Select all

mkdir deb-temp-build
cd deb-temp-build
apt source libkf5holidays5
cd kholidays-*
# edit src/parsers/plan2/holidayparserdriverplan.cpp
debuild -us -uc -nc
sudo dpkg -i ../libkf5holidays5_*.deb
# logout and login

https://git.reviewboard.kde.org/r/129667/diff/ ---diff holidayparserdriverplan.cpp
https://git.reviewboard.kde.org/r/129668/diff/ ---missing holidays

I've noticed that in the calendar for the 2017 it says that Orthodox Easter is on 3rd of April 2017, but as far as I know both the Orthodox and the Catholic Easter are on the same day which is 16th of April 2017. Additionally, Orthodox Good Friday is supposedly on 1st of April - Saturday, and Orthodox Holy Saturday is on 2nd of April - Sunday.

Armistice Day, which was on the 11th of November 2016, was not present in the calendar at all, even though it is an official holiday in Serbia.


Please correct this error permanently. I'm tired and frustrated when I need after every major update to correct these errors. If you update the SSDM then I have to correct Xsetup because I have two monitors. I reported this bug regular.

Hi,
please note that the issue is not Neon-specific. Of course they could backport the patch but I guess we all agrees that it's better if the patches goes upstream first. That said:

alideda wrote:https://git.reviewboard.kde.org/r/129667/diff/ ---diff holidayparserdriverplan.cpp

Fixed in the Applications/16.12 branch. It will be available in the KDE Applications 16.12.2 (currently scheduled for February 9th)
https://commits.kde.org/kholidays/63786 ... c4a628b969

https://git.reviewboard.kde.org/r/129668/diff/ ---missing holidays

Fixed in the master branch. It will be available in KDE Applications 17.04 (around April).
https://commits.kde.org/kholidays/10b2b ... 2b35ee7753

If you want to help and know how to compile, you could always leave feedbacks in the review requests after testing the code!
And many thanks again to Chusslove Illich who submitted them.

I've tested a correction, not sent unchecked Instruction. Compile and Testing in Kubuntu 16.04, Mint 18 KDE, Maui 2, Neon...
And many thanks again to Caslav who submitted them on elitesecurity forum Serbia.

alideda wrote:I've tested a correction, not sent unchecked Instruction. Compile and Testing in Kubuntu 16.04, Mint 18 KDE, Maui 2, Neon...

I didn't mean that you sent unchecked instructions. I wanted to say that, as you tested, you could leave some feedback on the review and that sometimes can help reviewers to proceed with the acceptance of a patch.