I just finished my first contribution to the KDE project! But now I'm stuck because I don't know who should get my code to review it. It seems that KIO is not under the Reviewboard's all seeing eye, so I think I need to send my code to KIO's maintainer. Any ideas who that might be?

P.S. What I did was modify the rename/overwrite dialog window to make it a bit more user friendly, and that coupled with some of the changes that have been added for 4.6 by the KDE devs, it looks quite nice.

I've put several kio patches through reviewboard.

A bunch of people care for KIO, but I'm probably what comes closest to a maintainer. Anyway, KIO (the library) is part of kdelibs, so you can choose kdelibs in reviewboard.

AHA! David, you do exist! Look at Bug#238942. This is the bug I was fixing. I've actually sent out a patch just a few hours ago to KDE-devel mailist.

Next time I'll use the reviewboard. Thanks.

Correction: I have not sent it out but left it in my 'Drafts' folder in my email.

I have now tried to send it to the reviewboard but I get this error when I hit submit:

Unable to parse diff revision header '2010-09-21 20:25:28.243294647 -0400'

Reviewboard is very stringent about what it will accept. For instance, it won't accept Git diff's for an SVN repository.

I actually used Kompare to create a diff from my source code and from the the individual source code from the svn repo that I downloaded onto my desktop. Is this causing the problem?

lin-unix wrote:I actually used Kompare to create a diff from my source code and from the the individual source code from the svn repo that I downloaded onto my desktop. Is this causing the problem?

Probably, I had no end to problems with doing it that way. svn can automatically create diffs between your version and the version stored on the svn repository, and these have worked much more reliably with reviewboard than kompare's diffs. I don't remember the command off hand, it is in the svn man page on my system.