Nope. Not quite, not yet. Something else needed here:

/home/chris/src/kwin2/kde-workspace ! $ git add kwin/effects/highlightwindow/highlightwindow.cpp
/home/chris/src/kwin2/kde-workspace ! $ git commit
On branch KDE/4.11
Your branch is ahead of 'origin/KDE/4.11' by 1 commit.
(use "git push" to publish your local commits)

nothing to commit, working directory clean

Not there yet:

/home/chris/src/kwin2/kde-workspace ! $ git add kwin/effects/highlightwindow/highlightwindow.cpp
/home/chris/src/kwin2/kde-workspace ! $ git commit
On branch KDE/4.11
Your branch is ahead of 'origin/KDE/4.11' by 1 commit.
(use "git push" to publish your local commits)

nothing to commit, working directory clean

Not quite, not yet. Something else needed here:

/home/chris/src/kwin2/kde-workspace ! $ git add kwin/effects/highlightwindow/highlightwindow.cpp
/home/chris/src/kwin2/kde-workspace ! $ git commit
On branch KDE/4.11
Your branch is ahead of 'origin/KDE/4.11' by 1 commit.
(use "git push" to publish your local commits)

nothing to commit, working directory clean
/home/chris/src/kwin2/kde-workspace ! $

Regarding the review submit: none of the buttons execute the 'submit'. Neither 'publish' or 'shipIt!'

use "git.reviewboard.kde.org", svn is legacy (and you're not operating on any svn branch

"Publish" should make the patch publically available - can you post the direct link to your review here? (So we can see the state of the review)

"git add" is only to add files that have so far not been tracked by git, ie. you've to

$ git add my_brand_new_file.txt
then
$ git commit -am "I added a brand new file"

where you'd just
$ git commit -am "I edited some present files"

(-a commits all changes you made, -m is for the message string)

review request: https://git.reviewboard.kde.org/r/119310/